From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 710145934 for ; Thu, 6 Oct 2016 17:41:32 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id i130so12059216wmg.1 for ; Thu, 06 Oct 2016 08:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=sQLf7TOdHPrhS5wNGZFmn1CSTxXuCJc6d390D28jY5k=; b=RfK3s2ng2I5s2FGO4O77bmCBEOM9V1yuKLFR9VPT8sYOww4KA/lfZpHcw4DjX3A6ui vJ7dEBq/0O3KCLE6n+dvkMhOJRJ0F1tUYzhzEqZcB46MKQfGG/TjSG4965BZqzndvwx5 +Aw5PObRkd1HUkdiz9uILQ3kMYFSXhs/2nnLRILc0/chsSFDB2c/X/lCBVrpVcVrKxG1 +HT8uf0Qj5xgNeAfYFcoqg8u8wGEFp+6QOoVWp/lKh5y1YAo4yT1tJ0nV1l0zNgkzua4 R6V//JwIMfZQbZyO7vhg+qvHtRROeYasHdnwSie0+/qGf8fPYv53vS23HcJe63H21UPe n8aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=sQLf7TOdHPrhS5wNGZFmn1CSTxXuCJc6d390D28jY5k=; b=b5hw/JoTQfDay2nBpGvomLuPKbZJGx0H3BC93GAAcMByqQh07AvudOejrtzWYycmUu hhvgHVTlWlwbJRtvv8x+Kc/Uyuc5slsTLOxWJ4vwfFtJmEWSCfOLVDu6CkK10laGeq0/ OI9lLlRFwGyMR/nEZ6NqMhVWC9Rykqep4PwENp1fitsikPsToxWiY8MK5vCdp4XmpT3K +Ja4PU2rEwPQP/trxduI+kEI+17bR/qKGYWtCAzen/IlyxaFl1tc+e5yTxMj3Y8yEBPt OddrbKD5SYYZUyrlB8K93b9IAeTH6dlhTUGE34lPIGYIkbYE9+DJva8uW7kUhQffIAxX EFpg== X-Gm-Message-State: AA6/9Rnf3je45gcXvxYSi0bnhFfM06AhuXeGDMyGULVUYrclODuSY/fNeWtcvo28xdavKoyr X-Received: by 10.194.112.68 with SMTP id io4mr12708133wjb.1.1475768492240; Thu, 06 Oct 2016 08:41:32 -0700 (PDT) Received: from xps13.localnet (102.202.154.77.rev.sfr.net. [77.154.202.102]) by smtp.gmail.com with ESMTPSA id gg10sm15114904wjd.4.2016.10.06.08.41.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Oct 2016 08:41:31 -0700 (PDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: dev@dpdk.org, "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , "jerin.jacob@caviumnetworks.com" Date: Thu, 06 Oct 2016 17:41:28 +0200 Message-ID: <4741428.MAME74GNI7@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A08F8EF@IRSMSX108.ger.corp.intel.com> References: <1475592734-22355-1-git-send-email-bernard.iremonger@intel.com> <1884200.vdWHEKFaxn@xps13> <8CEF83825BEC744B83065625E567D7C21A08F8EF@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal callback function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2016 15:41:32 -0000 2016-10-06 15:32, Iremonger, Bernard: > > > > 2016-10-06 12:26, Bernard Iremonger: > > > > > void > > > > > _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > > > > - enum rte_eth_event_type event) > > > > > + enum rte_eth_event_type event, void *param) > > > > > > > > You need to squash the patches updating the calls to this function. > > > > Otherwise, this patch does not compile. > > > > > > I will have to squash everything into one patch, separate patches will not > > compile. > > > > No you can keep a separate patch for the VF event in ixgbe. > > I have 4 patches at present > > librte_ether > net/ixgbe > drivers/net > app/test > > Would this be acceptable or do you just want everything squashed into librte_ether except for net/ixgbe? You can test the compilation of each patch with this command: git rebase -i origin/master -x scripts/test-build.sh or just: git rebase -i origin/master -x make I think you need to squash drivers/net (adding just NULL param) and app/test in ethdev patch.