From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63B2FA054A; Wed, 8 Jun 2022 10:30:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 215A341132; Wed, 8 Jun 2022 10:30:47 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 0064E40689 for ; Wed, 8 Jun 2022 10:30:45 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id ABA2E5C00F2; Wed, 8 Jun 2022 04:30:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 08 Jun 2022 04:30:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1654677043; x= 1654763443; bh=nbRowg41AJd0JPivSgjUBAFfeKgGBJsm0wQxIzdaimc=; b=i XG0piZvYR7FZjSncHuZNaVv++R2rcJM2C4JDGiTcohSF83lJXZftOP3pPf5D0bH/ 8YcQBAOX6NCTzrEdBV4RvowJLyVG1XBEphq/iRVWkszzzZtit1W7u0f8eMDpkgYM 5VG9/sHQ3kY2ZmW2m6DkVMq3GJ13wiHjTzS+7ICMSOrgUN4s7hKlWIImwvTDcVr4 2qifJ84XSWs8qZo4RoFrPM7QvLBEfflzJyMaHgT2lqkIojIh2/CULGwnJXJKtlC+ djV7/NhpC7/DdDzhXOWCflcoR1yzywYZicZfBrTnIP/ZTWV/ibxpa5kxavLoL334 uh1nBJ5hm6wHKoG8p7oWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1654677043; x= 1654763443; bh=nbRowg41AJd0JPivSgjUBAFfeKgGBJsm0wQxIzdaimc=; b=n i32FmiAuIYT2G/xJ012p1wHxuhKpk11+ZjK2ffu7Q+I5WRy/pLYROcTDYrjXtHs+ ltXXxRNM0f3uVfmd2vFgBQ6AX+cpkBQ4QTtj05bZU1zpEodg9+A+Xd8NRCHr7w2O gLZ47o90HtDLKtbbgVSU8Oa9g4Gbjn4qPDQiMkiYGEYCVYSIyQpDljGD6PXOO74E 8vcNfY0UBf8sLnzmIgl72rzow4HdI5IWtmIjJemoxuBAy+oiHIr+77BtC39uA9mo Y3GLdKrKcCk4NQdhw2JWyUWN0vZRyG/C7yLevRtTwsImff7vQeBweURWNevq64EY Hs/yi0EeEFYUM1ADVGAUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddtjedgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeehueefleegheegueejheegteeluddvieektdfhvddtheefffei vdehtdeflefhtdenucffohhmrghinhepmhgvshhonhgsuhhilhgurdgtohhmpdhgihhthh husgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Jun 2022 04:30:40 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: Bruce Richardson , Jerin Jacob , dpdk-dev , Ruifeng Wang , Jan Viktorin , David Christensen , Konstantin Ananyev , David Marchand , Juraj =?utf-8?B?TGlua2XFoQ==?= , fengchengwen Subject: Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build Date: Wed, 08 Jun 2022 10:30:39 +0200 Message-ID: <4742743.31r3eYUQgx@thomas> In-Reply-To: References: <20220602092356.2788089-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/06/2022 10:22, Jerin Jacob: > On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob wrote: > > > > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon wrote: > > > > > > 02/06/2022 11:43, Jerin Jacob: > > > > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson > > > > wrote: > > > > > > > > > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jerinj@marvell.com wrote: > > > > > > From: Jerin Jacob > > > > > > > > > > > > By default, ccache is not used for cross build[1]. > > > > > > Update all cross files to use ccache if it is available > > > > > > in build machine. > > > > > > > > > > > > [1] > > > > > > https://mesonbuild.com/Machine-files.html > > > > > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > > > > > Does this still work even if ccache is not available? That's not fully > > > > > > > > Yes. > > > > > > > > > clear from the docs, but it seems to be that if an array is passed the > > > > > whole array is used as the command, rather than just one element of the > > > > > array. That would imply that cross-builds now require ccache. Is that > > > > > acceptable? > > > > > > > > I have removed ccache from the build machine still it works. > > > > > > I don't understand why it works without ccache. > > > > Meson is detecting valid compiler prefix. ccache is one of them. > > > > See > > https://github.com/fabio-porcedda/meson/commit/44db495f5ece43645ca3994dc95895c76a828530 > > https://github.com/mesonbuild/meson/issues/1392 > > I hope there are no other review comments to fix it for this patch. > Since it is improving the build time for cross-build. If there is no > objection to this patch, Please merge it. I've tested it now and I see a big blocker. This patch is breaking the use of devtools/test-meson-builds.sh so I cannot merge it as-is, sorry.