From: Thomas Monjalon <thomas@monjalon.net>
To: Yuanhan Liu <yliu@fridaylinux.org>
Cc: "Gaëtan Rivet" <gaetan.rivet@6wind.com>,
"Ferruh Yigit" <ferruh.yigit@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax
Date: Wed, 24 Jan 2018 11:21:44 +0100 [thread overview]
Message-ID: <4742912.xRQpCbhV5k@xps> (raw)
In-Reply-To: <20180124092827.GU29540@yliu-mob>
24/01/2018 10:28, Yuanhan Liu:
> On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote:
> > 24/01/2018 07:43, Yuanhan Liu:
> > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote:
> > > > 23/01/2018 13:46, Yuanhan Liu:
> > > > > If port not found, then the whole string will be used for dev attachment.
> > > > > It means we are attaching a port with PCI BDF == 04.00.0 AND
> > > > > port == 0 (the 2nd port will not be attached).
> > > > >
> > > > >
> > > > > And here is how the devargs would look like if "matching;settings" is
> > > > > being used:
> > > > >
> > > > > bus=pci,id=04:00.0/class=eth,port=0;bus=pci,id=04:00.0/class=eth,port=0/driver=mlx4,mlx4_arg_A=val,...
> > > > >
> > > > > The part before ";" will be used for lookup and the later part will be
> > > > > used for attachment. It should work. It just looks redundant.
> > > >
> > > > It does not have to be redundant.
> > > > It can be:
> > > > bus=pci,id=04:00.0/class=eth,port=0;driver=mlx4,mlx4_arg1=settings1,...
> > >
> > > I knew you would make such reply :)
> > > Then there is a contradiction. According your suggestion, the "port=0" belongs
> > > to the matching section, but it also has to be used in the settings section.
> >
> > If port=0 is matched, it is already set, right?
>
> Yes.
>
> > Why it needs to be in settings?
>
> But I was talking the case it's not matched, say it's not probed and here
> we do hotplug.
I don't understand.
Anyway, the port property should be read-only.
Are we talking about the dev_port from the Linux kernel?
next prev parent reply other threads:[~2018-01-24 10:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 14:50 Yuanhan Liu
2018-01-16 16:33 ` Mcnamara, John
2018-01-16 23:19 ` Gaëtan Rivet
2018-01-16 23:22 ` Thomas Monjalon
2018-01-16 23:46 ` Gaëtan Rivet
2018-01-17 0:03 ` Thomas Monjalon
2018-01-17 9:37 ` Gaëtan Rivet
2018-01-17 9:43 ` Thomas Monjalon
2018-01-17 10:11 ` Gaëtan Rivet
2018-01-17 10:54 ` Thomas Monjalon
2018-01-17 12:34 ` Ferruh Yigit
2018-01-18 7:35 ` Yuanhan Liu
2018-01-18 8:46 ` Thomas Monjalon
2018-01-18 9:46 ` Gaëtan Rivet
2018-01-23 12:46 ` Yuanhan Liu
2018-01-23 14:29 ` Thomas Monjalon
2018-01-23 16:08 ` Gaëtan Rivet
2018-01-23 17:22 ` Thomas Monjalon
2018-01-23 17:37 ` Gaëtan Rivet
2018-01-23 18:12 ` Thomas Monjalon
2018-01-24 15:24 ` Yuanhan Liu
2018-01-24 16:51 ` Thomas Monjalon
2018-01-24 6:43 ` Yuanhan Liu
2018-01-24 8:19 ` Thomas Monjalon
2018-01-24 9:28 ` Yuanhan Liu
2018-01-24 10:21 ` Thomas Monjalon [this message]
2018-01-24 10:36 ` Yuanhan Liu
2018-01-24 10:37 ` Thomas Monjalon
2018-01-24 15:04 ` Yuanhan Liu
2018-01-24 16:57 ` Thomas Monjalon
2018-01-25 14:41 ` Yuanhan Liu
2018-01-25 14:58 ` Thomas Monjalon
2023-06-08 22:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4742912.xRQpCbhV5k@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).