From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 83B993195 for ; Wed, 24 Jan 2018 11:22:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EDCEC22674; Wed, 24 Jan 2018 05:22:24 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 05:22:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=btdNOrsWaUDlDBfrn/jza+EIq8 z2u/PQ6gMuWfubq1A=; b=cZh5K6s5KmdaLPPKkgt1XhEj6R+lHHOfSqe2RgHI7n HOv+1eu/nRUXwFnHBcVrrcM9u7uFxRB1eyP1lc+nqM8IBCGiJ4htnz8dYiFT0snw 5r5OjI4UYAo1HHkiqYy+zvl/yLn29emWWaw9fxr9CZv33my+N9QQn8d73G7/M6zp U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=btdNOr sWaUDlDBfrn/jza+EIq8z2u/PQ6gMuWfubq1A=; b=o8Wn387rfOgmLWMmgaLO9w oN3TNpXi6S/BoIr3B7bshgJKEGza3zUSqfFIlf5CfqftWG6bvaXdQrdoxujmLJ3b ofGtUwf3lk3s9du1kOkVvh+t+y6dreh9KUWzbYy4+DVrGPVGRXZS+lmlphKFDADm WIAWhLVy4HeI86L7nXLfPVvx3MkgbnaRxY0SrvG2FMYtDrVChSMkmS60qgUyN7Qy 0oMU53dqqVwOR9Y8RoMBMKRkTQ8B5rAle4DBaQmVG3moAIcpOiswzDDyAuNYtXxc UURzcSlf53eNGfD7NINEcgPwBJ5E5qLYyc1LlkqfyqF2Ic5L/8MCDZdSEJXLLcJg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9B2EB7E1BE; Wed, 24 Jan 2018 05:22:24 -0500 (EST) From: Thomas Monjalon To: Yuanhan Liu Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Ferruh Yigit , dev@dpdk.org Date: Wed, 24 Jan 2018 11:21:44 +0100 Message-ID: <4742912.xRQpCbhV5k@xps> In-Reply-To: <20180124092827.GU29540@yliu-mob> References: <1516114218-21501-1-git-send-email-yliu@fridaylinux.org> <1680850.DZ6KxSLkSi@xps> <20180124092827.GU29540@yliu-mob> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 10:22:25 -0000 24/01/2018 10:28, Yuanhan Liu: > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > 24/01/2018 07:43, Yuanhan Liu: > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > > > 23/01/2018 13:46, Yuanhan Liu: > > > > > If port not found, then the whole string will be used for dev attachment. > > > > > It means we are attaching a port with PCI BDF == 04.00.0 AND > > > > > port == 0 (the 2nd port will not be attached). > > > > > > > > > > > > > > > And here is how the devargs would look like if "matching;settings" is > > > > > being used: > > > > > > > > > > bus=pci,id=04:00.0/class=eth,port=0;bus=pci,id=04:00.0/class=eth,port=0/driver=mlx4,mlx4_arg_A=val,... > > > > > > > > > > The part before ";" will be used for lookup and the later part will be > > > > > used for attachment. It should work. It just looks redundant. > > > > > > > > It does not have to be redundant. > > > > It can be: > > > > bus=pci,id=04:00.0/class=eth,port=0;driver=mlx4,mlx4_arg1=settings1,... > > > > > > I knew you would make such reply :) > > > Then there is a contradiction. According your suggestion, the "port=0" belongs > > > to the matching section, but it also has to be used in the settings section. > > > > If port=0 is matched, it is already set, right? > > Yes. > > > Why it needs to be in settings? > > But I was talking the case it's not matched, say it's not probed and here > we do hotplug. I don't understand. Anyway, the port property should be read-only. Are we talking about the dev_port from the Linux kernel?