From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AA91E1B16B for ; Thu, 11 Jan 2018 09:53:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 00:53:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,343,1511856000"; d="scan'208";a="18379789" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by FMSMGA003.fm.intel.com with ESMTP; 11 Jan 2018 00:53:52 -0800 To: "Lu, Wenzhuo" , Stephen Hemminger Cc: "dev@dpdk.org" , "Wu, Jingjing" References: <1515388414-16214-1-git-send-email-wenzhuo.lu@intel.com> <1515564961-79227-1-git-send-email-wenzhuo.lu@intel.com> <1515564961-79227-3-git-send-email-wenzhuo.lu@intel.com> <20180110091525.7f6abb3b@xeon-e3> <6A0DE07E22DDAD4C9103DF62FEBC09093B70E202@shsmsx102.ccr.corp.intel.com> From: Ferruh Yigit Message-ID: <474da82a-0924-4cd2-c882-2f7c2cd39112@intel.com> Date: Thu, 11 Jan 2018 08:53:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B70E202@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 08:53:58 -0000 On 1/11/2018 2:07 AM, Lu, Wenzhuo wrote: > Hi Stephen, > >> -----Original Message----- >> From: Stephen Hemminger [mailto:stephen@networkplumber.org] >> Sent: Thursday, January 11, 2018 1:15 AM >> To: Lu, Wenzhuo >> Cc: dev@dpdk.org; Wu, Jingjing >> Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD >> >> On Wed, 10 Jan 2018 14:15:49 +0800 >> Wenzhuo Lu wrote: >> >>> + >>> +#define AVF_MAX_NUM_QUEUES 16 >>> +/* Vlan table size */ >>> +#define AVF_VLAN_TB_SIZE (4096 / (CHAR_BIT * sizeof(uint32_t))) >> >> You could use ETHER_MAX_VLAN_ID (which is 4095). >> Also it is most efficient if bit tables use unsigned long to access. > Thanks for the suggestion. > I found this macro is useless. I'd like just removing it. > > Hi Ferruh, > As this patch set is accepted to next-net, I can sent a fixes patch for this change. Is it OK? Would you like helping merge the fixes to the original patch? Thanks. Hi Wenzhuo, That is OK, I can squash fixes on top original set in next-net.