From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 707EEB62 for ; Tue, 24 Nov 2015 19:16:14 +0100 (CET) Received: by wmww144 with SMTP id w144so150187910wmw.1 for ; Tue, 24 Nov 2015 10:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=U8Q6WJBGXbLhhyHc0hxkiniZg/kpTu6XpHU1Lm5dkQI=; b=drqaQwbiUgTjDxnvHRkZIL7sSBThdJ8i71UHWePxDlK51Q76d3oXKnjPu0H2CZYzHY FSFl/cc8t+QuXbeL0yGzhPlpDGSB9742Erhu+xBXcsFIApc7v+Vw+L6ObEFt0TcNxtkp kPl0QUlWdhrDl7N3LG0uYuT7VssvLZc9qAozm2BK3Atd5MOw52L3dsA9OfqCc9QQUw77 LwRafEhCo/R6r8bETWplIin5hoP7zLjpPTTDFQJM8FomxW2DdbkbmI8qvgxOfI4oCDlU e6r8XnrsCdWhmxWDbmJ1vR9tqqmowC/dFOyZOPpRABDt1qKkWuFqf8G2FZFWHBd0Wem7 IrPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=U8Q6WJBGXbLhhyHc0hxkiniZg/kpTu6XpHU1Lm5dkQI=; b=ZCH+QtLfwafNBYryBuG2aUhJfa/TkXQVOa6bd93FQHBhxp5AbtC4ViqNENJBIKUCh4 R7r/wnWdkBOA2T3ezCu6OmETA2DDiFMKgBrWvCH8bXlHw/koT3fbCdNADqCtA4m9JNUh Qgo5b5D9fv1uoM4OKrk2EgDLw4y4FL00WgHUSrTltKPKKcM83eIqBgCejhFR9AXdAeu/ 3FvJWxMi/Ta2cb+5E1phmC+mQdpq19+JXIIiOZUZGIf5fltG0oljmf5V3YQocjXlpDvb IxFiNICp5IDOHkAtIYYlyyBxH1OTk7vqKeQieh9lxJVNy3eXFPUQAShNIRBL001iKJ3B xeWg== X-Gm-Message-State: ALoCoQkz3xjm2VxVRJiKITwHwSFLagR06R7yOdR/nxpDUGRycRNu6EogTUzOWKY5J/hzr817Uc1W X-Received: by 10.194.87.201 with SMTP id ba9mr2280205wjb.125.1448388970200; Tue, 24 Nov 2015 10:16:10 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id u17sm19420527wmd.8.2015.11.24.10.16.09 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Nov 2015 10:16:09 -0800 (PST) From: Thomas Monjalon To: "Mcnamara, John" Date: Tue, 24 Nov 2015 19:14:52 +0100 Message-ID: <4758699.k09jfibQCa@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1448242808-16101-3-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/2] scripts: add build tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 18:16:14 -0000 2015-11-24 17:49, Mcnamara, John: > Very useful. We should add these scripts to the contributing guide at some point. Yes > One minor nit. "q" is used for "quick" in this script and "quiet" in the checkpatch script. Maybe for consistency use "f" for fast or "n" for no-doc or something else. Consistency of short options is a difficult job. -f may work but can also be used to "force" in another script. I'll change it to -s (short) if there is no other comment.