From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 82ECD91A0 for ; Tue, 20 Oct 2015 09:53:17 +0200 (CEST) Received: by wicll6 with SMTP id ll6so15289554wic.1 for ; Tue, 20 Oct 2015 00:53:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=M5dZYW7HNk0N99H61c6ZJ04HMWYovt+9f6W5frCVYEE=; b=acFZcz9uoeNCKQBaNwd332HQiwNXvFH7/RaO2nZPaJhWUSGs/vUbzASqKOEfOLksX2 GUAD2g9dWzjrYJDbB6lLIU50bpx4ZM6ixJrRaIoGHGRUWtoUohIO8IH7dcJpGL7zmFGx QBWRNBO4vfJNuW+R7v9GkymtqM/ygy1XdwPda01RNJQS/4OZzSDya7Yh+Wh9lBimbD5B ZsRz9RU+3I3v+r58RiNJx8cmWROYACIbZ/3+vmJt8j1M2DE+q8CwX3s4eMjb7skIJiF1 Qns7zxK0X7k1FfJirynEdoAVK/RC+KeyR4SH5tBbU4Rk7Au4+DzZOQIzqxrK7mvGQu79 4UuQ== X-Gm-Message-State: ALoCoQmQ8+iUWpXP0mvQRLJbCScofQH9QGgogrS48IrDEhO6GE6UX84HLzyTe3V9nJOq5LbymcJl X-Received: by 10.194.103.38 with SMTP id ft6mr2594173wjb.15.1445327596457; Tue, 20 Oct 2015 00:53:16 -0700 (PDT) Received: from xps13.localnet (124.26.90.92.rev.sfr.net. [92.90.26.124]) by smtp.gmail.com with ESMTPSA id ee5sm2141219wjd.17.2015.10.20.00.53.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2015 00:53:16 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Date: Tue, 20 Oct 2015 09:27:37 +0200 Message-ID: <4759700.UeY5nRH9Wr@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151020072327.GV3115@yliu-dev.sh.intel.com> References: <1444369572-1157-1-git-send-email-yuanhan.liu@linux.intel.com> <2143283.gKIdjTGCRD@xps13> <20151020072327.GV3115@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, marcel@redhat.com, "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v6 06/13] virtio: read virtio_net_config correctly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 07:53:17 -0000 2015-10-20 15:23, Yuanhan Liu: > On Tue, Oct 20, 2015 at 09:07:49AM +0200, Thomas Monjalon wrote: > > 2015-10-09 13:46, Yuanhan Liu: > > > From: Changchun Ouyang > > > > > > The old code adjusts the config bytes we want to read depending on > > > what kind of features we have, but we later cast the entire buf we > > > read with "struct virtio_net_config", which is obviously wrong. > > > > When describing a bug, it is important to explain what is the consequence, > > i.e. which use case is failing. If it is only to prepare the new feature, > > it is better to clearly state that the bug had no impact until now. > > > > And as usual, the "fix" word in the title and the "Fixes" tag are required. > > What's the right way supposed to use "Fixes" tag, BTW? Checking the git > hisotry, I saw something like: > > Fixes: $commit_hash ($commit_log). In http://dpdk.org/dev, this git alias is recommended: fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' > Which basically means it's a regression fix. However, in this case, it's > more than like a bug, but not a regression. Referencing the original commit (introducing the bug) makes it clear.