From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5FE801B205
 for <dev@dpdk.org>; Wed,  3 Oct 2018 21:36:43 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id ECBC020B63;
 Wed,  3 Oct 2018 15:36:42 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 03 Oct 2018 15:36:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=B7lbglxtP5tiyQRlPmgrQeyWM/aFqApTjDyWkzR59XM=; b=sixonseMJ82J
 +DcjLUuE+oQFDldn6tg3CBn0T7WBwtOfkKkoWyXcNXTB14D3pYGL00N9Mfss1BR/
 2iEQzmsriqUrjPANWwJ/pLE/StJOb7DAA2AHlfofjC1WV+yFTSPlTbBBU5z6+Blx
 BLi5/05dCdod+DWEIwvNSlsxlUPJEh8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm3; bh=B7lbglxtP5tiyQRlPmgrQeyWM/aFqApTjDyWkzR59
 XM=; b=u1cz9M5jX28Zgo+zfe4A0BPviuJOZwU3PbOTNzwC335m9Ysw9xmUy9PNB
 Mf3+NJITYY4H8QJPmlEGFk0/NphYtv3KxKQNA5kR9C1iZecUR3guh1O59XpFRKd7
 4ocx5z895lB+zw91k0mLPA9NG5t1sv5dPw/Kut5VsB2rzihv7KtFcAJbNWMq/cGj
 NGy2kfZv/Q38Fpe4NyRhqTjQKAdx7efL50PbR5L0vAA5GBsjybCZQdZqfF+Fsl+Y
 ubynO9nU67jTTF/99QXNV/e2FXK+WQMbnLW4fNcuaJx6w4gDi2x7yVxn5n50HBY3
 bDRg5cd8QTvFZqOXEFMqSwHlyLdOg==
X-ME-Sender: <xms:SRq1W2AlOEutXa1wXnsWOSN5HzJT-Vbe0JMirQEacP_LGNTJZQVWjQ>
X-ME-Proxy: <xmx:SRq1W-Dh689IqsJsRnJTS-MxsjChiHLeZ3iKEcjqLWgXRLoUZkrX0g>
 <xmx:SRq1W2e1uBal8bUi9KwQzAntPcGcexVnI6YfCf759LSyETZwYStm_Q>
 <xmx:SRq1W5JEWhZbjzJGLBjXvDcYo_ZzAlXLtorGav-lKID0NzvNjrD8LA>
 <xmx:SRq1W5dJOg5T2jtRG2qiFk3EAzxUYgr5QaczfiUSd7jKtlI8BA3etQ>
 <xmx:SRq1Ww2ytxGDLDz96YmEP3adhsDQiAN4t3m_5hicVUi0NlGdH-Kwhg>
 <xmx:Shq1W5CsQbmuM1ywavfXU1nx5Ij46rhRPdyiIaP4WwN_Svr9leA91Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 5D8B6E49D9;
 Wed,  3 Oct 2018 15:36:40 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: Mattias =?ISO-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>,
 dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org,
 gaetan.rivet@6wind.com, shreyansh.jain@nxp.com,
 Ciara Power <ciara.power@intel.com>, Brian Archbold <brian.archbold@intel.com>
Date: Wed, 03 Oct 2018 21:36:39 +0200
Message-ID: <4764579.GE1JWGAuKW@xps>
In-Reply-To: <72e3e8d1-fa63-2531-a3c3-2d0c9ee5d151@ericsson.com>
References: <1535026093-101872-1-git-send-email-ciara.power@intel.com>
 <20181003173612.67101-3-kevin.laatz@intel.com>
 <72e3e8d1-fa63-2531-a3c3-2d0c9ee5d151@ericsson.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Subject: Re: [dpdk-dev] [PATCH v2 02/10] telemetry: add initial connection
	socket
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 19:36:43 -0000

03/10/2018 20:40, Mattias R=F6nnblom:
> On 2018-10-03 19:36, Kevin Laatz wrote:
> > +#define DEFAULT_DPDK_PATH "/var/run/.rte_telemetry"
> > +
>=20
> FHS 3.0 recommends "/run" over "/var/run". Maybe a more descriptive=20
> macro name would be in order, too.

Kevin, you should use eal_get_runtime_dir().
You may need to export this function as a public API.

Mattias, thank you for the detailed review.