From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E500A04DB; Tue, 17 Nov 2020 10:58:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E305B567C; Tue, 17 Nov 2020 10:58:32 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 544ED37B0 for ; Tue, 17 Nov 2020 10:58:31 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 87F1658012E; Tue, 17 Nov 2020 04:58:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 17 Nov 2020 04:58:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Tky20uMv3IElQnD3NmBSY7U8IucekyP6rLJ2V7rCK5k=; b=GYkBvTYAdUgJFn1F hTeBRMWA5gS5VsLWzUG/5KYFj0MCDg42VlVDPfNnNAdMap9g6nCCsmpg6vLfOL9D 4uPCOgGJ5fnWzfNu2tF0fGDrdu3t4Rof/lhF4T1aL+ao01Zf6lv+BLjni1MisXBQ Y0+sKoqeecB1QQhqyZKbRTXzVpLOwdNqbg3nC17mIgNdRNF8ghjXX/4XQDFINhK7 /V3ZP1kEN09DUsWMb99LOQ160mn3xcBfwXX6moEgRFoBMGadL80ap9NR68+i77c5 r2w/2RlLNQrrexWcJGZpUPYbndvgVy//25qbfCx/NRgmiN4kiaGHK9ibqXa7JlZn rD4igw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Tky20uMv3IElQnD3NmBSY7U8IucekyP6rLJ2V7rCK 5k=; b=JkI+K2iYdV8BukI/sixJ9Pq6mtEdlMh3+aPucyV8SL+ej+7/NSKOFeQ89 NiAyJa1vO0Y7y2pZhLdossu8oXbtKFa5wUy/jKkQ7bKTmpWjbSn9ipMVaYT7slFj 5lK+APsnsHjznQi6h/NoGNi69QwrhvFbHV9pHsesIUHDtN+1GmP+V/EgnuJEm/41 1WdjUiHyRXb6KZh9nIr/KU3PV2ypNgNOfEKhedSWF/l3TVqnLR534USt5y0Xa2UH uy+1jWBlS2BzDBJNQvgTHZaVhXSwFDoZDUF2NAlpmk9YhabBUKPl0Xjn3WLoLZpk sNMjqxFACp477x71YK9l36p+Qn/xg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeffedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffeiffdtteekhefhvdegvdfgleefvefftdekgfefjefhledtieev udeljeejheejnecuffhomhgrihhnpehtgihtrdhithdptghomhhprghtihgsihhlihhthi drshhonecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 65CEB3064AAA; Tue, 17 Nov 2020 04:58:27 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Juraj =?utf-8?B?TGlua2XFoQ==?= , Honnappa Nagarahalli , Ruifeng Wang , Phil Yang , "vcchunga@amazon.com" , Dharmik Thakkar , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , "ferruh.yigit@intel.com" , "dev@dpdk.org" , "david.marchand@redhat.com" , nd Date: Tue, 17 Nov 2020 10:58:25 +0100 Message-ID: <4773604.Inh7acMc2i@thomas> In-Reply-To: <20201117091518.GA1522@bricha3-MOBL.ger.corp.intel.com> References: <1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech> <2366611.vJsMBebm0t@thomas> <20201117091518.GA1522@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v12 01/14] build: alias default build as generic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/11/2020 10:15, Bruce Richardson: > On Tue, Nov 17, 2020 at 08:49:45AM +0100, Thomas Monjalon wrote: > > 17/11/2020 03:46, Honnappa Nagarahalli: > > > > > >=20 > > > >=20 > > > > 16/11/2020 17:16, Bruce Richardson: > > > > > On Mon, Nov 16, 2020 at 03:50:31PM +0000, Juraj Linke=C5=A1 wrote: > > > > > > From: Thomas Monjalon > > > > > > > 13/11/2020 15:31, Juraj Linke=C5=A1: > > > > > > > > The current machine=3D'default' build name is not descripti= ve. The > > > > > > > > actual default build is machine=3D'native'. Add an alternat= ive > > > > > > > > string which does the same build and better describes what = we're > > > > building: > > > > > > > > machine=3D'generic'. Leave machine=3D'default' for backwards > > > > compatibility. > > > > > > > > > > > > > > What? > > > > > > > > > > > > > > "generic" means... nothing. > > > > > > > > > > > > > > > > > > > An absence of anything means nothing. Generic means "characteri= stic of > > > > or relating to a class or group of things; not specific", which is = pretty much > > > > what we're looking for. > > > > > > > > > > > > > "default" should be the most common set of options to make a = build > > > > > > > work everywhere. > > > > > > > > > > > > What we want is a value of machine that would "be the most comm= on > > > > set of options to make a build work everywhere" and using the above > > > > definition of generic, it fits very well. > > > > > > The reason I said the actual default build is machine=3D'native= ' is because > > > > that's how the machine option is defined in meson_options.txt. It f= ollows > > > > from what default actually means - "a preselected option adopted by= a > > > > computer program or other mechanism when no alternative is specifie= d by > > > > the user or programmer". Default then means no user input, which me= ans > > > > machine=3D'native', which means the default build is the default bu= ild. > > > > > > > > > > > > What ""default" should mean" looks like an attempt at redefinin= g what > > > > the word actually means and leads to confusion, in my experience. H= ence an > > > > attempt to remove the potential ambiguity. > > > > > > > > > > > > > > > > I would tend to agree that "generic" is probably a better term th= an > > > > > "default" for what we use it for here in the config. > > > >=20 > > > > In the past, we had a different definition with make config. > > > > I am just trying to be consistent. > > > > Even with meson, default means "minimal CPU instructions". > > > >=20 > > > > Example in devtools/test-meson-builds.sh: > > > > "test compilation with minimal x86 instruction set" > > > > is called build-x86-default. > > > >=20 > > > > In config/meson.build: > > > > " > > > > machine type 'default' is special, it defaults to the per arch agre= ed common > > > > minimal baseline needed for DPDK. > > > > That might not be the most optimized, but the most portable version= while > > > > still being able to support the CPU features required for DPDK. > > > > This can be bumped up by the DPDK project, but it can never be an i= nvariant > > > > like 'native' > > > > " > > > >=20 > > > > So, why this definition is called "generic" in meson Arm config? > > > The explanation above is for a build type 'default'. Whereas meson by= default builds for build type 'native'. Also when you look at the config/a= rm/meson.build the word 'default' was used where it was not related to the = build type default. It created lot of confusion. > > >=20 > > > From the dictionary 'default' - "a preselected option adopted by a co= mputer program or other mechanism when no alternative is specified by the u= ser or programmer." But, if one had to do build of type default, they have = to mention -Dmachine=3Ddefault. If nothing is mentioned, it is a build type= 'native', which does not go along with the definition of 'default'. > > >=20 > > > But for 'generic' - "characteristic of or relating to a class or grou= p of things; not specific". IMO, it better suits the explanation you have p= rovided above. So, separating this machine type to 'generic' to cover the s= ame definition makes more sense. > > >=20 > > > However, 'default' is still supported for backward compatibility. > >=20 > > So? Are you going to change the DPDK definitions we had for years? > >=20 >=20 > I think we should, or at least support "generic" alongside it. Using the = term > "default" for something that is not the default is confusing. It's also n= ot > a good description of what the result is, since it's a generic binary for > the architecture, rather than a "default" one for the architecture. OK in this case, please do the patch which changes it everywhere, not only for Arm. We can change our names as long as it is explained and have some consistency.