From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.
Date: Mon, 30 Mar 2015 17:32:15 +0200 [thread overview]
Message-ID: <4775667.Icro2s1yKj@xps13> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F417A98@SHSMSX101.ccr.corp.intel.com>
2015-03-30 15:23, Xie, Huawei:
> On 3/30/2015 11:08 PM, Thomas Monjalon wrote:
> > 2015-03-30 14:52, Xie, Huawei:
> >> On 3/30/2015 8:25 PM, Thomas Monjalon wrote:
> >>> 2015-03-30 08:31, Xie, Huawei:
> >>>> On 3/9/2015 11:45 PM, Huawei Xie wrote:
> >>>>> ---
> >>>>> MAINTAINERS | 7 +++++++
> >>>>> 1 file changed, 7 insertions(+)
> >>>>>
> >>>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>>> index 07fdf5e..b4327d3 100644
> >>>>> --- a/MAINTAINERS
> >>>>> +++ b/MAINTAINERS
> >>>>> @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_*
> >>>>> F: examples/vhost_xen/
> >>>>> F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
> >>>>>
> >>>>> +Linux Xen VIRTIO
> >>>>> +M: Huawei Xie <huawei.xie@intel.com>
> >>>>> +F: lib/librte_pmd_xenvirt/
> >>>>> +F: examples/vhost_xen/
> >>>>> +F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
> >>>>> +
> >>>>> FreeBSD EAL (with overlaps)
> >>>>> M: Bruce Richardson <bruce.richardson@intel.com>
> >>>>> F: lib/librte_eal/bsdapp/Makefile
> >>>>> @@ -226,6 +232,7 @@ F: lib/librte_pmd_mlx4/
> >>>>> F: doc/guides/prog_guide/mlx4_poll_mode_drv.rst
> >>>>>
> >>>>> RedHat virtio
> >>>>> +M: Huawei Xie <huawei.xie@intel.com>
> >>>>> M: Changchun Ouyang <changchun.ouyang@intel.com>
> >>>>> F: lib/librte_pmd_virtio/
> >>>>> F: doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst
> >>>> Thomas:
> >>>> Comments with this patch? Need i add "MAINTAINERS:" into the subject?
> >>> This patch is wrong because you are duplicating an existing section.
> >>> I think you want to split Xen support maintenance. If you are sure it's a
> >>> good idea, please send a correct patch.
> >> Yes, i am mainly the author of XEN virtio PMD and host part and would
> >> like to review that part.
> >> Should i split those two sections and move XEN virtio PMD and host part
> >> to driver section?
> > Yes you cannot duplicate lib/librte_pmd_xenvirt/.
> > If you want to split "Linux Xen" section, just do it.
> > I already explained that to Jijiang. I don't even understand why we have to
> > discuss it again and again. Please just do the right split.
> >
> >>> About vhost, maybe you want to split virtio and vhost?
> >>>
> >> About vhost, i will maintain those two parts. Is there issue with the
> >> format?
> > In my understanding Changchun was maintaining virtio, so I thought you were
> > interested in vhost only.
> >
> Is there issue with two co-maintainers?
> I was the co-author(with Rashmin) of original static virtio-pmd library,
> and would review the patch with changchun to keep it healthy.
No it's OK. I now clearly understand that this part of the patch is right.
You want to co-maintain virtio and vhost. OK
I had a doubt because you failed with Xen split.
next prev parent reply other threads:[~2015-03-30 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 15:44 Huawei Xie
2015-03-09 15:44 ` Huawei Xie
2015-03-30 8:31 ` Xie, Huawei
2015-03-30 12:24 ` Thomas Monjalon
2015-03-30 14:52 ` Xie, Huawei
2015-03-30 15:07 ` Thomas Monjalon
2015-03-30 15:23 ` Xie, Huawei
2015-03-30 15:32 ` Thomas Monjalon [this message]
2015-03-30 15:35 ` Xie, Huawei
2015-07-13 10:22 ` [dpdk-dev] [PATCH v2] MAINTAINERS: claim responsibility for virtio PMD and vhost library Huawei Xie
2015-07-13 10:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4775667.Icro2s1yKj@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).