From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 6D38F3238 for ; Mon, 30 Mar 2015 17:32:56 +0200 (CEST) Received: by wgra20 with SMTP id a20so178678997wgr.3 for ; Mon, 30 Mar 2015 08:32:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=DHOlCh17LQCmYxIQJgHRRB1yIZPEwh4qA2XJxXoTK4I=; b=Ugth8IR3htNNLj3NX9cA6yQc4bmRwBUaIV2EuLQot6u86NST/1RiZ5rXw62UUF7qEe wYAsUc8qoNAigqrjgKNq217p5JY+cFfuQocQITsbpkxl2w0zwmeeHqnDvY5/4HWYJduP uBlEW0Qsk+dvF9vMJOnx9hjlklKKBHCkTCvsfu6495qnZjCIz9SzaVtKoDZR6E5wxgUm UDquXRgycYgDMPEPluqM1r29ET1MZgT1JCiydY1tmWgSugattV2UwtIlDtot/FwQTP6M Vval/diYEmAfA58lcWwwL49dC+8rG6lZpQNJ0wxlT3U5gsgRaj1UEpgjaExaRQTPGtZX mVwg== X-Gm-Message-State: ALoCoQnwYYH1IFNaOYVjyeFNcfzQpmbU+MPa48bXC64x37RgWY4RExXtXmsNpKLA4PsvuGiju+CG X-Received: by 10.194.176.162 with SMTP id cj2mr63813048wjc.93.1427729576236; Mon, 30 Mar 2015 08:32:56 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gt4sm16180927wib.21.2015.03.30.08.32.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2015 08:32:55 -0700 (PDT) From: Thomas Monjalon To: "Xie, Huawei" Date: Mon, 30 Mar 2015 17:32:15 +0200 Message-ID: <4775667.Icro2s1yKj@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1425915850-14934-1-git-send-email-huawei.xie@intel.com> <3159342.39RF9GQ1Cv@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 15:32:56 -0000 2015-03-30 15:23, Xie, Huawei: > On 3/30/2015 11:08 PM, Thomas Monjalon wrote: > > 2015-03-30 14:52, Xie, Huawei: > >> On 3/30/2015 8:25 PM, Thomas Monjalon wrote: > >>> 2015-03-30 08:31, Xie, Huawei: > >>>> On 3/9/2015 11:45 PM, Huawei Xie wrote: > >>>>> --- > >>>>> MAINTAINERS | 7 +++++++ > >>>>> 1 file changed, 7 insertions(+) > >>>>> > >>>>> diff --git a/MAINTAINERS b/MAINTAINERS > >>>>> index 07fdf5e..b4327d3 100644 > >>>>> --- a/MAINTAINERS > >>>>> +++ b/MAINTAINERS > >>>>> @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_* > >>>>> F: examples/vhost_xen/ > >>>>> F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst > >>>>> > >>>>> +Linux Xen VIRTIO > >>>>> +M: Huawei Xie > >>>>> +F: lib/librte_pmd_xenvirt/ > >>>>> +F: examples/vhost_xen/ > >>>>> +F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst > >>>>> + > >>>>> FreeBSD EAL (with overlaps) > >>>>> M: Bruce Richardson > >>>>> F: lib/librte_eal/bsdapp/Makefile > >>>>> @@ -226,6 +232,7 @@ F: lib/librte_pmd_mlx4/ > >>>>> F: doc/guides/prog_guide/mlx4_poll_mode_drv.rst > >>>>> > >>>>> RedHat virtio > >>>>> +M: Huawei Xie > >>>>> M: Changchun Ouyang > >>>>> F: lib/librte_pmd_virtio/ > >>>>> F: doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst > >>>> Thomas: > >>>> Comments with this patch? Need i add "MAINTAINERS:" into the subject? > >>> This patch is wrong because you are duplicating an existing section. > >>> I think you want to split Xen support maintenance. If you are sure it's a > >>> good idea, please send a correct patch. > >> Yes, i am mainly the author of XEN virtio PMD and host part and would > >> like to review that part. > >> Should i split those two sections and move XEN virtio PMD and host part > >> to driver section? > > Yes you cannot duplicate lib/librte_pmd_xenvirt/. > > If you want to split "Linux Xen" section, just do it. > > I already explained that to Jijiang. I don't even understand why we have to > > discuss it again and again. Please just do the right split. > > > >>> About vhost, maybe you want to split virtio and vhost? > >>> > >> About vhost, i will maintain those two parts. Is there issue with the > >> format? > > In my understanding Changchun was maintaining virtio, so I thought you were > > interested in vhost only. > > > Is there issue with two co-maintainers? > I was the co-author(with Rashmin) of original static virtio-pmd library, > and would review the patch with changchun to keep it healthy. No it's OK. I now clearly understand that this part of the patch is right. You want to co-maintain virtio and vhost. OK I had a doubt because you failed with Xen split.