From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9F07E2C19 for ; Wed, 10 Apr 2019 12:55:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 03:55:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="134531884" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.134]) ([10.237.220.134]) by orsmga006.jf.intel.com with ESMTP; 10 Apr 2019 03:55:43 -0700 To: Ferruh Yigit , "Hunt, David" , dev@dpdk.org References: <20190409092201.7886-1-david.hunt@intel.com> <601a96fa-1a3e-9d98-8d78-df96c4ebd400@intel.com> From: "Burakov, Anatoly" Message-ID: <477cdad2-ac7e-5d0b-3468-8844770352f0@intel.com> Date: Wed, 10 Apr 2019 11:55:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 10:55:46 -0000 On 10-Apr-19 8:52 AM, Ferruh Yigit wrote: > On 4/9/2019 3:40 PM, Hunt, David wrote: >> >> On 9/4/2019 12:18 PM, Burakov, Anatoly wrote: >>> On 09-Apr-19 10:22 AM, David Hunt wrote: >>>> A previous change removed the limit of 64 cores by >>>> moving away from 64-bit masks to char arrays. However >>>> this left a buffer overrun issue, where the max channels >>>> was defined as 64, and max cores was defined as 256. These >>>> should all be consistently set to RTE_MAX_LCORE. >>>> >>>> The #defines being removed are CHANNEL_CMDS_MAX_CPUS, >>>> CHANNEL_CMDS_MAX_CHANNELS, POWER_MGR_MAX_CPUS, and >>>> CHANNEL_CMDS_MAX_VM_CHANNELS, and are being replaced >>>> with RTE_MAX_LCORE for consistency and simplicity. >>>> >>>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays") >>>>      Coverity issue: 337672 >>>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays") >>>>      Coverity issue: 337673 >>>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays") >>>>      Coverity issue: 337678 >>> >>> No need to mention the same commit three times :) >>> >> >> The coverity output said to add this, so I was leaving nothing to >> chance... :) > > Can use comma separated list for multiple issues fixed, like: > > Coverity issue: 277209, 277215, 277225 > Fixes: c7e9729da6b5 ("net/nfp: support CPP") > Cc: stable@dpdk.org > It makes it harder to grep for coverity issues, so -1 on the CSV. -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9CB93A0096 for ; Wed, 10 Apr 2019 12:55:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 071004CC3; Wed, 10 Apr 2019 12:55:47 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9F07E2C19 for ; Wed, 10 Apr 2019 12:55:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 03:55:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="134531884" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.134]) ([10.237.220.134]) by orsmga006.jf.intel.com with ESMTP; 10 Apr 2019 03:55:43 -0700 To: Ferruh Yigit , "Hunt, David" , dev@dpdk.org References: <20190409092201.7886-1-david.hunt@intel.com> <601a96fa-1a3e-9d98-8d78-df96c4ebd400@intel.com> From: "Burakov, Anatoly" Message-ID: <477cdad2-ac7e-5d0b-3468-8844770352f0@intel.com> Date: Wed, 10 Apr 2019 11:55:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410105542.VG6V2uASBOv9NgUC4GqNNUjCnuX2I3ZIWgtIjK73_AI@z> On 10-Apr-19 8:52 AM, Ferruh Yigit wrote: > On 4/9/2019 3:40 PM, Hunt, David wrote: >> >> On 9/4/2019 12:18 PM, Burakov, Anatoly wrote: >>> On 09-Apr-19 10:22 AM, David Hunt wrote: >>>> A previous change removed the limit of 64 cores by >>>> moving away from 64-bit masks to char arrays. However >>>> this left a buffer overrun issue, where the max channels >>>> was defined as 64, and max cores was defined as 256. These >>>> should all be consistently set to RTE_MAX_LCORE. >>>> >>>> The #defines being removed are CHANNEL_CMDS_MAX_CPUS, >>>> CHANNEL_CMDS_MAX_CHANNELS, POWER_MGR_MAX_CPUS, and >>>> CHANNEL_CMDS_MAX_VM_CHANNELS, and are being replaced >>>> with RTE_MAX_LCORE for consistency and simplicity. >>>> >>>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays") >>>>      Coverity issue: 337672 >>>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays") >>>>      Coverity issue: 337673 >>>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays") >>>>      Coverity issue: 337678 >>> >>> No need to mention the same commit three times :) >>> >> >> The coverity output said to add this, so I was leaving nothing to >> chance... :) > > Can use comma separated list for multiple issues fixed, like: > > Coverity issue: 277209, 277215, 277225 > Fixes: c7e9729da6b5 ("net/nfp: support CPP") > Cc: stable@dpdk.org > It makes it harder to grep for coverity issues, so -1 on the CSV. -- Thanks, Anatoly