From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 800DC558A for ; Fri, 18 Nov 2016 02:10:03 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 17 Nov 2016 17:10:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,655,1473145200"; d="scan'208";a="32629534" Received: from rhorton-mobl.ger.corp.intel.com (HELO [10.239.205.72]) ([10.239.205.72]) by orsmga005.jf.intel.com with ESMTP; 17 Nov 2016 17:09:59 -0800 To: Qiming Yang , dev@dpdk.org References: <1479375779-46629-1-git-send-email-qiming.yang@intel.com> <1479375779-46629-2-git-send-email-qiming.yang@intel.com> Cc: jingjing.wu@intel.com, jing.d.chen@intel.com From: Remy Horton Organization: Intel Shannon Limited Message-ID: <477f9dcb-dfc4-e227-bb80-805cf65adef5@intel.com> Date: Fri, 18 Nov 2016 09:09:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1479375779-46629-2-git-send-email-qiming.yang@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 01:10:04 -0000 On 17/11/2016 17:42, Qiming Yang wrote: > This patch added API for 'rte_eth_dev_fwver_get' > > void rte_eth_dev_fwver_get(uint8_t port_id, > char *fw_version, int fw_length); Suggest description such as: This patch adds ethdev API for fetching firmware version. Also see Thomas's comments. Looks like some stale patches got picked up by 'git send-mail *.patch'.. ..Remy