From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id D1A1C2A5B
 for <dev@dpdk.org>; Thu, 16 Apr 2015 10:25:41 +0200 (CEST)
Received: by widdi4 with SMTP id di4so184781785wid.0
 for <dev@dpdk.org>; Thu, 16 Apr 2015 01:25:41 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=6LP14jnYK1bs6h7JIfbLJoEuZnZGIDBwkrZOGghxovc=;
 b=XC9nkWpTHcSv0w2auh0I539Tj+NiJydrccRySBae3vmAFC6lxHiq5XEMjI6NeccP32
 XNyrRlHJ3uv6as8M8AqbenOsyrqN3QDgjo0tIl+bbZh1lo+/Tps75Yik9vmTZhBA7WhC
 fjqbgXaEVNuygZjtQtMWYhzAwJMKXRrl3/Fsd4YHJfkvf4RXrNvAl1mBz352WlhdlkUb
 dS29+YPlH7Io4lejJ12iYlKc6M/4bQdPDehn+yJBtBmFu9o5ucLed/TGIg13OP9qmJPQ
 eOAG9T3u2eVH+Srh3FR2e5zocbKWOADUv2Wx1Co1tudQSjlwsSgSM6IPlqRkVDeTjMRw
 dHBw==
X-Gm-Message-State: ALoCoQkfbbYesHSsMiaU3sg5mFhtmtGCV9q1PyRcsqpBXWuBLmzAn/dMKoSdO4dxrKfdTjvt+oiK
X-Received: by 10.194.19.35 with SMTP id b3mr27890134wje.24.1429172741679;
 Thu, 16 Apr 2015 01:25:41 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id l3sm24954194wiv.18.2015.04.16.01.25.40
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 16 Apr 2015 01:25:40 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ravi Kerur <rkerur@gmail.com>
Date: Thu, 16 Apr 2015 10:24:57 +0200
Message-ID: <4780798.Fhdhc6hoDZ@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <1428608412-31191-3-git-send-email-rkerur@gmail.com>
References: <1428608301-31033-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-3-git-send-email-rkerur@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 2/8] Move common functions in eal.c
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Apr 2015 08:25:42 -0000

Hi Ravi,

I think this patch is too complex and move too many different things:
- sysfs
- mem_cfg
- proc_type
- application_usage
Please split them up.

I'm not sure the classification in eal_common_runtime.c and eal_common_system.c
new file is clear.

2015-04-09 12:40, Ravi Kerur:
> +	mem_config = (struct rte_mem_config *) mmap(NULL, sizeof(*mem_config),

Why this cast is needed?