DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: "Hore, Soumyadeep" <soumyadeep.hore@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Greenwalt, Paul" <paul.greenwalt@intel.com>,
	"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
	"Jiale, SongX" <songx.jiale@intel.com>
Subject: Re: [PATCH] net/iavf: check PTP capabilities during init
Date: Tue, 25 Nov 2025 14:07:41 -0800	[thread overview]
Message-ID: <47850b29-0ed2-4a24-9047-e73905657535@intel.com> (raw)
In-Reply-To: <CY8PR11MB774717DEAC152077562DB837F9D1A@CY8PR11MB7747.namprd11.prod.outlook.com>


[-- Attachment #1.1: Type: text/plain, Size: 951 bytes --]



On 11/25/2025 2:30 AM, Hore, Soumyadeep wrote:
> Hi Jacob,
> 
> Currently PTP features are not enabled in DPDK. We only have the Rx timestamp API in place. Typically the change that you want needs to be implemented in ethdev_ops.timesync_enable(), which is not implemented.
> 

I'm not sure I follow you here. For iAVF Rx timestamping is considered
part of the PTP capabilities. We shouldn't be reporting Rx timestamp
offload if Rx timestamping is not available. There are some
circumstances where the PF will not report Rx timestampding (and will
not enable it) because of capabilities mismatch. However, DPDK driver is
saying Rx timestamp offload works, and trying (and failing) to enable it
in those cases.

However, the check for where we report Rx timestamp offload was before
we negotiated properly with the PF, which is what this change is trying
to fix.

This has nothing to do with other PTP features.

Thanks,
Jake

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

      parent reply	other threads:[~2025-11-25 22:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21 23:39 Jacob Keller
2025-11-24 12:09 ` Bruce Richardson
2025-11-24 21:34   ` Jacob Keller
2025-11-24 15:45 ` Patrick Robb
2025-11-25 10:30 ` Hore, Soumyadeep
2025-11-25 13:12   ` Bruce Richardson
2025-11-25 23:57     ` Jacob Keller
2025-11-25 22:07   ` Jacob Keller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47850b29-0ed2-4a24-9047-e73905657535@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=dev@dpdk.org \
    --cc=paul.greenwalt@intel.com \
    --cc=songx.jiale@intel.com \
    --cc=soumyadeep.hore@intel.com \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).