From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87E21A00C3; Tue, 18 Jan 2022 10:52:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09D5F426FE; Tue, 18 Jan 2022 10:52:07 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id D655B4068E; Tue, 18 Jan 2022 10:52:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642499525; x=1674035525; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=W25hK66zJlwi1xYVomp4NkdBHGxHJEbYu/1TwlkGZhc=; b=GSaUuiHukEdzISVxOBCa7jkQCfWQmWE1fBksczWUl3dAJJMaONDz+wz+ /qX43YvQT1ltrbW60bs6Abjj7qCKi/gX1/3pPut1+WffzDkgANrPXrPMm h4u1bP4+qiEUq1Q8SuYiGsYneGFnyViR3z/ItCNmF1EKeRtmYHVYaxYB6 PKW8XAilkBIzQEjAxEove/l6mqUulOvRpY2A6cKMXacz8YaHSDD3UxZ2T lKSbUqr/0xSGv+07B1YLW4YrThXcLpvQpFtXBoHjqgQXhoHaeAIz+Rkhi nuTk4i2UuTCx4rVynk2Du732ULkicLWZE4XMjaXHT6PEwk0p0J5p3HkPb w==; X-IronPort-AV: E=McAfee;i="6200,9189,10230"; a="244736711" X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="244736711" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 01:52:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="595015370" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 18 Jan 2022 01:52:03 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 01:52:02 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 01:52:02 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 18 Jan 2022 01:52:02 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 18 Jan 2022 01:52:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Al2aFbM0U6ypIeuR5x7Ex62VS3nsDf+eRsqjD7xgkFHwTOr9bPDuP3H9zp8v5L4jPs4d3O/O+2Rb6LCRoCG+V/v7TBtz1Yz6S04yYlwgBEXFEn235uXmqO+Czeda+xB1mo0Q7jNd1DjVa+I4rfuCV4w2ei8Gj1K51AqfMlRQGIgDgiMBmoxnCYn1AGFReIHFgsaxnPd+Nos+6P9OCxeHbx1Gi+VDT0VSXNMcLFJmpa7ppW/i6Gna+xVqCs3zN+QxL2zUCuImVfCDAey5JpULKeK7XiBGuZtCO5Yp+0c+7Q0cPPZbwUtlqa+wFZY+DRiNN6snXcfdQjNcGC4LWjX4Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tD9D240HGyWL3uUKu/SHEliYzIG3qREJd6ldUhJ/qWA=; b=fMKeHxDuilnF5lpeO928RsJpaUk33tSWGbJXU7Nk7uCB5JZZZaMSsSIsmYbwFBo8I1WvXLhFPfnVs1Mx/338h049exw8wv8RNVuLqiiQPG59tlYjBGa04RGU0hLsi3V5nkOuft2N+ZGM3Okc00CdjjugTLW7LrFlxBOBcfRgHG5A5CjkckD0GDYy0/IkoM277U7e1U3597Gg6ZY8z1Y5fZPl0znvVpwxgXfM96POVBOpcc876E3i3KGyIrhEIsU8Zw/AWf6sHYdZyIM3QOrzn399ObwNwhqlXK0F4CsPLVF3NlRFuTv81YrvBJnrrxwxrKEJVGUi2KVkwl1gZUniJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB3109.namprd11.prod.outlook.com (2603:10b6:a03:8c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Tue, 18 Jan 2022 09:51:58 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4888.014; Tue, 18 Jan 2022 09:51:58 +0000 Message-ID: <4787802c-cefe-6d15-817f-6b906451ded8@intel.com> Date: Tue, 18 Jan 2022 09:51:53 +0000 Content-Language: en-US To: Raja Zidane , CC: Matan Azrad , References: <20211205034450.7888-1-rzidane@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode X-User: ferruhy In-Reply-To: <20211205034450.7888-1-rzidane@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0237.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60f57e35-32ed-4587-08b4-08d9da682af5 X-MS-TrafficTypeDiagnostic: BYAPR11MB3109:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:972; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6HEcatP5MY24AFh+JxEF0Jli8+VUtD9ev0jGvIJbiAygbFzSAYJ8vaf2qqcpMjgc3v88sjHGvHVnw6eQgSQD3WOTuYB6xGLGZWVEkpt35+ZzYG80jMexIp9aRGBPg8Dr8SMXPHhFCkv+y+DWoDkln8DSPkRndP8zMKHrnmQNPWV+8Dm+mhj5cJwKtHcIQn+/QYNWATKb9ILXSIQx0HscbYSil9mV52STbU1u1Q3bS48YraSjJZ2QKZJnBybEDKQf6otzv8ndaPRwKrSJfRQ+LpY3qLOxo2Fi3SWteVGHbEhr6Hf59511t6+yy0ky6tsMBdN0eIBHtcdLurfG9itvV4IN/j+C2ZOnmbt5/x81AnYIrEbTXLZA7LIV98p4Br5s90cnC+TZaAxw4vlTvKSKUyz1mgFnn+nLbfX/Y0MATRyKEr+wFdCDCCSJKjx/Nl0CnOyncuycc2nCzHF+Zm3ANyhkmYjyyQptzLMl2SrBXxCTbXjV56MNJvGrjHCm4q7kCtSrJu3yN8fLqv1iOkBjTilvgqqDb/6tcfkr6vfPwwvAQGXYTZkWWY4cqvSWg/pD+ap1VqaLoHz971W3q9+o24UOpEc1wXft2BI7doLDdKIIUBe8NJHKf6iSsXB1bNDis0LViWhvLt59eZlT2N/Uc9rjx8a99DDvOF/bOdoc2wRMvSqXOeh4f1Tau0loHEv0CRSebHIAfVYB9V9bytHSpg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(66476007)(82960400001)(66556008)(31686004)(4326008)(2616005)(316002)(5660300002)(36756003)(6512007)(44832011)(86362001)(31696002)(26005)(6486002)(8676002)(38100700002)(8936002)(186003)(2906002)(508600001)(53546011)(6506007)(83380400001)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3AxR25aaEluSHhYenJYTURzU2txblJETGdCaUVXQWxxUkRDbUlPeVNZM1Vz?= =?utf-8?B?MVM3TmF4RDZvZVg5Y2hpVHBOM29qa1RBUHIyL1B4N0JRdGFXUkRDMkhyZ2ZG?= =?utf-8?B?YnMyNnR0YllZVmJ5bU1zZEZaSWt6VEY2ZUlIQUluV3l1QTBHMUhad0Jqd3Br?= =?utf-8?B?Y1dSbmNpUVlVZTlLOUZadXA0MnNoR0g5T0pWT2RPTDUzZk1pNXdVRWY4MWJl?= =?utf-8?B?S1BZU2RrblFvWHhXbk5xOGtZc3pjdmFOODJuai9aWmJUMDVvdDNLRm9wREVq?= =?utf-8?B?Tnk3ZDIwZG1uRFg2VWZVaDc3dEVlaDhuM0VoNk1zRG16ekNMaGMxY1g1ZnVX?= =?utf-8?B?ekUwT2VjbFlVbU9XNWszV2R0NzVOa0hvTHc0bk9pZzNtd0EzRkRzeW5nUG1N?= =?utf-8?B?M1djMUo3U1VhLzN0cFl4NFF0bHpOeHphYUZNSyt4ZFdOQW9wRUt5d3dRakI5?= =?utf-8?B?azBJell5UVdud3dFQjFPSVJnVW1sVzlUYkRwcHZiWXcxNloybU1OaW10T1RI?= =?utf-8?B?c3Q0RHBXL0pOTG5sWUVlRTc4NC9ITlVVQ1A2WXo1NXBTWjRoVmtsZHB2eFh3?= =?utf-8?B?MHRiYy85dUNPZHR3eTJuK2RaZjNOaUNJTVpRZWJmRTRORWpPRWFScWhGcEFB?= =?utf-8?B?WitJeDlVVVR5Tzg5KzM2MlBrZXoxUTloN0txU2ZMQ2FzVVhLUTRPR0RUM1c3?= =?utf-8?B?RldjK3NRMEtLaUpyQzU0ZjZQN2ZpZ3VxNFNnTVhzVjllcFIydk1EdENOb0tu?= =?utf-8?B?Skdlc0swQklFMWJXRUZNT3E2R1BTQ0tkeUdEQkhzVkpGRHcwTVhzTFBKUDRG?= =?utf-8?B?VGw5TjhUV2krYnM2aCtVakVleXZpQ01pVG5EcG5sMUpsS2p0VzhVVVpRR2Zy?= =?utf-8?B?a2kvN1A3VCtQOHNwUSszUzc1aUl4cU1Wa2hSM0k5RllIVS8wWmtrYWpzTDlU?= =?utf-8?B?NDZZekJ2dWhvMU1yQXc3TXd1YXhlemtRd1JwNWFSN0JOYWtSOTdQYnE0NEhj?= =?utf-8?B?QXRhWThLaVAwdXJlbk9vUFR6bEdrRFE5SExnNHNpV09zSitnbmtzYks2bUlL?= =?utf-8?B?TGxRcldiQXorUWZMMWk5VEdZV21vaXVuUEhKSk9tVnFMOFNjc2pHckJnOHRk?= =?utf-8?B?MmlBcUVhUU1rZGNZN3NnZDhmRXV4ZnpqajB3ZFVPbzVLeEZiUWtXcExHVnRE?= =?utf-8?B?MU4vcllaeW9Icm1sNG8wVFJqYkdXVHhZUEV0RG1OVlJnWHE5SDFyamFqNmh4?= =?utf-8?B?S2JUN0Rxd3QvTFZPcjFRanFqeXMyVlBod0JFbWZiZitBcDRLSXRjam1VdFBC?= =?utf-8?B?d1JpSTdEWThwc2NjOEtjUHpveVgybG1QYisxNUpsYWNLVlBncEprNDBPemMz?= =?utf-8?B?RHovMzlCQURSYlhHclRJYUo3QmJxM096VGVyUlQvRXlLSVRDNTVIblYrakFs?= =?utf-8?B?b056bjVlMGF4N2ZBZVYxZkU5MlY5cXgrcGJ6cG8xY3VKc0gwaitwSG5VTDhW?= =?utf-8?B?Rit3MzBzSVVMRW8zQUVDa3J6YWdBSDhBSyt5TFFTZlpSeUlqenJkT0FGSWxa?= =?utf-8?B?QWtOdElGN1pvOEtFNVVzUnh1dHBBYWp1NzRERFhJcGxGcVlLTjNZdFJuUFNq?= =?utf-8?B?Nzh1WEdWYkpHdDV3ejhEbFRRQlBCM0N6QWhrTVVUek93akdhdUoyZzVoU1Jt?= =?utf-8?B?VFZIazNISlFsMW5YZ3hDNDJwUzNRVW1URGpIaENaL0p4eEY2SGJiU0c3ejZH?= =?utf-8?B?NUlFbkUyZUFsR2loaE1paW02YUJxcUc0U0dtWlNpa0QyeHU0ajMwK1lQSm5t?= =?utf-8?B?L1JSQ0ZJc0tKcVpKQy9jaFZYMEs2N1g5YStJSGx0ZmdkZzhobFFuVWs4YjEx?= =?utf-8?B?N09wQXpzV1pzajVpZG5Cc3AvNE9KSXhjTUdJNnFtMmtPbE93WkRXU241WHAr?= =?utf-8?B?b0NoUmhqM010czhDai9tUnpZZWxwNUtuckpnSlhVWWRTaDVKOHgvZGNhRXNx?= =?utf-8?B?YVB3SVFMZDhQcUNEcnNlNkU0a1BSKytoQk5HUjVVNks1M0x3dXFZWkJXV3VI?= =?utf-8?B?T3F0S2k1Q0tTVm5QbUlzWktZekVnTDRERkVscm5zalRtVWJzaEY5cUtBSlVr?= =?utf-8?B?L05kNWdhRzlHS1phb0x5OGttTWtSSXlGcGVYWWg5OUhjZDBFWWZqcVJDaVQ2?= =?utf-8?Q?DiNbAiLE4Y1VH8BuPtmkmV0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 60f57e35-32ed-4587-08b4-08d9da682af5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 09:51:58.5384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4OBvSyZkUQuH+vJhLEpx43QeFauhR5fliWm4cN64AVR8fWxGeXUiNTdxhjBDY0fWSg5P9YctCmtJ+CXH2Y8UDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3109 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/5/2021 3:44 AM, Raja Zidane wrote: > The csum FWD mode parses any received packet to set mbuf offloads for the > transmitting burst, mainly in the checksum/TSO areas. > In the case of a tunnel header, the csum FWD tries to detect known tunnels > by the standard definition using the header'sdata and fallback to check the > packet type in the mbuf to see if the Rx port driver already sign the > packet as a tunnel. > In the fallback case, the csum assumes the tunnel is VXLAN and parses the > tunnel as VXLAN. As far as I can see there is a VXLAN port check in 'parse_vxlan()', why it is not helping? > When the GENEVE tunnel was added to the known tunnels in csum, its parsing > trial was wrongly located after the pkt type detection, causing the csum to > parse the GENEVE header as VXLAN when the Rx port set the tunnel packet > type. > > Locate the GENEVE parsing trial before the packet type detection. > > Fixes: ea0e711b8ae0 ("app/testpmd: add GENEVE parsing") > Cc: stable@dpdk.org > > Signed-off-by: Raja Zidane > --- > Acked-by: Matan Azrad Ack should be before '---' to be part of the commit log, otherwise it is dropped when applied as comment. > app/test-pmd/csumonly.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index 2aeea243b6..fe810fecdd 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -254,7 +254,10 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, > info->l2_len += RTE_ETHER_GTP_HLEN; > } > > -/* Parse a vxlan header */ > +/* > + * Parse a vxlan header. > + * If a tunnel is detected in 'pkt_type' it will be parsed by default as vxlan. > + */ > static void > parse_vxlan(struct rte_udp_hdr *udp_hdr, > struct testpmd_offload_info *info, > @@ -912,17 +915,18 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE; > goto tunnel_update; > } > - parse_vxlan(udp_hdr, &info, > - m->packet_type); > + parse_geneve(udp_hdr, &info); > if (info.is_tunnel) { > tx_ol_flags |= > - RTE_MBUF_F_TX_TUNNEL_VXLAN; > + RTE_MBUF_F_TX_TUNNEL_GENEVE; > goto tunnel_update; > } > - parse_geneve(udp_hdr, &info); > + /* Always keep last. */ > + parse_vxlan(udp_hdr, &info, > + m->packet_type); > if (info.is_tunnel) { > tx_ol_flags |= > - RTE_MBUF_F_TX_TUNNEL_GENEVE; > + RTE_MBUF_F_TX_TUNNEL_VXLAN; > goto tunnel_update; > } > } else if (info.l4_proto == IPPROTO_GRE) {