From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0044.outbound.protection.outlook.com [104.47.36.44]) by dpdk.org (Postfix) with ESMTP id 478F52142 for ; Wed, 31 Aug 2016 06:24:49 +0200 (CEST) Received: from BLUPR0301CA0033.namprd03.prod.outlook.com (10.162.113.171) by BLUPR0301MB2001.namprd03.prod.outlook.com (10.164.22.15) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Wed, 31 Aug 2016 04:24:45 +0000 Received: from BY2FFO11FD010.protection.gbl (2a01:111:f400:7c0c::172) by BLUPR0301CA0033.outlook.office365.com (2a01:111:e400:5259::43) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9 via Frontend Transport; Wed, 31 Aug 2016 04:24:45 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD010.mail.protection.outlook.com (10.1.14.74) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Wed, 31 Aug 2016 04:24:45 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u7V4Ogwr016228; Tue, 30 Aug 2016 21:24:42 -0700 To: "Pattan, Reshma" , "dev@dpdk.org" References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-11-git-send-email-shreyansh.jain@nxp.com> <3AEA2BF9852C6F48A459DA490692831F01075153@IRSMSX109.ger.corp.intel.com> CC: "viktorin@rehivetech.com" , "david.marchand@6wind.com" , "thomas.monjalon@6wind.com" , "hemant.agrawal@nxp.com" From: Shreyansh Jain Message-ID: <4792de2f-e9f8-3eea-aed7-16f7fd9f1c83@nxp.com> Date: Wed, 31 Aug 2016 09:54:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F01075153@IRSMSX109.ger.corp.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131170910863313870; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(199003)(24454002)(377454003)(189002)(77096005)(76176999)(87936001)(2950100001)(189998001)(5660300001)(97736004)(86362001)(626004)(33646002)(4001350100001)(85426001)(36756003)(5001770100001)(105606002)(83506001)(106466001)(2501003)(50986999)(54356999)(31696002)(31686004)(8676002)(230700001)(11100500001)(93886004)(81156014)(104016004)(7846002)(4326007)(8666005)(64126003)(81166006)(68736007)(65826007)(2906002)(65956001)(23746002)(65806001)(305945005)(586003)(92566002)(47776003)(356003)(50466002)(8936002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0301MB2001; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD010; 1:OgD51OjJ8mTNNVFGKBNjLSCMZxNp2W2kYrAL9l3ojXPskxzKrTAMfw5KizBaVESRgXlW1VL4gfjmomdSKzMjlRTi5cCL6Lam+dOgcQD8OY/ajor8lqVMVI31TztOq/Rr5Ch2aPNwPTDdyjq28S+/ggFDIXe4JO9xROdrLauUZQEjundRD9vkPjAQIb6dGc2/mtJTqwJ5kEVFxkdM0r5cARlYLn4Z4fgu0MF7anEMNnJfitc7wwVMcPMpOmFiKn0qbKHwqrE8L8z6svsqFo2za5Udl10bd4dr3X5ilK0ezhgzbZaFpZ5NbDJBO2VLrlx4a0SDXhafpSPh94CLtgoAOZ+Y7apscsrVrzvHHzDe6IBWna9yMUPe7e2uizw/YKit1vs5gU2yzYFOJuH65sAw3bjv+U0EggV5HD/pUSCkQQtx+AwfPjGH7yPyUXuKPo/8V8JCo2lAuIADvYq6Ql2kbL64dEbeFmAqaKJGLZFzPFyq60Nf0JGKEb3UMZhd0+yA9XOkKlhGM53k6LEGJlLYj3KNABNcB7445PqkYwTyt7xkoqZwfhO1/NAAS3eQo8qmYXF7zHXnYM5tS3M0zv15cGP4ZFnEA4xiFWM3vvqFFzXyJxskDnnJ5VfeEK478WLZXjUgjpm02lS3C8LQOvJSnA== X-MS-Office365-Filtering-Correlation-Id: c815b9b3-f766-4153-4bce-08d3d156bd56 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2001; 2:JkaezIe5PnubwMGO32QleDSt3GykmWYJJ4axGwzTkCeetRz6TQaA4zO+sxDvQTtaW88Mscc8aPHufj+qYlrC6YDL8H6hx/txBsiTkgrDppt9ECnvFIECMevbSUGmxx+UcczAIjseR2+pQKlrBoC4+Zzm1WUDg1Xf5tWWUwJWDOmbhQRAtw7AT7Vr9/heZ60h; 3:rpwKm86MqpehZRSps6bwOZsHxNmsvBJv7uuYvK0b8D1zw8XcF2afK6g7K5j3KUpuY6GfANRignhqkVdX9Q4oyqeFK4BCbRXdq020IOilAeI1eFxDjLeppdjTb47V3KCm7e1/U+TLL9DRqCabVDgyKP7WXLfJzMdD31TDoBgApyf4qpkXpz757u3W/J4ZQeUZHGi+/7G9/CHKrFJ4emjKm92BdhdEkbZDUaNrM6Ftd+U= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB2001; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2001; 25:NH48jra5ZCr1lf7jEbHLGBbYTCKutNogomIiV+HVzIh46lapXOcOFDfrMHHwhC3/a1LkSnNHUs4XcJClRsUo2+IowDITcrQlNwHuh2A7EBNnaAF5YBGaTVjmK7bVQE4AYDDO2/9qW04awWEWX+n4vfw8R883ujCiT4DuNX5EQH0WpES/7S7fIki7KbGPhEjUOgW4Jmay19JS2je6T3JwFXfZhoqT/K9SrMdJijXnuwrTf91dS/+4dWWeRjsoeZB+YK90eWC632amNnxqea5JzJiDQcD2HR0pvMaH1WeYdtwFOsCQ+Oby2RV8H7S6KquAEm943jkNZ6J2VAZwN6wryhy4Jv/UP0AINcg3YHzXaYMV7NHfLlw4M9Ib+0Ns4GSZyCfQlzSIg9J6+0baN1aN91qXdvEdoxlBLChaMVg271EbdD5gPHIlpEvpZZWaagskhtzpNUy5kB/xuCdR2+wI0Q7YfNjltzRIzYHia48KZt6p8MzfuAmCkTW3lcaclYSnIRiKboi3CmHi2pUgJoSXKApqRZycubVNxOiTlHFYshM2+T2SxonpN51ChwkOSwusc27uAnRpACQr6O7R8s3vE0JrLJM+UVF6KMa9VBexki1VLFnvY4DB/wrpLaclxuZNYLoMnmCB24JmXN473k0KHjPXak38+iAzsQqPXdPh6dYbqO5CXpmzdQfQPtS3l0/HPhcDCB7z9sHGcaA0bxZtpn0WeNfGKsqmx8RWsiTEH9FxWFE87GtmHdedkKajwDFT X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2001; 31:XELlJ9ciWrpc0HypLwmeSkohi2CSQj7jYUD3P8MbiOP4VEgu68YQaM6pmaEzXTcgUTK5682NNK3Wlx8jUU5532+yQiGBJxOXUdJKw8hELSA5/8TE1rsdfp6kOEOxeLdEhRrv6n+qjtlYu/UlMHA287NXbDY8KsycGdMPTrLeC5+UmCseOqaugflOQz1NTTgFPSO9qfuuH2iAv1EWKpZ7P/aT1ie0HpVEz6tByiO78gg=; 4:Z0tWQjQGphdLcxJ9q/AITwx47skdsPrPMsY6uGJecIJum2hZPGWhaxQcr0w3X16MjusJzk91jk3QRyFKeRmGVjOSZmW0bpUyfi64yPNDoPsqXUOwqkeCWMD9IYKznIztHvSF3/ZfLSquqGFPtmudx5RpHK9gBDDGl5RoP6RyoE9JFLunSWlsV6cYW1Fj2e9DX4MwBVajq7PwFfFT+TCemnOirXDBBPlc+Jg3+P/Vk81eWB3ycoyY7wOYhYZD2X5gWtFc+mEERI5rMohE4F30yC1AfX0VJyNaMc9qrb/aH5yuD2aTlnGsa72LpHP1dIJzchWqpPBezf670dsnUOakurQzGKoxb2DqurmvJHAs32ycjP76W9t7po6vA7JBdZ2EEjpKdjeQhtZh20DNYW1z1PC0MIoYHWUukOU/HNRKnaIL+T1qd6x+DFnpzwchnJqGu6BmMiui7tJPqwp88S/Nhk1inEOSha9EqjhfGQvkxFVmodNuhIDckw4pSTmkAYrU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:BLUPR0301MB2001; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR0301MB2001; X-Forefront-PRVS: 00514A2FE6 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR0301MB2001; 23:suz0BPH+lDAYzLcCu6GNGtmD+AEluB5Nw8M?= =?Windows-1252?Q?QNizHsipTu33We4w0v7XIVo1MCxOd1z6MnGL8WVeroEqtxukYJD5pbCa?= =?Windows-1252?Q?CHEBahi7IPAd933++xkJrsQrlz6inRe8WFSyTxxX5Zcs+gWzv+U87wzj?= =?Windows-1252?Q?avh7ONDvHhoZ0T8mZCsQGjvRJt5NgHixNKqaeidKh9OtetETzHuCUUYI?= =?Windows-1252?Q?vDYTOUXq7DKIIGrGjiH798s4yO+k6yve5V8xwz8rUVq3OP/Mf3mWniL/?= =?Windows-1252?Q?3pnWifbgGBNk143AGrfEmODYptk27t2x5rwtKrvWbhK9b30oCesXPMUW?= =?Windows-1252?Q?6cROGOrCly/eqOnk/fQ3jUL4K7ZLl10cdkZ+YstZ2cdYmKNHRspiFgvS?= =?Windows-1252?Q?DMJaa7C89uydMF/L3WRiP2OJGf6PgTr/dkgfJVIkliZ+627OCNnd4+cN?= =?Windows-1252?Q?ir/gl+6PyC28PEpVeLWlAhA+/hpWGJUw1Dv2WJlPqq/TIvxKIkYPrD4E?= =?Windows-1252?Q?UaDT5totwhjOPvf2T4z1ont7KJEjOLwHH6FQLK2ydsfmJQCyEAqsKKsv?= =?Windows-1252?Q?MrQ9TsD4N7C6hYnyCMKTNMdjDXVSj24NKv6zHUHA+hkeeXSoNAfC1rG1?= =?Windows-1252?Q?sKmtMWOX0kUOC2AtwHzPXmJVWexbQtSFrZl+INCl04XDwvdevSf4oFGs?= =?Windows-1252?Q?Xa7akWbUDOM4XoJCqR09orR9qYRcMRSeGxung+VtEynNmjhVTT1/Rm+M?= =?Windows-1252?Q?IrL8FtJXvbDZ/UA+WR+jLJEws88NxR8DZgNEU8wEqWX6HRWPYez8ZXJ8?= =?Windows-1252?Q?uaHzbXzk+enNmfe0lvTxOjSn1AluqYJ2U+8Qh12S2typ/Dpat4dmucGb?= =?Windows-1252?Q?KkCt1VXW6IgSGIjDKHxgOmAwlq5fGUlLY4qE4ZO5BVqOd17azfN+ckie?= =?Windows-1252?Q?u2IN08Is7GNo3ZX9P1XemjKHRMbhvyLFDZJ3JnDr/Rr+wVJxm8c0+MAQ?= =?Windows-1252?Q?JGaJDNLJOG2E4H768+1PLinQ7270KDuZQLzMAdEhRIJ+7M8KtlErcSK5?= =?Windows-1252?Q?llufZcuR21dG875F0JdH7n6ro/LOYna9jQYwxyNSf0HjN0QRRmeHGE8g?= =?Windows-1252?Q?kqQAGiyV6EhcJdTijBFvwGqwLt4KLkff67wiB/f3k2Iz/ZF3qN9Y2xN/?= =?Windows-1252?Q?Q28K1jRwdNVZvaZ6IisnNMajHCKITwhRyxWxVcI+vplIg3SdPAYbJ0a8?= =?Windows-1252?Q?WW6RcI/2jMCQldOzWVQ4CrbiPDtEDgrCAZTk1gZ205MNumyyvr1xPQp2?= =?Windows-1252?Q?2iTqyqzvvhtwkMunkvP3wOBsXPq3c9SD9xG0zsm7IrJ+CzrXrhDUtU1m?= =?Windows-1252?Q?8yQumpDvzlzC5s/4vqy8DaPyYx6UXiaAwaqSPcAmpl2nuEU5kJVfdnCE?= =?Windows-1252?Q?qTnKH8yRHAgiW4Z5kj5czFlAywMWS5pL/67F7C/fHS4Fc9+KxyTOh/OK?= =?Windows-1252?Q?3fSzyvus=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2001; 6:akeCa4sDXgHEyno4V1qTFgCm38/ZIQj6GnLYnrEN2MsAZwEWf9ON2f3CSshJq55K3uAiWKaEBMnnDU3qT2Vv6ZgrDD2p998Tm7XzorI8mj9VgFH9oJwNAbZU0CvwtfYOjFoJepgjY5Vo8d3tOiXwNxqej58mf8zBmqpeZ3io0wfiy3x7g7jfwITceG/IQ0sp5mvOa1Q/MjNkK5XCA3eTSc3TMWipD/ekKfDCLAf0pFNwB+Vpth1J+9P1nvA2IOeHrCXsk/VHyMEiibmiTk1g41tA3nvMke4yvGMDSNxZQLw=; 5:d0mj0qiJtr2vFbRB7bjUaRbVHPjFnDNIcsN4/3REj+XfqvY/7rRpe+rUK9YNB6ywsH/WBHpGhCmOA06bwSVsXYKl+eDleIvtk8+geTk7sz9c4jQ4RK7816X9Ad/Aebe7BV1hNGMlHwcrsn6P9RR/jg6gz2iJ+4JO7G5pUBpy8k0=; 24:17IfKCm6k7UgXMB0l3K4ooFG/koIHWfouuf59vsKeZguja5VPmp+ZvaQmtvfU4QWmgdHzl0xcpEAx5w1plEbnUNeKVfEANxQLkEEZ6MKb90=; 7:cJMM1CFKqF+R4n+hCkCb6jIc1wdT5UOfV5h7PUgT5W8Jo5DZAWcbsisdk4metMDH3QdBRXYN/Ourqlskyiz13wM/VTFAmJNkstVEnUUrRd8yZYwD2bwMj8e939XMPU4D1NUYIz0RX0wpKAWSqkKWHZlqd/ePsNQUdLIFehUzLx41kzXDszDU6mh44PSHNcy9/w9r8Gentuv08kxZrRpnD8LteWut+wZOEZGXX2pXmKJ5zcq5z10mhNd5RxF19aax SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2016 04:24:45.8945 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB2001 Subject: Re: [dpdk-dev] [PATCH v8 10/25] eal/pci: Helpers for device name parsing/update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2016 04:24:49 -0000 Hi, On Tuesday 30 August 2016 10:04 PM, Pattan, Reshma wrote: > Hi, > >> +/** >> + * Utility function to write a pci device name, this device name can >> +later be >> + * used to retrieve the corresponding rte_pci_addr using >> +eal_parse_pci_* >> + * BDF helpers. >> + * >> + * @param addr >> + * The PCI Bus-Device-Function address >> + * @param output >> + * The output buffer string >> + * @param size >> + * The output buffer size >> + * @return >> + * 0 on success, negative on error. >> + */ > > This function doesn't have any return value. Need to change the @return description. I will correct this in v9. Thanks for review. > >> +static inline void >> +rte_eal_pci_device_name(const struct rte_pci_addr *addr, >> + char *output, size_t size) >> +{ >> + RTE_VERIFY(size >= PCI_PRI_STR_SIZE); >> + RTE_VERIFY(snprintf(output, size, PCI_PRI_FMT, >> + addr->domain, addr->bus, >> + addr->devid, addr->function) >= 0); } >> + > > Thanks, > Reshma > - Shreyansh -- - Shreyansh