From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FB5D431EE; Tue, 24 Oct 2023 10:45:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4078340608; Tue, 24 Oct 2023 10:45:59 +0200 (CEST) Received: from forward501c.mail.yandex.net (forward501c.mail.yandex.net [178.154.239.209]) by mails.dpdk.org (Postfix) with ESMTP id 787B940262 for ; Tue, 24 Oct 2023 10:45:57 +0200 (CEST) Received: from mail-nwsmtp-smtp-production-main-57.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-57.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:112b:0:640:c113:0]) by forward501c.mail.yandex.net (Yandex) with ESMTP id E2A3B610B9; Tue, 24 Oct 2023 11:45:56 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-57.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id mjJJv81DeOs0-FqdEAvP5; Tue, 24 Oct 2023 11:45:55 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1698137155; bh=38wWR9okoiSvEx2/vvRQHRSt8txVAOCSyVD+4FHdtTU=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=U//Ik7786B1Pj0JwbllNSo4aOBNA8Rw2rRZIPW19cB/SiOWV+sQ6WExg3YK50+G9K YzuVVFXnCh7MbciQkEou/a2UVUed1SlILd1zTFYooG2i0cIMuPGddG20K6vKSpD29Q 8FemDCM9NqoNx2zCSjZKUh+qhNEancKpRDEvvQdI= Authentication-Results: mail-nwsmtp-smtp-production-main-57.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <47a2a476-57b4-4988-bb7e-9e027c67bee1@yandex.ru> Date: Tue, 24 Oct 2023 09:45:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/19] ipsec: use rte optional stdatomic API Content-Language: en-US, ru-RU To: Tyler Retzlaff , dev@dpdk.org Cc: Akhil Goyal , Anatoly Burakov , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Ciara Power , David Christensen , David Hunt , Dmitry Kozlyuk , Dmitry Malloy , Elena Agostini , Erik Gabriel Carrillo , Fan Zhang , Ferruh Yigit , Harman Kalra , Harry van Haaren , Honnappa Nagarahalli , Jerin Jacob , Matan Azrad , Maxime Coquelin , Narcisa Ana Maria Vasile , Nicolas Chautru , Olivier Matz , Ori Kam , Pallavi Kadam , Pavan Nikhilesh , Reshma Pattan , Sameh Gobriel , Shijith Thotton , Sivaprasad Tummala , Stephen Hemminger , Suanming Mou , Sunil Kumar Kori , Thomas Monjalon , Viacheslav Ovsiienko , Vladimir Medvedkin , Yipeng Wang References: <1697497745-20664-1-git-send-email-roretzla@linux.microsoft.com> <1697574677-16578-1-git-send-email-roretzla@linux.microsoft.com> <1697574677-16578-7-git-send-email-roretzla@linux.microsoft.com> From: Konstantin Ananyev In-Reply-To: <1697574677-16578-7-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17.10.2023 21:31, Tyler Retzlaff пишет: > Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional stdatomic API > > Signed-off-by: Tyler Retzlaff > --- > lib/ipsec/ipsec_sqn.h | 2 +- > lib/ipsec/sa.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/ipsec/ipsec_sqn.h b/lib/ipsec/ipsec_sqn.h > index 505950e..984a9dd 100644 > --- a/lib/ipsec/ipsec_sqn.h > +++ b/lib/ipsec/ipsec_sqn.h > @@ -128,7 +128,7 @@ > > n = *num; > if (SQN_ATOMIC(sa)) > - sqn = __atomic_fetch_add(&sa->sqn.outb, n, __ATOMIC_RELAXED) + n; > + sqn = rte_atomic_fetch_add_explicit(&sa->sqn.outb, n, rte_memory_order_relaxed) + n; > else { > sqn = sa->sqn.outb + n; > sa->sqn.outb = sqn; > diff --git a/lib/ipsec/sa.h b/lib/ipsec/sa.h > index ce4af8c..4b30bea 100644 > --- a/lib/ipsec/sa.h > +++ b/lib/ipsec/sa.h > @@ -124,7 +124,7 @@ struct rte_ipsec_sa { > * place from other frequently accessed data. > */ > union { > - uint64_t outb; > + RTE_ATOMIC(uint64_t) outb; > struct { > uint32_t rdidx; /* read index */ > uint32_t wridx; /* write index */ Acked-by: Konstantin Ananyev