From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id EDA81377E for ; Thu, 29 Jun 2017 14:55:30 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 29 Jun 2017 05:55:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,280,1496127600"; d="scan'208";a="102732561" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 29 Jun 2017 05:55:28 -0700 To: Rasesh Mody , dev@dpdk.org Cc: Dept-EngDPDKDev@cavium.com References: <1498729889-21524-1-git-send-email-rasesh.mody@cavium.com> <1498729889-21524-9-git-send-email-rasesh.mody@cavium.com> From: Ferruh Yigit Message-ID: <47bf845e-61a1-14c2-428b-5a42864355d4@intel.com> Date: Thu, 29 Jun 2017 13:55:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1498729889-21524-9-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 8/9] net/qede: use newer packet mbuf allocate API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 12:55:31 -0000 On 6/29/2017 10:51 AM, Rasesh Mody wrote: > Use rte_pktmbuf_alloc() API instead of rte_mbuf_raw_alloc(). > > Signed-off-by: Rasesh Mody > --- > drivers/net/qede/qede_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c > index 8063233..6b047a3 100644 > --- a/drivers/net/qede/qede_rxtx.c > +++ b/drivers/net/qede/qede_rxtx.c > @@ -16,7 +16,7 @@ static inline int qede_alloc_rx_buffer(struct qede_rx_queue *rxq) > dma_addr_t mapping; > uint16_t idx = rxq->sw_rx_prod & NUM_RX_BDS(rxq); > > - new_mb = rte_mbuf_raw_alloc(rxq->mb_pool); > + new_mb = rte_pktmbuf_alloc(rxq->mb_pool); rte_pktmbuf_alloc() is more expensive call, because of rte_pktmbuf_reset() it has. Are you sure you want to switch, what is the motivation? > if (unlikely(!new_mb)) { > PMD_RX_LOG(ERR, rxq, > "Failed to allocate rx buffer " >