* [dpdk-dev] [PATCH] net/netvsc: check return from kvargs_process
@ 2018-09-26 9:31 Stephen Hemminger
2018-10-01 14:56 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2018-09-26 9:31 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
Should check return value from processing latency value.
Coverity issue: 322104
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
Patch against dpdk-next-net
drivers/net/netvsc/hn_ethdev.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index b67cce1ba8f5..8845fc0e6176 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -167,6 +167,7 @@ static int hn_parse_args(const struct rte_eth_dev *dev)
NULL
};
struct rte_kvargs *kvlist;
+ int ret;
if (!devargs)
return 0;
@@ -180,9 +181,12 @@ static int hn_parse_args(const struct rte_eth_dev *dev)
return -EINVAL;
}
- rte_kvargs_process(kvlist, "latency", hn_set_latency, hv);
+ ret = rte_kvargs_process(kvlist, "latency", hn_set_latency, hv);
+ if (ret)
+ PMD_DRV_LOG(ERR, "Unable to process latency arg\n");
+
rte_kvargs_free(kvlist);
- return 0;
+ return ret;
}
/* Update link status.
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/netvsc: check return from kvargs_process
2018-09-26 9:31 [dpdk-dev] [PATCH] net/netvsc: check return from kvargs_process Stephen Hemminger
@ 2018-10-01 14:56 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-10-01 14:56 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: Stephen Hemminger
On 9/26/2018 10:31 AM, Stephen Hemminger wrote:
> Should check return value from processing latency value.
>
> Coverity issue: 322104
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Fixes: a25d39a3eb69 ("net/netvsc: allow tuning latency with devargs")
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-01 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 9:31 [dpdk-dev] [PATCH] net/netvsc: check return from kvargs_process Stephen Hemminger
2018-10-01 14:56 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).