Re: [dpdk-dev] [PATCH v10] net/iavf: support flex desc metadata extraction

["Guo, Jia" <jia.guo@intel.com>]

> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Tuesday, October 27, 2020 1:22 PM
> To: Guo, Jia <jia.guo@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: RE: [PATCH v10] net/iavf: support flex desc metadata extraction
> 
> > -----Original Message-----
> > From: Guo, Jia <jia.guo@intel.com>
> > Sent: Tuesday, October 27, 2020 13:05
> > To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Yigit,
> > Ferruh <ferruh.yigit@intel.com>
> > Cc: dev@dpdk.org; Wang, Haiyue <haiyue.wang@intel.com>; Richardson,
> > Bruce <bruce.richardson@intel.com>; Guo, Jia <jia.guo@intel.com>
> > Subject: [PATCH v10] net/iavf: support flex desc metadata extraction
> >
> > Enable metadata extraction for flexible descriptors in AVF, that would
> > allow network function directly get metadata without additional
> > parsing which would reduce the CPU cost for VFs. The enabling metadata
> > extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-
> FLOW/TCP/MPLS
> > flexible descriptors, and the VF could negotiate the capability of the
> > flexible descriptor with PF and correspondingly configure the specific
> > offload at receiving queues.
> >
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
> > ---
> > v10:
> > delete the makefile configure and rename the dynamic mbuf name
> >
> > v9:
> > change the undef config
> >
> > v8:
> > rebase patch for apply issue
> >
> > v7:
> > clean some useless and add doc
> >
> > v6:
> > rebase patch
> >
> > v5:
> > remove ovs configure since ovs is not protocol extraction
> >
> > v4:
> > add flex desc type in rx queue for handling vector path handle ovs
> > flex type
> >
> > v3:
> > export these global symbols into .map
> >
> > v2:
> > remove makefile change and modify the rxdid handling
> > ---
> >  doc/guides/rel_notes/release_20_11.rst  |   6 +
> >  drivers/net/iavf/iavf.h                 |  24 +-
> >  drivers/net/iavf/iavf_ethdev.c          | 394 ++++++++++++++++++++++++
> >  drivers/net/iavf/iavf_rxtx.c            | 252 +++++++++++++--
> >  drivers/net/iavf/iavf_rxtx.h            | 169 +++++-----
> >  drivers/net/iavf/iavf_rxtx_vec_common.h |   3 +
> >  drivers/net/iavf/iavf_vchnl.c           |  22 +-
> >  drivers/net/iavf/meson.build            |   2 +
> >  drivers/net/iavf/rte_pmd_iavf.h         | 250 +++++++++++++++
> >  9 files changed, 1008 insertions(+), 114 deletions(-)  create mode
> > 100644 drivers/net/iavf/rte_pmd_iavf.h
> 
> 
> > --- a/drivers/net/iavf/meson.build
> > +++ b/drivers/net/iavf/meson.build
> > @@ -35,3 +35,5 @@ if arch_subdir == 'x86'
> >  objs += iavf_avx2_lib.extract_objects('iavf_rxtx_vec_avx2.c')
> >  endif
> >  endif
> > +
> > +install_headers('rte_pmd_iavf.h')
> 
> One issue: headers = files('rte_pmd_iavf.h')
> 
> Please refer to:
> 
> commit 30105f664f8ebbecd878deff7f0733a3f92edd17
> Author: David Marchand <david.marchand@redhat.com>
> Date:   Thu Oct 22 09:55:45 2020 +0200
> 
>     drivers: add headers install helper
> 
>     A lot of drivers export headers, reproduce the same facility than for
>     libraries.
> 

Oh, thank for your notify, will update it later.

> 
> Others, LGTM.
> 
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> 
> > --
> > 2.20.1
>