From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id B3DC595EC for ; Tue, 14 Jun 2016 15:29:57 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id k204so123223805wmk.0 for ; Tue, 14 Jun 2016 06:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=11OacPytcNDeUwlRJRxMcVK8BJ1vXQ0vvRtlq3e0aGw=; b=ek41cscViTxAxOwkSsaceG44iZ4iyjIU7CQbLKeF3QDaWf+SNj+ivHmcgCOuf2U+nh slBYOHhk3shpccHblSULXJGVyCLkHJntGXWWbojnnl5i1SS5U/ENw7vFrd3eUBRXNMzs sAy3Roa4buKmrNWAnAtk/s55w14MGvnLgtIiBF3sRBZzhzNM6tfGQit9nO0KPEiivXGv EICUfLdi7fSdTqgu4j0t9foPXnVRfkXmsB8BsW8qY/UZQ7e8XX+1qcnHGbYe86jkEaBm y7U515EoR4kE0EDS+wwlXYnyG459pGW3v4UfGUmVrGqpt324TfpPnXq17I65L/ZbaqrX FfBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=11OacPytcNDeUwlRJRxMcVK8BJ1vXQ0vvRtlq3e0aGw=; b=BrU0ocvKHJNtGcXPpqyrIY2lGAw2rEpzAEtISVAuaJP8BI3z1f8GGUfgGgY3trDwdV ksmaqygEIlSCB+/IeYCn9lRDY1TQhC8oU5+cVXfswYMywWApFk6Q+ICLdl0psK7J4DkR s6OMUc1q8zDzP9QJFoDmHnuiNgxi/INZzBja5+Vu698vfYZrJcw6Q2awf12+GSWeBii2 6ii2Yl6SvgyRIRM1p9lL9FjAG5wzsKgl1chR6CryT4md/DDlJiZS0ITJNbLboFHCtSK5 cYKMsyheAIVDbqklUnf0+QYwq19NzUUGU50K3WsCDSNdvCfx2P1ToueXHzizL0o53sQy tDFg== X-Gm-Message-State: ALyK8tKlBk9U5K58rz2ZcHeYLo/qGbpGMkq+9YJ8/yvk7IuYp4+1GpskAa8LMp0SPUUn+GWR X-Received: by 10.28.22.77 with SMTP id 74mr6762418wmw.36.1465910997439; Tue, 14 Jun 2016 06:29:57 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id m87sm2772669wmi.22.2016.06.14.06.29.56 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 14 Jun 2016 06:29:56 -0700 (PDT) From: Thomas Monjalon To: "Hunt, David" Cc: dev@dpdk.org, olivier.matz@6wind.com, viktorin@rehivetech.com, jerin.jacob@caviumnetworks.com, shreyansh.jain@nxp.com, "Mcnamara, John" Date: Tue, 14 Jun 2016 15:29:54 +0200 Message-ID: <4802005.Wuc0l2sk9u@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <576004B4.7070708@intel.com> References: <1465571806-22008-1-git-send-email-david.hunt@intel.com> <1713942.6DB6T3RQsY@xps13> <576004B4.7070708@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 1/3] mempool: support external mempool operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 13:29:57 -0000 2016-06-14 14:20, Hunt, David: > > Hi Thomas, > > On 14/6/2016 1:55 PM, Thomas Monjalon wrote: > > Hi David, > > > > 2016-06-14 10:46, David Hunt: > >> Until now, the objects stored in a mempool were internally stored in a > >> ring. This patch introduces the possibility to register external handlers > >> replacing the ring. > >> > >> The default behavior remains unchanged, but calling the new function > >> rte_mempool_set_handler() right after rte_mempool_create_empty() allows > >> the user to change the handler that will be used when populating > >> the mempool. > >> > >> This patch also adds a set of default ops (function callbacks) based > >> on rte_ring. > >> > >> Signed-off-by: Olivier Matz > >> Signed-off-by: David Hunt > > Glad to see we are close to have this feature integrated. > > > > I've just looked into few details before pushing. > > One of them are the comments. In mempool they were all ended by a dot. > > Please check the new comments. > > Do you mean the rte_mempool struct definition, or all comments? Shall I > leave the > old comments the way they were before the change, or will I clean up? > If I clean up, I'd suggest I add a separate patch for that. Just check and clean the comments added in this patch. > > The doc/guides/rel_notes/deprecation.rst must be updated to remove > > the deprecation notice in this patch. > > Will do. As a separate patch in the set? In this patch. > > Isn't there some explanations to add in > > doc/guides/prog_guide/mempool_lib.rst? > > Yes, I'll adapt some of the cover letter, and add as a separate patch. It is OK (and better) to add it in this patch. Maybe you can request John's help for doc review. > > Isn't there a better name than "default" for the default implementation? > > I don't think the filename rte_mempool_default.c is meaningful. > > I could call it rte_mempool_ring.c? Since the default handler is ring based? It is an idea. Thanks