DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, "Anatoly Burakov" <anatoly.burakov@intel.com>,
	"David Hunt" <david.hunt@intel.com>,
	"Sivaprasad Tummala" <sivaprasad.tummala@amd.com>,
	"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH] power: don't disable all cast qualifier warnings
Date: Thu, 17 Oct 2024 19:50:26 +0200	[thread overview]
Message-ID: <48102059.XUcTiDjVJD@thomas> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F621@smartserver.smartshare.dk>

13/08/2024 08:11, Morten Brørup:
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > 
> > Only in one place does the power library need un-constify a pointer
> > and this can be done by casting to uintptr_t first. Better, to have
> > the warning enabled across the rest of the code.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> 
> Agree; disabling warnings should be avoided.
> 
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Applied, thanks



  reply	other threads:[~2024-10-17 17:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 21:56 Stephen Hemminger
2024-08-13  6:11 ` Morten Brørup
2024-10-17 17:50   ` Thomas Monjalon [this message]
2024-08-13  8:18 ` Bruce Richardson
2024-08-13  8:53 ` lihuisong (C)
2024-09-12  5:19 ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48102059.XUcTiDjVJD@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=sivaprasad.tummala@amd.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).