From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 9BA7C8E59 for ; Wed, 2 Dec 2015 11:10:17 +0100 (CET) Received: by wmww144 with SMTP id w144so207914324wmw.1 for ; Wed, 02 Dec 2015 02:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=KVmHtLk5zcw9hIb6fjg5v5+f4FZPnh/6R3KRIWN56+s=; b=mgLvFpkH/qR3uXnp+CarkcMATSGxONS5z1T+fgBwl2sXda/furzYcbdjQ3gEsU/df3 7MOLfhR4XWAKh5BW2ZvpPMx7BVFhvp+uLhaJPR1J+Q1RGdcLbL0KP/sl83KrRk2ZSzAx pQ4xaaB08Jh8duL2tGrYJ0FdQN2DJtywNcHr+aSEI2fwcOmNB3mUzzkQ4mjNTnKidC7c +VBWIA82DkO/cn/Ua8KScDJIOFwNc6iur4BStUWlNonVI+RfILswNxlspzw50dcSiF9f VX8dfYfABNhmTHigrtJbhFLakQvSgvzQna9iMGe0njIqv2z0XNQ7GCxLdZWvk8o9x6VS 0tHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=KVmHtLk5zcw9hIb6fjg5v5+f4FZPnh/6R3KRIWN56+s=; b=fMTTjgq7M7Frk4vgJ66+lJnwmh85cxGNyDAE9HNGVU1C0oYZcycrP1R/jhXSgA48wk 1l7VUNynFZ9vXHCp/WYnVyT4SBYiScEUaY8gJS7CK/3+3Ly4FG4LCXLDZDLwhsRHBNyS RMyHlHxWm0cK6+KoZhKiN7JogaW+KzfGEMaod3DE4RJXNctCfg/slVT5Q013DQsUqUVX XG59x9QItKtv7J5/lJkw+oquxN4ZXZuSAc94uNGH6jz7l7C/INmdU/K3RbUiQRpoUVhU PpWa2lhuOSUbOocqnXUWVp4JkLUesi3QgePYeUuiWaIu5B+M6h+JJZ0ewwLMSdDinuwC zdNQ== X-Gm-Message-State: ALoCoQm+qq2kRng3mO2ApYxTiQKLFRAGvgHeczPisHJ3NfVWbHoGuijYkwwo0QJVQvEcqq69Y6De X-Received: by 10.194.82.229 with SMTP id l5mr3825340wjy.140.1449051017494; Wed, 02 Dec 2015 02:10:17 -0800 (PST) Received: from xps13.localnet ([93.158.59.0]) by smtp.gmail.com with ESMTPSA id z17sm2081994wjq.1.2015.12.02.02.10.16 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Dec 2015 02:10:16 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Wed, 02 Dec 2015 11:09:08 +0100 Message-ID: <4814772.NpeSVJBR48@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <565EBFAD.80508@redhat.com> References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com> <1449028676-19232-7-git-send-email-thomas.monjalon@6wind.com> <565EBFAD.80508@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 06/10] mk: install kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 10:10:17 -0000 2015-12-02 11:53, Panu Matilainen: > On 12/02/2015 05:57 AM, Thomas Monjalon wrote: > > Add kernel modules to "make install". > > Nothing is done if there is no kernel module compiled. > > > > On native Linux, this path is suggested: > > kerneldir=/lib/modules/$(uname -r)/extra/dpdk [...] > > +kerneldir ?= $(exec_prefix)/kmod > > This by default installs the modules to /usr/local/kmod/ with no kernel > version etc. That's so broken that it'd be better not to install them at > all. > > So either get the kerneldir right (the correct path is known on Linux > and surely BSD too) or dont install them at all unless kerneldir is > manually specified. For Linux, it should default to > /lib/modules//extra/dpdk on Linux, where is the > version those modules were built against (which might or might not have > anything to do with uname -r output). Yes. That's what Mario did. I wanted to keep the same default as with the old T= command. But both are do-able by using "ifdef T".