From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78A8FA052E; Mon, 3 Feb 2020 13:45:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5037E1BFB6; Mon, 3 Feb 2020 13:45:23 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id F09411BF99 for ; Mon, 3 Feb 2020 13:45:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580733921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EKLZGjhNO1nBYHr/BAIVbb6GLrA+RcX8ZumoKbT1G2E=; b=D076cYdtJOYyn+gVaow+ozj7GR6rAUNirHPzzGsldp0japhSYHKnCc8h/RUxXVEhBbF/SD vb1kePX/sntGvqCUG95Ri+r53QQgafAaZ27CWoLH5KGZ3WShd5zsHM7xJ6dVAkVKXp6oXl aLD3FFTrDqE7M8WXfZV09fkZYXsA4wM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-218-kLdbjBxAOZSQTcxYtl5a7Q-1; Mon, 03 Feb 2020 07:45:17 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C8DC132277; Mon, 3 Feb 2020 12:45:16 +0000 (UTC) Received: from [10.36.112.51] (ovpn-112-51.ams2.redhat.com [10.36.112.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF6A05C883; Mon, 3 Feb 2020 12:45:14 +0000 (UTC) To: Matan Azrad , "dev@dpdk.org" , Slava Ovsiienko References: <1580292549-27439-1-git-send-email-matan@mellanox.com> <1580659433-25581-1-git-send-email-matan@mellanox.com> <1580659433-25581-14-git-send-email-matan@mellanox.com> <2843355f-407c-1c25-0342-1f26be6eb585@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <4814ba90-b104-6721-4e02-31a96d5b0588@redhat.com> Date: Mon, 3 Feb 2020 13:45:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: kLdbjBxAOZSQTcxYtl5a7Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 13/13] vdpa/mlx5: disable ROCE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/3/20 1:44 PM, Matan Azrad wrote: > > > From: Maxime Coquelin >> Sent: Monday, February 3, 2020 1:00 PM >> To: Matan Azrad ; dev@dpdk.org; Slava Ovsiienko >> >> Subject: Re: [PATCH v3 13/13] vdpa/mlx5: disable ROCE >> >> >> >> On 2/3/20 10:27 AM, Maxime Coquelin wrote: >>> Hi Matan, >>> >>> On 2/2/20 5:03 PM, Matan Azrad wrote: >>>> In order to support virtio queue creation by the FW, ROCE mode should >>>> be disabled in the device. >>>> >>>> Do it by netlink which is like the devlink tool commands: >>>> 1. devlink dev param set pci/[pci] name enable_roce value false >>>> cmode driverinit >>>> 2. devlink dev reload pci/[pci] >>>> Or by sysfs which is like: >>>> echo 0 > /sys/bus/pci/devices/[pci]/roce_enable >>>> >>>> The IB device is matched again after ROCE disabling. >>>> >>>> Signed-off-by: Matan Azrad >>>> Acked-by: Viacheslav Ovsiienko >>>> Acked-by: Maxime Coquelin >>>> --- >>>> drivers/vdpa/mlx5/Makefile | 2 +- >>>> drivers/vdpa/mlx5/meson.build | 2 +- >>>> drivers/vdpa/mlx5/mlx5_vdpa.c | 191 >>>> ++++++++++++++++++++++++++++++++++-------- >>>> 3 files changed, 160 insertions(+), 35 deletions(-) >>> ... >>>> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c >>>> b/drivers/vdpa/mlx5/mlx5_vdpa.c index 57619d2..710f305 100644 >>>> --- a/drivers/vdpa/mlx5/mlx5_vdpa.c >>>> +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c >>> >>> ... >>> >>>> @@ -246,8 +389,7 @@ >>>> mlx5_vdpa_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, >>>> struct rte_pci_device *pci_dev __rte_unused) { >>>> - struct ibv_device **ibv_list; >>>> - struct ibv_device *ibv_match = NULL; >>>> + struct ibv_device *ibv; >>>> struct mlx5_vdpa_priv *priv = NULL; >>>> struct ibv_context *ctx = NULL; >>>> struct mlx5_hca_attr attr; >>>> @@ -258,42 +400,25 @@ >>>> " driver."); >>>> return 1; >>>> } >>>> - errno = 0; >>>> - ibv_list = mlx5_glue->get_device_list(&ret); >>>> - if (!ibv_list) { >>>> - rte_errno = ENOSYS; >>>> - DRV_LOG(ERR, "Failed to get device list, is ib_uverbs >> loaded?"); >>>> + ibv = mlx5_vdpa_get_ib_device_match(&pci_dev->addr); >>>> + if (!ibv) { >>>> + DRV_LOG(ERR, "No matching IB device for PCI slot " >>>> + PCI_PRI_FMT ".", pci_dev->addr.domain, >>>> + pci_dev->addr.bus, pci_dev->addr.devid, >>>> + pci_dev->addr.function); >>>> return -rte_errno; >>>> - } >>>> - while (ret-- > 0) { >>>> - struct rte_pci_addr pci_addr; >>>> - >>>> - DRV_LOG(DEBUG, "Checking device \"%s\"..", ibv_list[ret]- >>> name); >>>> - if (mlx5_dev_to_pci_addr(ibv_list[ret]->ibdev_path, >> &pci_addr)) >>>> - continue; >>>> - if (pci_dev->addr.domain != pci_addr.domain || >>>> - pci_dev->addr.bus != pci_addr.bus || >>>> - pci_dev->addr.devid != pci_addr.devid || >>>> - pci_dev->addr.function != pci_addr.function) >>>> - continue; >>>> + } else { >>>> DRV_LOG(INFO, "PCI information matches for device >> \"%s\".", >>>> - ibv_list[ret]->name); >>>> - ibv_match = ibv_list[ret]; >>>> - break; >>>> + ibv->name); >>>> } >>>> - mlx5_glue->free_device_list(ibv_list); >>>> - if (!ibv_match) { >>>> - DRV_LOG(ERR, "No matching IB device for PCI slot " >>>> - "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 ".", >>>> - pci_dev->addr.domain, pci_dev->addr.bus, >>>> - pci_dev->addr.devid, pci_dev->addr.function); >>>> - rte_errno = ENOENT; >>>> - return -rte_errno; >>>> + if (mlx5_vdpa_roce_disable(&pci_dev->addr, &ibv) != 0) { >>>> + DRV_LOG(WARNING, "Failed to disable ROCE for \"%s\".", >>>> + ibv->name); >>>> + //return -rte_errno; >>>> } >>> >>> Is that commented return expected? >>> >> >> Please let me know if I should remove the comment, or remove the return. > > Sorry, forgot the comment , good catch! > It should not be comment just need to remove "//". Thanks Matan. > Can you do it in integration? Sure, will do now. Maxime >> >> Thanks, >> Maxime >