From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAB1045DEB; Sun, 1 Dec 2024 08:26:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9688240296; Sun, 1 Dec 2024 08:26:55 +0100 (CET) Received: from fout-b2-smtp.messagingengine.com (fout-b2-smtp.messagingengine.com [202.12.124.145]) by mails.dpdk.org (Postfix) with ESMTP id 80AF640289 for ; Sun, 1 Dec 2024 08:26:53 +0100 (CET) Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id 95A6B1140169; Sun, 1 Dec 2024 02:26:52 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Sun, 01 Dec 2024 02:26:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1733038012; x=1733124412; bh=+3hGz2Ufg7Zzy1e2zNzEZHPcNSyqk6U0r/67AJQEjHs=; b= OICHy79NzfRf3ldF7DMi24WJVo1cWm12joPSpu4juTauQVeN9DdVY96kXnaozmJI L1vvogEZQtjmnwWi/0LDJue/xnHV0o1BnBhxuAi06ePRXIveNpl3PPPiooWWm7/e 3tiZSS9ZEwzvRr7wJacDe6poMA3kc5W/QnPzkR9s/6lZOCDwopjdq3c6h90vr7yb FMN55jA7a28Bf4bDYbFF6c8Fxd4SNI+sv8+ujXfG0QAEaQPAZojUYQpuASUmDjmA 60THgJFAx/b9qyCzCNej23BDu5eZ2dUmHo8xr8069ijyZfUil83KYY7fiIoyLnss ZizrtHXBWGUuAkSQZhWvCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733038012; x= 1733124412; bh=+3hGz2Ufg7Zzy1e2zNzEZHPcNSyqk6U0r/67AJQEjHs=; b=i sErMNkLZI7qkj+m/apXu4VEHRdXhPlXJf8Mw2nvIZIGW7CJwQ/mjq/CtWtV17uS+ Aj7pNRSJr3Zm1TXQx2Y6u4ElBEumu7rU0jaCeKX116wEKrkm7NMMrHjmPNl5YJpH bZlZ4zGG3uHMVJBFAjAfkYtC4aDEbpuKP7g//KpUlcpNv22nFAHmkozNzrDzwE4s PM2gMV7sgs3I7vwqKMJD5LM7Udx4c1EN7wCqpFKHNjkt0yyalJduBkZ9o42y3WAK ZjYtRnlESfkWItf0V6pOf/wyO7R0nCgXkzl0+MEWynMDTJgqkNx7jfeRFIHLQnKM hXcik7y3FXBOgsyFEc0Og== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrheeigddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeetieejvdegvdfhkeegjeevgffgleej leevvdduffelvdfgvdeugfefheejjeeikeenucffohhmrghinhepghhithhhuhgsrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtohepuddtpdhmohguvg epshhmthhpohhuthdprhgtphhtthhopehfvghrrhhuhhdrhihighhithesrghmugdrtgho mhdprhgtphhtthhopehsihhvrghprhgrshgrugdrthhumhhmrghlrgesrghmugdrtghomh dprhgtphhtthhopegurghvihgurdhhuhhnthesihhnthgvlhdrtghomhdprhgtphhtthho pegrnhgrthholhihrdgsuhhrrghkohhvsehinhhtvghlrdgtohhmpdhrtghpthhtohepjh gvrhhinhhjsehmrghrvhgvlhhlrdgtohhmpdhrtghpthhtoheprhgrughurdhnihgtohhl rghusehinhhtvghlrdgtohhmpdhrtghpthhtohepghgrkhhhihhlsehmrghrvhgvlhhlrd gtohhmpdhrtghpthhtoheptghrihhsthhirghnrdguuhhmihhtrhgvshgtuhesihhnthgv lhdrtghomhdprhgtphhtthhopehkohhnshhtrghnthhinhdrrghnrghnhigvvheshhhurg ifvghirdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Dec 2024 02:26:49 -0500 (EST) From: Thomas Monjalon To: "Yigit, Ferruh" , "Tummala, Sivaprasad" Cc: "david.hunt@intel.com" , "anatoly.burakov@intel.com" , "jerinj@marvell.com" , "radu.nicolau@intel.com" , "gakhil@marvell.com" , "cristian.dumitrescu@intel.com" , "konstantin.ananyev@huawei.com" , "dev@dpdk.org" Subject: Re: [PATCH] power/amd_uncore: add e-smi installation instructions Date: Sun, 01 Dec 2024 08:26:47 +0100 Message-ID: <4818008.rnE6jSC6OK@thomas> In-Reply-To: References: <20231219032826.4814-1-sivaprasad.tummala@amd.com> <8457069.T7Z3S40VBb@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/12/2024 05:55, Tummala, Sivaprasad: > [AMD Official Use Only - AMD Internal Distribution Only] Please remove this. > Hi Thomas, >=20 > From: Thomas Monjalon > > 29/11/2024 05:32, Sivaprasad Tummala: > > > Added section for installing and building the E-SMI library for AMD > > > EPYC Uncore support and version requirements. > > > > > > Signed-off-by: Sivaprasad Tummala > > > --- > > > doc/guides/prog_guide/power_man.rst | 32 > > > +++++++++++++++++++++++++++++ > > > 1 file changed, 32 insertions(+) > > > > > > diff --git a/doc/guides/prog_guide/power_man.rst > > > b/doc/guides/prog_guide/power_man.rst > > > index 74039e5786..d367a81596 100644 > > > --- a/doc/guides/prog_guide/power_man.rst > > > +++ b/doc/guides/prog_guide/power_man.rst > > > @@ -249,6 +249,38 @@ Additionally, the EPYC System Management > > > Interface In-band Library for Linux offers essential API, enabling > > > user-space software to effectively manage system functions. > > > > > > +E-SMI Installation > > > +------------------ > > > + > > > +To build DPDK with AMD EPYC Uncore the user is required to download > > > +the e-smi library from `here > > > +`_ > > > +and compile it on their user system before building DPDK. > > > + > > > +.. code-block:: console > > > + > > > + cd esmi_ib_library > > > + cmake . > > > + sudo make install > > > + cp /opt/e-sms/e_smi/lib/* /usr/local/lib/* > > > + cp /opt/e-sms/e_smi/include/* /usr/local/include/* > > > > Why copying the files? > > You can specify the directories in an environment variable. > > There is no pkg-config file? > Currently, there isn't a pkg-config file available. > However, we are actively working on adding support for it in an upcoming = release. > > > > > + > > > +Library file, header and tool are installed at /opt/e-sms. > > > + > > > +Note: Library is dependent on amd_hsmp.h header and without this, co= mpilation > > will break. > > > > Yes, it does not compile on my machine (with Linux 6.12): > > > > e_smi.c:566:27: error: =E2=80=98HSMP_GET_RAPL_UNITS=E2=80=99 undeclared > > > > What should I do? > It appears there is a compatibility issue with the current version of the= amd_hsmp.h header file. https://github.com/amd/amd_hsmp/blob/master/amd_hs= mp.h > To resolve this, could you please try replacing the existing version with= an older amd_hsmp.h header file? > This should allow the build process to work with the older kernels. No I will wait for the library to be fixed. It doesn't look mature enough, this support should not have been merged.