From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8E4282BA1 for ; Thu, 8 Jun 2017 22:48:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3A8CC20A9C; Thu, 8 Jun 2017 16:48:43 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 08 Jun 2017 16:48:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=bcowhV2E46PMxxd jmZJBZiwWB37vmM9Z0OFQXiJLXzE=; b=sGangpbOpzDdpMBK5I2XwJx1iB0e9sg ltOU3d4Mcd5jNnINRcO341oCNzoR2zPti1vwIA+12spK17PzwU5WYwKjA4ET70sh 2loyXdeolJp2wlT7sdASt4wub2PvpgKapzesVXflS3J62LABHjbBJAcPM5O36ZIz 3ZrWrmEjK8QI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=bcowhV2E46PMxxdjmZJBZiwWB37vmM9Z0OFQXiJLXzE=; b=lQfZYLzU /yvgd6YLA3MCghPmbRn6cGlySvyr07XR3Q/d69d1mnTsrkeHYY1UXOVqLRTRN7+T EsaaVD7cbVQy8IR7nQoEn859bTE9qj8wLCxH9DmzOe7ppZUYusfEgiSgibwSRB50 YBCxxqN462AbJpfY+E31KhiR25ERgHNZcoYnjjmSsOJoSOEHsoWNqZdOJhPd0Att P11NbhtJc5cj6nAL6e8POqZ87ftrjJo/dFSsZW3Ep44oZdnAqsytv8nzFXX9oay+ qdSd8v39guQoy60w185aWxRm6p6VCP97P1q1e/9qNI1Bd2kd11kq9T3mjek2Sji/ HOO1p9VVSPMyHg== X-ME-Sender: X-Sasl-enc: ga8O9/5yztFSSsk3N6XB0shnnlGN38u3h87mu039hBd+ 1496954922 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E9F53248E2; Thu, 8 Jun 2017 16:48:42 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Tom Barbette Date: Thu, 08 Jun 2017 22:48:42 +0200 Message-ID: <4818076.qqcqROevOE@xps> In-Reply-To: <20170511082800.17608-1-tom.barbette@ulg.ac.be> References: <20170511082800.17608-1-tom.barbette@ulg.ac.be> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethernet api: Document rte_eth_vmdq_rx_conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 20:48:43 -0000 11/05/2017 10:28, Tom Barbette: > From documentation it is very unclear how VMDq configuration can be > tweaked, and online search offer very poor results. > > This patch will ultimately spawn an online documentation page > for the rte_eth_vmdq_rx_conf struct which will eventually add a bit of > documentation about the rx_mode tag and how to allow e.g. VMDq pools > to receive packets without VLAN tags. > --- I'm not an expert of VMDq. Please help reviewing this doc addition. [..] > +/** > + * A structure used to configure the VMDQ feature of an Ethernet port when > + * not combined with the DCB feature. > + * > + * Using this feature, packets are routed to a pool of queues. By default, the > + * pool selection is based on the MAC address, the vlan id in the vlan tag as > + * specified in the pool_map array. > + * Passing the ETH_VMDQ_ACCEPT_UNTAGGED in the rx_mode field allows pool > + * selection using only the MAC address. MAC address to pool mapping is done > + * using the rte_eth_dev_mac_addr_add function, with the pool parameter > + * corresponding to the pool id. > + * > + * Queue selection within the selected pool will be done using RSS when > + * it is enabled or revert to the first queue of the pool if not. > + * > + * A default pool may be used, if desired, to route all traffic which > + * does not match the vlan filter rules or any pool MAC address. > + */ > struct rte_eth_vmdq_rx_conf {