From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E773242FA5; Mon, 31 Jul 2023 14:31:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F63E40A89; Mon, 31 Jul 2023 14:31:35 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 8D6F54067B for ; Mon, 31 Jul 2023 14:31:33 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id C662C3200302; Mon, 31 Jul 2023 08:31:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 31 Jul 2023 08:31:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1690806691; x=1690893091; bh=zh6iQSTkIl3KYXg/0apRPQ//jo0XYGKQIq/ LaDATw+g=; b=xW6uDKA0gdS0/ceRvK/KTm6YV/xOrZht/5GiBEAJJRYOK/S4BA/ 4zEwEHBcqcgE/0Wy3nueFF6xB06I3JSUmXfHX8i9Iqake65oSLn19uRCEiGcBZjU syo2SvuK9o+79FQZcJ6+VxMNQdVZSA2UIjHdKSJlOD4lKYQPl3/2ECWEQwAHqvyn OHY459h6tzZLpDSsAwRQNPDW+we/gfyKFIG688H9M95vhlRVnu9Csu9UgfkVqSCw FYis6Sc5MwJZgSCRZczIBY2p1coLcDXwpO/rNXebluflZeTurryOnzQucujbDIGD IAvFAX20rDjOi/VvQFknkcRfO+qzr7jGfxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690806691; x=1690893091; bh=zh6iQSTkIl3KYXg/0apRPQ//jo0XYGKQIq/ LaDATw+g=; b=BPxFDJyrRaN8yefAh5btgpQxPMHEAhw/E32hPNl8VUoRawsFVES oofBYGKm//1RcD3lglI5SoYnA+hyOuMCbDI16HlECt6D6gae9aE18NKqonD4mCk0 ZEGCZg779FVBssEsnURRCamnuRxa67pth6GmebJH0M+fCVwAM72UpDMEJqEZ6FAf zPvLGbsuqnDebQ71XmP2cn1lJoKvzMMYKpkH3SnP+Mp/PkPJMpFt+0i8glWpb0xi SH8eK0aWoK3Dvzny3J7CbyRLcjzE8CqpuIjF/yoCI0n9D1zWIK3KwkVU+cbsZsIb 9DgtV4OQaYIokeSVhvYVPxYabSnAKadvAxA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeeggddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 31 Jul 2023 08:31:29 -0400 (EDT) From: Thomas Monjalon To: Wathsala Vithanage Cc: honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru, ruifeng.wang@arm.com, dev@dpdk.org, nd@arm.com, stephen@networkplumber.org, jerinj@marvell.com, Morten =?ISO-8859-1?Q?Br=F8rup?= , Tyler Retzlaff Subject: Re: [RFC] ring: further performance improvements with C11 Date: Mon, 31 Jul 2023 14:31:28 +0200 Message-ID: <48310366.MN2xkq1pzW@thomas> In-Reply-To: <20230615201335.919563-2-wathsala.vithanage@arm.com> References: <20230615201335.919563-1-wathsala.vithanage@arm.com> <20230615201335.919563-2-wathsala.vithanage@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/06/2023 22:13, Wathsala Vithanage: > For improved performance over the current C11 based ring implementation > following changes were made. > (1) Replace tail store with RELEASE semantics in __rte_ring_update_tail > with a RELEASE fence. Replace load of the tail with ACQUIRE semantics > in __rte_ring_move_prod_head and __rte_ring_move_cons_head with ACQUIRE > fences. > (2) Remove ACQUIRE fences between load of the old_head and load of the > cons_tail in __rte_ring_move_prod_head and __rte_ring_move_cons_head. > These two fences are not required for the safety of the ring library. > > Signed-off-by: Wathsala Vithanage > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang Are we waiting for more reviews?