DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Tomasz Duszynski <tduszynski@marvell.com>, <dev@dpdk.org>
Cc: <jerinj@marvell.com>, <hkalra@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	"Sunil Kumar Kori" <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	"Jakub Palider" <jpalider@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry
Date: Mon, 1 Nov 2021 14:38:13 +0000	[thread overview]
Message-ID: <4832f0a8-67a4-ec48-30b6-01aa7d80ab1a@intel.com> (raw)
In-Reply-To: <20211022115625.1956708-1-tduszynski@marvell.com>

On 10/22/2021 12:56 PM, Tomasz Duszynski wrote:
> Add initial support for baseband telemetry.
> 
> Signed-off-by: Tomasz Duszynski<tduszynski@marvell.com>
> ---
> v2:
> - make bphy telemetry available only on platforms supporting baseband
> - use platform types where possible
> - remove unused header
> 
>   drivers/common/cnxk/cnxk_telemetry_bphy.c | 52 +++++++++++++++++++++++

Since the telemetry support is for 'raw/cnxk_bphy', why it is implemented
in common code, instead of driver?

>   drivers/common/cnxk/meson.build           |  3 +-
>   drivers/common/cnxk/roc_model.h           |  5 +++
>   drivers/raw/cnxk_bphy/cnxk_bphy.c         | 11 +++++
>   drivers/raw/cnxk_bphy/cnxk_bphy_irq.h     |  1 +
>   5 files changed, 71 insertions(+), 1 deletion(-)
>   create mode 100644 drivers/common/cnxk/cnxk_telemetry_bphy.c


  parent reply	other threads:[~2021-11-01 15:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  7:46 [dpdk-dev] [PATCH] " Tomasz Duszynski
2021-10-19 12:30 ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-22 11:56 ` [dpdk-dev] [PATCH v2] " Tomasz Duszynski
2021-10-29 16:03   ` Jerin Jacob
2021-11-01 14:38   ` Ferruh Yigit [this message]
2021-11-02  4:32     ` Jerin Jacob
2021-11-02 10:28       ` Ferruh Yigit
2021-11-02 11:11         ` Jerin Jacob
2021-11-02 11:21           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4832f0a8-67a4-ec48-30b6-01aa7d80ab1a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=jpalider@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=tduszynski@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).