[dpdk-dev] [PATCH] support jumbo frames for pcap vdev

[dpdk-dev] [PATCH] support jumbo frames for pcap vdev

[Maxim Uvarov]

PCAP PMD vdev is used mostly for testing. Increase snapshot len
parameter provided to pcap_open_live() to accept packet more
then 4096 (support jumbo frames for pcap pmd).

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
---
 lib/librte_pmd_pcap/rte_eth_pcap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_pcap.c
index eebe768..978c137 100644
--- a/lib/librte_pmd_pcap/rte_eth_pcap.c
+++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
@@ -47,7 +47,6 @@
 #include <pcap.h>
 
 #define RTE_ETH_PCAP_SNAPSHOT_LEN 65535
-#define RTE_ETH_PCAP_SNAPLEN 4096
 #define RTE_ETH_PCAP_PROMISC 1
 #define RTE_ETH_PCAP_TIMEOUT -1
 #define ETH_PCAP_RX_PCAP_ARG  "rx_pcap"
@@ -468,7 +467,7 @@ open_tx_pcap(const char *key __rte_unused, const char *value, void *extra_args)
  */
 static inline int
 open_iface_live(const char *iface, pcap_t **pcap) {
-	*pcap = pcap_open_live(iface, RTE_ETH_PCAP_SNAPLEN,
+	*pcap = pcap_open_live(iface, RTE_ETH_PCAP_SNAPSHOT_LEN,
 			RTE_ETH_PCAP_PROMISC, RTE_ETH_PCAP_TIMEOUT, errbuf);
 
 	if (*pcap == NULL) {
-- 
1.9.1

Re: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxim Uvarov
> Sent: Tuesday, June 9, 2015 11:15 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev
> 
> PCAP PMD vdev is used mostly for testing. Increase snapshot len parameter
> provided to pcap_open_live() to accept packet more then 4096 (support
> jumbo frames for pcap pmd).

Hi,

Thanks for the submission.

There is already an existing patch for jumbo frame support in the PCAP pmd.

    http://dpdk.org/dev/patchwork/patch/3792/

Could you review/try that and see if it is suitable for your purposes.

Regards,

John.
-- 








> 
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
>  lib/librte_pmd_pcap/rte_eth_pcap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c
> b/lib/librte_pmd_pcap/rte_eth_pcap.c
> index eebe768..978c137 100644
> --- a/lib/librte_pmd_pcap/rte_eth_pcap.c
> +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
> @@ -47,7 +47,6 @@
>  #include <pcap.h>
> 
>  #define RTE_ETH_PCAP_SNAPSHOT_LEN 65535 -#define RTE_ETH_PCAP_SNAPLEN
> 4096  #define RTE_ETH_PCAP_PROMISC 1  #define RTE_ETH_PCAP_TIMEOUT -1
> #define ETH_PCAP_RX_PCAP_ARG  "rx_pcap"
> @@ -468,7 +467,7 @@ open_tx_pcap(const char *key __rte_unused, const char
> *value, void *extra_args)
>   */
>  static inline int
>  open_iface_live(const char *iface, pcap_t **pcap) {
> -	*pcap = pcap_open_live(iface, RTE_ETH_PCAP_SNAPLEN,
> +	*pcap = pcap_open_live(iface, RTE_ETH_PCAP_SNAPSHOT_LEN,
>  			RTE_ETH_PCAP_PROMISC, RTE_ETH_PCAP_TIMEOUT, errbuf);
> 
>  	if (*pcap == NULL) {
> --
> 1.9.1

Re: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev

[Maxim Uvarov]

On 06/09/15 15:15, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxim Uvarov
>> Sent: Tuesday, June 9, 2015 11:15 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev
>>
>> PCAP PMD vdev is used mostly for testing. Increase snapshot len parameter
>> provided to pcap_open_live() to accept packet more then 4096 (support
>> jumbo frames for pcap pmd).
> Hi,
>
> Thanks for the submission.
>
> There is already an existing patch for jumbo frame support in the PCAP pmd.
>
>      http://dpdk.org/dev/patchwork/patch/3792/
>
> Could you review/try that and see if it is suitable for your purposes.
>
> Regards,
>
> John.
Thanks, I did not see that patch. I see that your patch supports 
segmentation also. Will do test in my environment.

Maxim.

Re: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev

[Thomas Monjalon]

2015-06-09 15:50, Maxim Uvarov:
> On 06/09/15 15:15, Mcnamara, John wrote:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxim Uvarov
> >> PCAP PMD vdev is used mostly for testing. Increase snapshot len parameter
> >> provided to pcap_open_live() to accept packet more then 4096 (support
> >> jumbo frames for pcap pmd).
> >
> > There is already an existing patch for jumbo frame support in the PCAP pmd.
> >
> >      http://dpdk.org/dev/patchwork/patch/3792/
> >
> > Could you review/try that and see if it is suitable for your purposes.
> 
> Thanks, I did not see that patch. I see that your patch supports 
> segmentation also. Will do test in my environment.

Any update?

Re: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev

[Mcnamara, John]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, June 26, 2015 3:04 PM
> To: Maxim Uvarov; Mcnamara, John; tero.aho@coriant.com
> Cc: dev@dpdk.org; Bill Fischofer
> Subject: Re: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev
> 
> 2015-06-09 15:50, Maxim Uvarov:
> > On 06/09/15 15:15, Mcnamara, John wrote:
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxim Uvarov
> > >> PCAP PMD vdev is used mostly for testing. Increase snapshot len
> > >> parameter provided to pcap_open_live() to accept packet more then
> > >> 4096 (support jumbo frames for pcap pmd).
> > >
> > > There is already an existing patch for jumbo frame support in the PCAP
> pmd.
> > >
> > >      http://dpdk.org/dev/patchwork/patch/3792/
> > >
> > > Could you review/try that and see if it is suitable for your purposes.
> >
> > Thanks, I did not see that patch. I see that your patch supports
> > segmentation also. Will do test in my environment.
> 
> Any update?

Hi Thomas,

I hope to rework and resubmit it early next week.

John.
--