From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3779B201 for ; Tue, 13 Nov 2018 10:25:26 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BD64F23191; Tue, 13 Nov 2018 04:25:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 13 Nov 2018 04:25:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=b1dnA1FBE8G+2vJlZw/cE6Kco0gX0DXnYfPSezg4P7s=; b=RUfCCmmmWUgt Zxh/WooP8iqMGJq80Uy38yBRb1KkgY06WSQxVfgyy6oppib+5ZPez5p5nP+RcbxU gPCLi6PEmCEesfD85p0UmWDgfWRRtFD393/i3h0+sP7ytfbmXJhJbAkWyobqLhWV gmWOGf1q8M7nH8d7b3fk5JbmozLWquQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=b1dnA1FBE8G+2vJlZw/cE6Kco0gX0DXnYfPSezg4P 7s=; b=fRa6Xt0tyorYxmsU9t53yaaD6wRz5rNlX8vN0ZS8PVhiVYxzhkKYXmDdX DBu8p61Ym428aZfJyGM5gnVf53hvAuN+7zNi6OdtRczJJG7SlgyLBrL95H6Go/d6 G4Dhm5u+ebe/jFR9HN3vIBpD0QSDn2feuc8lTGG91LVc8dn4ShkI5DORN3gmxgCa JeK9YrUZqRplJYrIQSGX9Ab+4/TIz59d34rbm0dvBZmleI2uZ+8phjOp9f4E2JLK 7UGOigyIlCfNZiNOU15YHnOIeX5fwHTPWdccR1iEvkGTuz3A9fLdPJE0q/gI0Maf njYnZqHQy6pN3Na2suMi/FfBpwcfw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 94B8C102F8; Tue, 13 Nov 2018 04:25:24 -0500 (EST) From: Thomas Monjalon To: Herakliusz Lipiec Cc: dev@dpdk.org, konstantin.ananyev@intel.com Date: Tue, 13 Nov 2018 10:25:23 +0100 Message-ID: <4835654.xzScbSBJzk@xps> In-Reply-To: <20181112204650.7175-1-herakliusz.lipiec@intel.com> References: <20181112204650.7175-1-herakliusz.lipiec@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 09:25:26 -0000 Hi, 12/11/2018 21:46, Herakliusz Lipiec: > This example was dropping packets when using clone (ip 224.0.0.103). What is this IP? What is clone? > The problem was that mbufs were not freed. This was caused by coping > ol_flags from cloned mbuf to header mbufs. Mbuf is not freed because of ol_flags? I feel this description should be improved. > Signed-off-by: Herakliusz Lipiec [...] > --- a/examples/ipv4_multicast/main.c > +++ b/examples/ipv4_multicast/main.c > @@ -266,8 +266,6 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone) > hdr->tx_offload = pkt->tx_offload; > hdr->hash = pkt->hash; > > - hdr->ol_flags = pkt->ol_flags; > - > __rte_mbuf_sanity_check(hdr, 1); > return hdr; > }