From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <piotrx.t.azarewicz@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 732B0593A
 for <dev@dpdk.org>; Fri,  3 Jun 2016 09:19:13 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga103.fm.intel.com with ESMTP; 03 Jun 2016 00:19:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,411,1459839600"; d="scan'208";a="115340368"
Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99])
 by fmsmga004.fm.intel.com with ESMTP; 03 Jun 2016 00:19:11 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.10]) by
 IRSMSX107.ger.corp.intel.com ([169.254.10.96]) with mapi id 14.03.0248.002;
 Fri, 3 Jun 2016 08:19:10 +0100
From: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
To: "Tao, Zhe" <zhe.tao@intel.com>
CC: "Tao, Zhe" <zhe.tao@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v1] i40e: fix olflags for vector RX
Thread-Index: AQHRtbutjKxOC3fVtEqebxv/EO8S2J/XYBQg
Date: Fri, 3 Jun 2016 07:19:09 +0000
Message-ID: <4837007523CC9A4B9414D20C13DE6E64136D1EAA@IRSMSX102.ger.corp.intel.com>
References: <1464094543-32623-1-git-send-email-zhe.tao@intel.com>
In-Reply-To: <1464094543-32623-1-git-send-email-zhe.tao@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v1] i40e: fix olflags for vector RX
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jun 2016 07:19:14 -0000

Hi,

> --- a/drivers/net/i40e/i40e_rxtx_vec.c
> +++ b/drivers/net/i40e/i40e_rxtx_vec.c
> @@ -149,7 +149,7 @@ desc_to_olflags_v(__m128i descs[4], struct rte_mbuf
> **rx_pkts)
>
>	/* mask everything except rss and vlan flags
>	*bit2 is for vlan tag, bits 13:12 for rss
>  	*/

Please, update or remove the comment above.
Thanks, Piotr

>  	const __m128i rss_vlan_msk =3D _mm_set_epi16(
>  			0x0000, 0x0000, 0x0000, 0x0000,
> -			0x3004, 0x3004, 0x3004, 0x3004);
> +			0x3804, 0x3804, 0x3804, 0x3804);
>=20