From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <piotrx.t.azarewicz@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id ADD302C31
 for <dev@dpdk.org>; Thu, 29 Dec 2016 14:17:58 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 29 Dec 2016 05:17:44 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,427,1477983600"; d="scan'208";a="1105627093"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by fmsmga002.fm.intel.com with ESMTP; 29 Dec 2016 05:17:44 -0800
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.230]) by
 IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002;
 Thu, 29 Dec 2016 13:17:43 +0000
From: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
CC: "Trahe, Fiona" <fiona.trahe@intel.com>, "De Lara Guarch, Pablo"
 <pablo.de.lara.guarch@intel.com>, "Griffin, John" <john.griffin@intel.com>,
 "Jain, Deepak K" <deepak.k.jain@intel.com>, "Doherty, Declan"
 <declan.doherty@intel.com>, "Kusztal, ArkadiuszX"
 <arkadiuszx.kusztal@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 2/3] crypto/aesni_gcm: fix iv size in PMD
 capabilities
Thread-Index: AQHSXPYqzKetW4LmTkyTjRtWPCi7AqEe79wQ
Date: Thu, 29 Dec 2016 13:17:43 +0000
Message-ID: <4837007523CC9A4B9414D20C13DE6E6413757B3D@IRSMSX102.ger.corp.intel.com>
References: <1482481493-4369-1-git-send-email-arkadiuszx.kusztal@intel.com>
 <1482481493-4369-3-git-send-email-arkadiuszx.kusztal@intel.com>
In-Reply-To: <1482481493-4369-3-git-send-email-arkadiuszx.kusztal@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/3] crypto/aesni_gcm: fix iv size in
	PMD	capabilities
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Dec 2016 13:17:59 -0000

> Subject: [dpdk-dev] [PATCH v2 2/3] crypto/aesni_gcm: fix iv size in PMD
> capabilities
>=20
> This patch sets iv size in aesni gcm PMD to 12 bytes to be conformant wit=
h
> nist SP800-38D.
>=20
> Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto
> operations")
>=20
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
> b/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
> index e824d4b..c51f82a 100644
> --- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
> +++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
> @@ -77,8 +77,8 @@ static const struct rte_cryptodev_capabilities
> aesni_gcm_pmd_capabilities[] =3D {
>  					.increment =3D 0
>  				},
>  				.iv_size =3D {
> -					.min =3D 16,
> -					.max =3D 16,
> +					.min =3D 12,
> +					.max =3D 12,
>  					.increment =3D 0
>  				}
>  			}, }

I think that we should also remove 16 na 0 bytes allowed in process_gcm_cry=
pto_op() function:
	if (op->cipher.iv.length !=3D 16 && op->cipher.iv.length !=3D 12 &&
			op->cipher.iv.length !=3D 0) {
		GCM_LOG_ERR("iv");
		return -1;
	}

Regards,
Piotr