From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 843BEA00C5; Sun, 26 Apr 2020 14:36:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C09F34C7A; Sun, 26 Apr 2020 14:36:24 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 5487C493D for ; Sun, 26 Apr 2020 14:36:23 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 8CCD458017C; Sun, 26 Apr 2020 08:36:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 26 Apr 2020 08:36:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= YSBPKg6XgYFLCCMpsWgayh7h92cQEvVPYuv/ceVELfw=; b=XGo4YNsE6Sm7JwY2 VBoM88jX+/YYwG1AkT06UOUaCnG9rJKyudWPx9zOxMMHy6tUdGw0GTbBCRL2WFMp 0QUmUnVj7nAKH9BmAgKh+Y6S+KzXqNZjWbzLZlR9wVA/AQkJ76GDumGi0HPy0KQX o87znBCnJDMJ99oBpD/qWU+OVFhbKNzm9r+XNbpOTmVSOMUmJ6/Qy8NhF9LOqggs j4LDu0ePI2SA5gWXKIO+zxjUZLEIc0LJTLsp1t41lbQV9UMe+1BlYv9ZvGnIi1BI o/+/tSnVlKUGJyPpAmM+xeCp4gIXzbl9xFa6wnZuaZgdbtgck7KxHmYQ+FoZP2Vw RtFLvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=YSBPKg6XgYFLCCMpsWgayh7h92cQEvVPYuv/ceVEL fw=; b=nXT15Ic7YHN3VhzxzrnvZ/BzO1PUsNfFmc1edjC2BU3LXiq+hVS8lfNtn dYaYEsBZU0FPuIK1Da/5KCn3mmEPDP5vhU4EgGh3CsmFCa4UAJadpdmXiH3YFXQr a+DgWXq38yFq2SqLIjzHavI7rBntqGrNkmavD0ZYZqHFQCPLSvm8i+XTo4kRTl+I wxpjMa9jApCyRQ90ahA+g/z0GB39aVHIjE6nG43QV2Z5F+88oWwtaalmr+SFKdwT um69Z8BkG8TNs86bEqIetTRuqlZWioW3BCHilamltNm8zSvS2xE/8VWNbdPLKgZQ uGbLnQ/BkUrLuQiljhS5bVM9G+TAg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 921653280063; Sun, 26 Apr 2020 08:36:19 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk , Jerin Jacob Cc: dpdk-dev , Pallavi Kadam , Narcisa Ana Maria Vasile , Ranjit Menon , Jerin Jacob , Sunil Kumar Kori , Bruce Richardson , Harini Ramakrishnan , Omar Cardona , David Marchand Date: Sun, 26 Apr 2020 14:36:18 +0200 Message-ID: <4842284.jY9Djz4Zq0@thomas> In-Reply-To: References: <20200426032245.2437733-1-dmitry.kozliuk@gmail.com> <20200426150202.521e7930@Sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix build by supporting trace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/04/2020 14:23, Jerin Jacob: > On Sun, Apr 26, 2020 at 5:32 PM Dmitry Kozlyuk wrote: > > While we're at it, don't these declarations belong to eal_filesystem.h? I > > left them in eal_private.h, because eal_filesystem.h is mostly Unix-specific. Yes it looks to be a good fit for eal_filesystem.h. Don't hesitate removing Linux specifics (starting with the file comment). > Understood, Leaving that decision to EAL maintainers. There is no EAL maintainer for this.