DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev]  [PATCH v5 0/5] fixes for tap
@ 2020-04-16  3:03 wangyunjian
  2020-04-16  5:07 ` Stephen Hemminger
  0 siblings, 1 reply; 4+ messages in thread
From: wangyunjian @ 2020-04-16  3:03 UTC (permalink / raw)
  To: dev, ferruh.yigit; +Cc: keith.wiles, jerry.lilijun, xudingke, Yunjian Wang

From: Yunjian Wang <wangyunjian@huawei.com>

This series include five fixes patches for tap PMD driver.

--
v5:
* fix check fd error
v4:
* Update some code suggested by Ferruh Yigit and Stephen Hemminger
* Update commit log
* Add fix leak of fds on failure
v3:
* Add fix close a vaild fd and netlink socket file descriptor check
  before close
v2:
* Add null check in tap_rxq_pool_free()

Yunjian Wang (5):
  net/tap: fix mbuf double free when writev fails
  net/tap: fix mbuf and mem leak during queue release
  net/tap: fix check for mbuf's nb_segs failure
  net/tap: fix close a valid fd
  net/tap: fix leak of fds on failure

 drivers/net/tap/rte_eth_tap.c | 106 ++++++++++++++++++++--------------
 1 file changed, 63 insertions(+), 43 deletions(-)

-- 
2.19.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v5 0/5] fixes for tap
  2020-04-16  3:03 [dpdk-dev] [PATCH v5 0/5] fixes for tap wangyunjian
@ 2020-04-16  5:07 ` Stephen Hemminger
  2020-04-16 11:54   ` Ferruh Yigit
  2020-04-16 11:54   ` Ferruh Yigit
  0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2020-04-16  5:07 UTC (permalink / raw)
  To: wangyunjian; +Cc: dev, ferruh.yigit, keith.wiles, jerry.lilijun, xudingke

On Thu, 16 Apr 2020 11:03:57 +0800
wangyunjian <wangyunjian@huawei.com> wrote:

> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> This series include five fixes patches for tap PMD driver.
> 
> --
> v5:
> * fix check fd error
> v4:
> * Update some code suggested by Ferruh Yigit and Stephen Hemminger
> * Update commit log
> * Add fix leak of fds on failure
> v3:
> * Add fix close a vaild fd and netlink socket file descriptor check
>   before close
> v2:
> * Add null check in tap_rxq_pool_free()
> 
> Yunjian Wang (5):
>   net/tap: fix mbuf double free when writev fails
>   net/tap: fix mbuf and mem leak during queue release
>   net/tap: fix check for mbuf's nb_segs failure
>   net/tap: fix close a valid fd
>   net/tap: fix leak of fds on failure
> 
>  drivers/net/tap/rte_eth_tap.c | 106 ++++++++++++++++++++--------------
>  1 file changed, 63 insertions(+), 43 deletions(-)
> 

These all look good.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v5 0/5] fixes for tap
  2020-04-16  5:07 ` Stephen Hemminger
@ 2020-04-16 11:54   ` Ferruh Yigit
  2020-04-16 11:54   ` Ferruh Yigit
  1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-04-16 11:54 UTC (permalink / raw)
  To: Stephen Hemminger, wangyunjian; +Cc: dev, keith.wiles, jerry.lilijun, xudingke

On 4/16/2020 6:07 AM, Stephen Hemminger wrote:
> On Thu, 16 Apr 2020 11:03:57 +0800
> wangyunjian <wangyunjian@huawei.com> wrote:
> 
>> From: Yunjian Wang <wangyunjian@huawei.com>
>>
>> This series include five fixes patches for tap PMD driver.
>>
>> --
>> v5:
>> * fix check fd error
>> v4:
>> * Update some code suggested by Ferruh Yigit and Stephen Hemminger
>> * Update commit log
>> * Add fix leak of fds on failure
>> v3:
>> * Add fix close a vaild fd and netlink socket file descriptor check
>>   before close
>> v2:
>> * Add null check in tap_rxq_pool_free()
>>
>> Yunjian Wang (5):
>>   net/tap: fix mbuf double free when writev fails
>>   net/tap: fix mbuf and mem leak during queue release
>>   net/tap: fix check for mbuf's nb_segs failure
>>   net/tap: fix close a valid fd
>>   net/tap: fix leak of fds on failure
>>
>>  drivers/net/tap/rte_eth_tap.c | 106 ++++++++++++++++++++--------------
>>  1 file changed, 63 insertions(+), 43 deletions(-)
>>
> 
> These all look good.
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v5 0/5] fixes for tap
  2020-04-16  5:07 ` Stephen Hemminger
  2020-04-16 11:54   ` Ferruh Yigit
@ 2020-04-16 11:54   ` Ferruh Yigit
  1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-04-16 11:54 UTC (permalink / raw)
  To: Stephen Hemminger, wangyunjian; +Cc: dev, keith.wiles, jerry.lilijun, xudingke

On 4/16/2020 6:07 AM, Stephen Hemminger wrote:
> On Thu, 16 Apr 2020 11:03:57 +0800
> wangyunjian <wangyunjian@huawei.com> wrote:
> 
>> From: Yunjian Wang <wangyunjian@huawei.com>
>>
>> This series include five fixes patches for tap PMD driver.
>>
>> --
>> v5:
>> * fix check fd error
>> v4:
>> * Update some code suggested by Ferruh Yigit and Stephen Hemminger
>> * Update commit log
>> * Add fix leak of fds on failure
>> v3:
>> * Add fix close a vaild fd and netlink socket file descriptor check
>>   before close
>> v2:
>> * Add null check in tap_rxq_pool_free()
>>
>> Yunjian Wang (5):
>>   net/tap: fix mbuf double free when writev fails
>>   net/tap: fix mbuf and mem leak during queue release
>>   net/tap: fix check for mbuf's nb_segs failure
>>   net/tap: fix close a valid fd
>>   net/tap: fix leak of fds on failure
>>
>>  drivers/net/tap/rte_eth_tap.c | 106 ++++++++++++++++++++--------------
>>  1 file changed, 63 insertions(+), 43 deletions(-)
>>
> 
> These all look good.
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-16 11:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16  3:03 [dpdk-dev] [PATCH v5 0/5] fixes for tap wangyunjian
2020-04-16  5:07 ` Stephen Hemminger
2020-04-16 11:54   ` Ferruh Yigit
2020-04-16 11:54   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).