* [PATCH 1/1] node: remove MAX macro from all nodes
@ 2023-07-19 12:30 Rakesh Kudurumalla
2023-08-01 8:49 ` Rakesh Kudurumalla
0 siblings, 1 reply; 5+ messages in thread
From: Rakesh Kudurumalla @ 2023-07-19 12:30 UTC (permalink / raw)
To: Nithin Dabilpuram, Pavan Nikhilesh; +Cc: dev, jerinj, Rakesh Kudurumalla
Removed MAX macro from all graph nodes to extend
edges to nodes without ABI breakage
Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
Depends-on: series-28807 ("add UDP v4 support")
lib/node/ip4_lookup.c | 2 +-
lib/node/ip6_lookup.c | 2 +-
lib/node/rte_node_ip4_api.h | 2 --
lib/node/rte_node_ip6_api.h | 2 --
4 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
index d3fc48baf7..21a135a674 100644
--- a/lib/node/ip4_lookup.c
+++ b/lib/node/ip4_lookup.c
@@ -225,7 +225,7 @@ static struct rte_node_register ip4_lookup_node = {
.init = ip4_lookup_node_init,
- .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_MAX,
+ .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_IP4_LOCAL + 1,
.next_nodes = {
[RTE_NODE_IP4_LOOKUP_NEXT_IP4_LOCAL] = "ip4_local",
[RTE_NODE_IP4_LOOKUP_NEXT_REWRITE] = "ip4_rewrite",
diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
index 646e466551..6f56eb5ec5 100644
--- a/lib/node/ip6_lookup.c
+++ b/lib/node/ip6_lookup.c
@@ -362,7 +362,7 @@ static struct rte_node_register ip6_lookup_node = {
.init = ip6_lookup_node_init,
- .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_MAX,
+ .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP + 1,
.next_nodes = {
[RTE_NODE_IP6_LOOKUP_NEXT_REWRITE] = "ip6_rewrite",
[RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
index 405bdd3283..f9e38a4b14 100644
--- a/lib/node/rte_node_ip4_api.h
+++ b/lib/node/rte_node_ip4_api.h
@@ -32,8 +32,6 @@ enum rte_node_ip4_lookup_next {
/**< Packet drop node. */
RTE_NODE_IP4_LOOKUP_NEXT_IP4_LOCAL,
/** IP Local node. */
- RTE_NODE_IP4_LOOKUP_NEXT_MAX,
- /**< Number of next nodes of lookup node. */
};
/**
diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h
index f3b5a1002a..a538dc2ea7 100644
--- a/lib/node/rte_node_ip6_api.h
+++ b/lib/node/rte_node_ip6_api.h
@@ -30,8 +30,6 @@ enum rte_node_ip6_lookup_next {
/**< Rewrite node. */
RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP,
/**< Packet drop node. */
- RTE_NODE_IP6_LOOKUP_NEXT_MAX,
- /**< Number of next nodes of lookup node. */
};
/**
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] node: remove MAX macro from all nodes
2023-07-19 12:30 [PATCH 1/1] node: remove MAX macro from all nodes Rakesh Kudurumalla
@ 2023-08-01 8:49 ` Rakesh Kudurumalla
2023-09-27 5:22 ` Nithin Dabilpuram
2023-09-28 9:14 ` [PATCH v3 " Rakesh Kudurumalla
0 siblings, 2 replies; 5+ messages in thread
From: Rakesh Kudurumalla @ 2023-08-01 8:49 UTC (permalink / raw)
To: Nithin Dabilpuram, Pavan Nikhilesh; +Cc: dev, jerinj, Rakesh Kudurumalla
Removed MAX macro from all graph nodes to extend
edges to nodes at ease
Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
v2: Update changes to TOT and resolve
dependecy related issues
lib/node/ip4_lookup.c | 2 +-
lib/node/ip6_lookup.c | 2 +-
lib/node/rte_node_ip4_api.h | 2 --
lib/node/rte_node_ip6_api.h | 2 --
4 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
index 8bce03d7db..72fd760512 100644
--- a/lib/node/ip4_lookup.c
+++ b/lib/node/ip4_lookup.c
@@ -225,7 +225,7 @@ static struct rte_node_register ip4_lookup_node = {
.init = ip4_lookup_node_init,
- .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_MAX,
+ .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP + 1,
.next_nodes = {
[RTE_NODE_IP4_LOOKUP_NEXT_REWRITE] = "ip4_rewrite",
[RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
index 646e466551..6f56eb5ec5 100644
--- a/lib/node/ip6_lookup.c
+++ b/lib/node/ip6_lookup.c
@@ -362,7 +362,7 @@ static struct rte_node_register ip6_lookup_node = {
.init = ip6_lookup_node_init,
- .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_MAX,
+ .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP + 1,
.next_nodes = {
[RTE_NODE_IP6_LOOKUP_NEXT_REWRITE] = "ip6_rewrite",
[RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
index 3397da0ae8..0f997761b6 100644
--- a/lib/node/rte_node_ip4_api.h
+++ b/lib/node/rte_node_ip4_api.h
@@ -29,8 +29,6 @@ enum rte_node_ip4_lookup_next {
RTE_NODE_IP4_LOOKUP_NEXT_REWRITE,
/**< Rewrite node. */
RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP,
- /**< Packet drop node. */
- RTE_NODE_IP4_LOOKUP_NEXT_MAX,
/**< Number of next nodes of lookup node. */
};
diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h
index f3b5a1002a..a538dc2ea7 100644
--- a/lib/node/rte_node_ip6_api.h
+++ b/lib/node/rte_node_ip6_api.h
@@ -30,8 +30,6 @@ enum rte_node_ip6_lookup_next {
/**< Rewrite node. */
RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP,
/**< Packet drop node. */
- RTE_NODE_IP6_LOOKUP_NEXT_MAX,
- /**< Number of next nodes of lookup node. */
};
/**
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] node: remove MAX macro from all nodes
2023-08-01 8:49 ` Rakesh Kudurumalla
@ 2023-09-27 5:22 ` Nithin Dabilpuram
2023-09-28 9:14 ` [PATCH v3 " Rakesh Kudurumalla
1 sibling, 0 replies; 5+ messages in thread
From: Nithin Dabilpuram @ 2023-09-27 5:22 UTC (permalink / raw)
To: Rakesh Kudurumalla; +Cc: Nithin Dabilpuram, Pavan Nikhilesh, dev, jerinj
Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
On Tue, Aug 1, 2023 at 2:19 PM Rakesh Kudurumalla
<rkudurumalla@marvell.com> wrote:
>
> Removed MAX macro from all graph nodes to extend
> edges to nodes at ease
>
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> ---
>
> v2: Update changes to TOT and resolve
> dependecy related issues
>
> lib/node/ip4_lookup.c | 2 +-
> lib/node/ip6_lookup.c | 2 +-
> lib/node/rte_node_ip4_api.h | 2 --
> lib/node/rte_node_ip6_api.h | 2 --
> 4 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
> index 8bce03d7db..72fd760512 100644
> --- a/lib/node/ip4_lookup.c
> +++ b/lib/node/ip4_lookup.c
> @@ -225,7 +225,7 @@ static struct rte_node_register ip4_lookup_node = {
>
> .init = ip4_lookup_node_init,
>
> - .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_MAX,
> + .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP + 1,
> .next_nodes = {
> [RTE_NODE_IP4_LOOKUP_NEXT_REWRITE] = "ip4_rewrite",
> [RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
> diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
> index 646e466551..6f56eb5ec5 100644
> --- a/lib/node/ip6_lookup.c
> +++ b/lib/node/ip6_lookup.c
> @@ -362,7 +362,7 @@ static struct rte_node_register ip6_lookup_node = {
>
> .init = ip6_lookup_node_init,
>
> - .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_MAX,
> + .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP + 1,
> .next_nodes = {
> [RTE_NODE_IP6_LOOKUP_NEXT_REWRITE] = "ip6_rewrite",
> [RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
> diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
> index 3397da0ae8..0f997761b6 100644
> --- a/lib/node/rte_node_ip4_api.h
> +++ b/lib/node/rte_node_ip4_api.h
> @@ -29,8 +29,6 @@ enum rte_node_ip4_lookup_next {
> RTE_NODE_IP4_LOOKUP_NEXT_REWRITE,
> /**< Rewrite node. */
> RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP,
> - /**< Packet drop node. */
> - RTE_NODE_IP4_LOOKUP_NEXT_MAX,
> /**< Number of next nodes of lookup node. */
> };
>
> diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h
> index f3b5a1002a..a538dc2ea7 100644
> --- a/lib/node/rte_node_ip6_api.h
> +++ b/lib/node/rte_node_ip6_api.h
> @@ -30,8 +30,6 @@ enum rte_node_ip6_lookup_next {
> /**< Rewrite node. */
> RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP,
> /**< Packet drop node. */
> - RTE_NODE_IP6_LOOKUP_NEXT_MAX,
> - /**< Number of next nodes of lookup node. */
> };
>
> /**
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/1] node: remove MAX macro from all nodes
2023-08-01 8:49 ` Rakesh Kudurumalla
2023-09-27 5:22 ` Nithin Dabilpuram
@ 2023-09-28 9:14 ` Rakesh Kudurumalla
2023-10-17 11:07 ` Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: Rakesh Kudurumalla @ 2023-09-28 9:14 UTC (permalink / raw)
To: Nithin Dabilpuram, Pavan Nikhilesh; +Cc: dev, jerinj, Rakesh Kudurumalla
Removed MAX macro from all graph nodes to extend
edges to nodes at ease
Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
v3: Updated acked-by
lib/node/ip4_lookup.c | 2 +-
lib/node/ip6_lookup.c | 2 +-
lib/node/rte_node_ip4_api.h | 2 --
lib/node/rte_node_ip6_api.h | 2 --
4 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
index 8bce03d7db..72fd760512 100644
--- a/lib/node/ip4_lookup.c
+++ b/lib/node/ip4_lookup.c
@@ -225,7 +225,7 @@ static struct rte_node_register ip4_lookup_node = {
.init = ip4_lookup_node_init,
- .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_MAX,
+ .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP + 1,
.next_nodes = {
[RTE_NODE_IP4_LOOKUP_NEXT_REWRITE] = "ip4_rewrite",
[RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
index 646e466551..6f56eb5ec5 100644
--- a/lib/node/ip6_lookup.c
+++ b/lib/node/ip6_lookup.c
@@ -362,7 +362,7 @@ static struct rte_node_register ip6_lookup_node = {
.init = ip6_lookup_node_init,
- .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_MAX,
+ .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP + 1,
.next_nodes = {
[RTE_NODE_IP6_LOOKUP_NEXT_REWRITE] = "ip6_rewrite",
[RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
index 3397da0ae8..0f997761b6 100644
--- a/lib/node/rte_node_ip4_api.h
+++ b/lib/node/rte_node_ip4_api.h
@@ -29,8 +29,6 @@ enum rte_node_ip4_lookup_next {
RTE_NODE_IP4_LOOKUP_NEXT_REWRITE,
/**< Rewrite node. */
RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP,
- /**< Packet drop node. */
- RTE_NODE_IP4_LOOKUP_NEXT_MAX,
/**< Number of next nodes of lookup node. */
};
diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h
index f3b5a1002a..a538dc2ea7 100644
--- a/lib/node/rte_node_ip6_api.h
+++ b/lib/node/rte_node_ip6_api.h
@@ -30,8 +30,6 @@ enum rte_node_ip6_lookup_next {
/**< Rewrite node. */
RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP,
/**< Packet drop node. */
- RTE_NODE_IP6_LOOKUP_NEXT_MAX,
- /**< Number of next nodes of lookup node. */
};
/**
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/1] node: remove MAX macro from all nodes
2023-09-28 9:14 ` [PATCH v3 " Rakesh Kudurumalla
@ 2023-10-17 11:07 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2023-10-17 11:07 UTC (permalink / raw)
To: Rakesh Kudurumalla; +Cc: Nithin Dabilpuram, Pavan Nikhilesh, dev, jerinj
28/09/2023 11:14, Rakesh Kudurumalla:
> Removed MAX macro from all graph nodes to extend
> edges to nodes at ease
>
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-17 11:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-19 12:30 [PATCH 1/1] node: remove MAX macro from all nodes Rakesh Kudurumalla
2023-08-01 8:49 ` Rakesh Kudurumalla
2023-09-27 5:22 ` Nithin Dabilpuram
2023-09-28 9:14 ` [PATCH v3 " Rakesh Kudurumalla
2023-10-17 11:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).