From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0057.outbound.protection.outlook.com [104.47.33.57]) by dpdk.org (Postfix) with ESMTP id BBDD6201 for ; Wed, 15 Feb 2017 15:10:51 +0100 (CET) Received: from DM5PR03CA0003.namprd03.prod.outlook.com (10.175.104.13) by CY4PR03MB2952.namprd03.prod.outlook.com (10.175.116.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Wed, 15 Feb 2017 14:10:50 +0000 Received: from BY2FFO11FD043.protection.gbl (2a01:111:f400:7c0c::195) by DM5PR03CA0003.outlook.office365.com (2603:10b6:3:118::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13 via Frontend Transport; Wed, 15 Feb 2017 14:10:50 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD043.mail.protection.outlook.com (10.1.14.228) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.904.16 via Frontend Transport; Wed, 15 Feb 2017 14:10:50 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v1FEAluu009456; Wed, 15 Feb 2017 07:10:48 -0700 To: Jan Blunck , References: <1487152929-23627-1-git-send-email-jblunck@infradead.org> <1487152929-23627-4-git-send-email-jblunck@infradead.org> From: Shreyansh Jain Message-ID: <485202cf-3644-5ee9-45b5-d443569bf5b5@nxp.com> Date: Wed, 15 Feb 2017 19:45:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131316414503422542; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39450400003)(39400400002)(39840400002)(39410400002)(39850400002)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(24454002)(377454003)(199003)(189002)(85426001)(230700001)(83506001)(106466001)(53936002)(65956001)(65806001)(356003)(6246003)(47776003)(305945005)(92566002)(105606002)(50986999)(76176999)(54356999)(31686004)(104016004)(23746002)(68736007)(36756003)(229853002)(2906002)(77096006)(6666003)(4001350100001)(97736004)(189998001)(50466002)(2950100002)(389900002)(33646002)(64126003)(38730400002)(5660300001)(8676002)(31696002)(8936002)(65826007)(81166006)(626004)(86362001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2952; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD043; 1:n1ONnKbJZdxDBOgaCbE56VCsNVWhrf+oxZ0tRa0BW6B4baiGqFx1lG2wO0N4wdtpwpusierVvBbZCFMLOB/pw0Hc5DeHG/bkNGXEo2LzMMIi4zLQqIMaVzISEjJZbbmXfvKptPeb9rSmdhfL42omvLe3BUuC6eh3OGipJlnVYDT9I9hl7jrBwSJXlgkWIVWtocsJ3+N7F0RY6vXArzMcYno/6uoqqd+ZPzMgDm94QYn5ofvZDa8AsE2Vs3RJm2efBr5ydCW3AEybZEmenwcKYAfFOiryAfZLajNb+HNZKlUTNRCmy1WgbRAglZdis5IrYZRtDg7PU51DqS+BlHahK3b4LTOI4ETkEuV/66hHgCKm0Knw0O1bf7ukxBfJCOGQeqfqhKPSqNDOZhef4cbPRYVbrol6EY1LKSyZhZnY9gwHluOJneo2+0QLIvHYAFVPDp9F6pXvoVdsbZWFx355vZPsr2GyxubwuZ/mZGXz2V4BxgmD6Ib2jR6EGSPmO7iX1lRBHnEHyT/tF5nk5SL7I4KoNGkXWrwH9eTaz+beqUN7WWSrM9dE+LdL99kQdatJ X-MS-Office365-Filtering-Correlation-Id: 9882cfcd-cafc-44b6-1de5-08d455ac7209 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR03MB2952; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2952; 3:Ifwx71WpmphriKqZalAw9YGcr0EZgNq/z4yQupr9qs4T5MQOEzE/Nn40cmgqVEc+wqS91GUSI9IsLOHAIvOdFjdvw+h4Tiez994ZtVHPmzLYhztHV4I24CQvHI7MLY5BdR+jZW/xm2U5k6Slmoi5HUoqEDwifLTfN+pq88zkUxQErANlaW0Uu8iP/rxSbHWHTrkES5GwcZxc+Zji+CwSmu9Uc0Fd6KFT6HBVYt4SIprv5wsvMJMM7VxjhSej5eWf/gQYoWYe9TGhxnNWpbkbC3g+6JzKssnN7tqtbdn6zT/NPnyUTOVz9nDSFr68ZQu+h3j2OM/WqdGXrky7Bfu7K/2gksEjFYkr/uMgRtl/gC2GIG8vqv2YhEPncf3cPXaP; 25:u0KZK1G12QfBSexJnnS/rXe1lSfI9XVgrbLhGip3g9rjUZqQ1bp7lN8xaeCyp4YORh1B1XX/4YdBqjcOdA55ICe1PvqNIE8T/fQduz+Si1Cs6JCv3govEKsuzV7CKtfQlcRoLdYdvL5ov3K33ULqJgL+fKzKsBRlKyBC8frZ7eDW+BkK65U13VwQxkfNb4/xWx2MChbTqDQXFsNgaIVldTwDthpYWB7QQRYD7uMOtlJNf/ndOCZx56XTYygQeNLPHe/rff483ixEB4vxmfiphkde+7E+jcr+OZiundsN8F/rTuKATdtMz+nizqx3A3ke2bdjSGocx44DIJwrDPy0pK4rsCP0ZEZ/IlYU5OSTyNgbu0opTcIjxaoFSJ5ahGDQBqeBiSUH0cl7q0FD7r9BzMafFt97Y8ze8DojNR63adR4LzjMverUhGVnzywvomcZTBfDpljTyTZC64N6RDIBgA== X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2952; 31:VVgQPvSEkYgAQPVMaJuir1+N/ukfUiwQ+U6+WprsMOG86hMDVqHrKiLla/yLotQX4WGA0L1iNtaKrjtKzE8GalxLxqZKREmP8S0hulTyIzcP2EFT6/c8rL/j4mIwMwjKiUBjdFtIZeh6SLOtNMEmizmL4vYXO3mr6sbdclDmA3MSjqjpUZm2s023Sz5YD32pB65X/t3zRyBGp7T2lqRnymlNiePPElsmbQ/slAG7WZ8/6c59vNit0UCzDkbxG2TA+XMoq3O5ntCCrHsAiDfPvQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13018025)(13023025)(13024025)(8121501046)(13017025)(5005006)(13015025)(10201501046)(3002001)(6055026)(6096035)(20161123563025)(20161123565025)(20161123561025)(20161123559025)(20161123556025); SRVR:CY4PR03MB2952; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2952; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2952; 4:0qFBrUzqjizx1AxzRXkG+4fvT3wQpxWfbJaBiGVefEnT40bRhrKawZHfkWT9uR0kItjwSdwsk4AtC01VIjK4rs0sARo0Hqm6lbQ0tB9E0bQGifFAEmec6Wm/Q5ta6BgjPKlzGUc+DpC9dowDr5NVOycW6ITL2Cgqlyww0jEdksVRlhx6/VytihKPtgBQTEbp1umgyf4mSWYrTfoBxRRp8zNRkj7SS7+L5mtcTysofhDqi47v2u2DBOaOPPNFbVuiCAK8cMLaaFnMT7jdrSB1MKoNzfKN4gDiZbwIl4HQCp+qSBWO0DuSBDQINQgDMrMxdp0BySZfE4Fd0y7X/n3YCtquQnc54ChwEbnJbJM9Jnoty7CUZFvmwFOFSRqZEAZkm8GgBmpR8G3tN44wr1zHxgduS6fR6of50YEndWrDCdtpXm/yNn3cGvhrbAOdMBHeEU8lAspfuxSK6oamjgAic2mQza+DqlWLI1tTd334w4LrFHi3Ew1JFYx84Fu0no1CJvGzqw5+gpDo3MxevawjkIHUYc2cHhPaJ+dEKaEkuF6IKk4+m6I0OVs+JHqm/kKdu+hsCd6Taleq7xANjsUO/f+c8tLfi4oB9wgtx3EVrjKqRxqjWBtdKv1ybNqmKpg1n9BgSFOg/sI+WgMadp+1gL4FwR5ZW2VXwoPmHajOUJ2g5A4+e8c0KwFbh26O1Xju586pECENdBeV8hjIAFbumA== X-Forefront-PRVS: 021975AE46 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR03MB2952; 23:eFBQOVeTZn5J9+4QT0knZ3+0Pcy0KkhJJ2iEj?= =?Windows-1252?Q?olT/XaNjNEu33O98HLK/A9KkBhGH2VTftuz+FQKTshePRQuN7gLqCmgn?= =?Windows-1252?Q?jn/6OglxiPw/0aPmlZc/a/CQDAz4dLz71fw2Y1D1owSglcrp2+pF92C8?= =?Windows-1252?Q?yyf004UDdHa/8h4TE8YYbcvqTiDH3byOSec85QOsN86X+lU6voL0blX4?= =?Windows-1252?Q?KiOclGRWBtVEppIabqGANfC33pXnUBebigit3MOW9tjxVCnptTzHKye/?= =?Windows-1252?Q?Qkl+Yj3v31GNQHH+8qjnIHk+OsfbAOaKrvbiyDYOyNt2OfYQtRoIatjj?= =?Windows-1252?Q?OjsX0Pi48FA6Dah4DGYnIVPVGQQ62kjM8BIHW42OSN7WNoCTYUKR5aUg?= =?Windows-1252?Q?W0+fQnbIuP+iW58U6H0ristTJI4ykJFBuggKGyOgSxR6G3Is2mlou1ri?= =?Windows-1252?Q?NFXDi1z4XnPr3NrD8QnyZw2UxmAEBvwWZgcxflcBbFuR+rfiXTrrbHWq?= =?Windows-1252?Q?X1elzxA9JCg+nzt7GUjA8XOq0G1TFYlz3dEak2n6/FpC5c7IYyOEalOd?= =?Windows-1252?Q?4hy5y5CKCSOGTq2MhjSla2/WNqAFsnGVNeF98FbU7rDodYkW7Hhmx9jq?= =?Windows-1252?Q?fG4t004EFLkigQxIB1taakypNV7nAH/3lWTH7g6JsQMPRhp1j6eI01nR?= =?Windows-1252?Q?seBzdeGotMWuHbtF1YWfJJwoikeKhqyrXxepgx6StoLN5LKf0QojW3nA?= =?Windows-1252?Q?VByVrfH6kTzpWpPeaYL5iaPrTznLyYgqXGlMHYYCZllp89lUGu9HbHmS?= =?Windows-1252?Q?tHJgOC48Yntkt9S5rGynQGvFZxeiElzE7KBJFxPXAARK1p6VFeZ2pck+?= =?Windows-1252?Q?Fuu7wxk8LWY5BVxYWPJ8I4aOHcCBvIRT2rKobhvfhLP3fq8sRUlA7bS7?= =?Windows-1252?Q?73cxAqSte5qXuhv7RKRckgXqcJci511MZtV7+bTvgX8rCVlBy4fmcq1s?= =?Windows-1252?Q?WgHI0/iUZAYSeEy6Fxdm59FlwDl3H0Sut7KuSLoRo9Bc2VTTMmBMrvSX?= =?Windows-1252?Q?1evpqs952CSd6aVic1YrR9pJvQtC81bdstSl8f1RmRRttOX3mndTTanQ?= =?Windows-1252?Q?7gRhCCvcQTWqBx/DNCxUGVeXd10SHD25CA+X2caoHtxvZL6vIKo0CUBU?= =?Windows-1252?Q?sip2KUqtULKiqIenK72oRWbkTkhRqHR9PnjNmCND+pnX5ibBF9vwNZ9/?= =?Windows-1252?Q?VxQYP+HlfRFNBHlS+uYoH9HITUEpm9FoyuCLqAv6CZsM4Rj4vlK3jWRX?= =?Windows-1252?Q?4UJrDxKEL0GHCqNJ6mqZIYF1yFhc3lXn9Vcgi3Do8KqnoaoD9y63CVJU?= =?Windows-1252?Q?1Uox6bYXNdXH2ryQJcRynqFVOAtn6WdscGu1ZprLzu0/2w1+zZkqyS1p?= =?Windows-1252?Q?6kspAvDw/RdQFBh2QMUGlq7BNpDAfxmiqOUFvIOnOzuFUCwfiCtK61YS?= =?Windows-1252?Q?n02eAIlSujQ6rljfhBQ66UH4Ili8hFhLblCI9HifTirSLgzmXj29S/IK?= =?Windows-1252?Q?LlWNpzkmnQHs27wshXvKRHWsTc8Y+d3JjnVSGmdM0nIpHxGFluS+HI/L?= =?Windows-1252?B?dz09?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2952; 6:udnXOG8VjR5X3sRv7ZNzzguIw5g2u8YNunPWDqz4qG1hxJX9ftjXYunMke3QYc5jgJGghjZGzfA9VvDtbF3JgF2AgNibDXu4muB/Jh6AfVoGhW/zLJAoYMm3HdwsNCtIJ0/LCWcOrAnOyxLeDt+vLv9bTKi9viHDqqBs9i8Gb9igUQYnSwC0m4MCwee6wQ2++4yzrqximpXqvOp2dU3fRkMP/QH5UhWRiSpFpEuqDgILr/RMm2VrMSCdZReDyJMceo7cKLum40gomhmh1OnIX4H/RVuF3KiKAYhTy44VcVhMUO8QpL7jMdyqHT//yV7AEp4WdfdHLgEdooQh5yAtJ9yW0cnwevmVvwHA6zkIFacHvIR1+7nqQl26IcB2HE4l1CW3Ev4oA8Eis32YKHDm2ZxnUdCiXMx1T4b5IJkzxYU=; 5:2bRnWaTOsf+DmfwTiC+t7R5AM38SWIEdzxkC3o+dKvoOY5TJrHxWzhGsRHlMr+ww3p0pzT/XzV3Ou8eOrGux+Y+zSCQJJX9+vH16mtJDGxZTFCd+V+k9UKwLfCGm8Zz3Ca3pn0yObVS/wproDkGSjpKpH2Y3QpW7beOigcl7ZRwn+6M/GUPrll6Q+U2rtizL; 24:eNYa1YWD/LpWGBBAg7QQnu/Cl5AEpeAQeyCe+wq+ZT7G/5RUL9YlTaSL7PS9f0lma9Fz6UIsetohcYlLVHj2mYRajp4IE0C/M1dkp4b+Mso= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2952; 7:xlSkYTvlvyhinf8ruj14sfQzAxlE5F6ZdDTCTTGHIncm3xUIxl1ZwW5LQ9x521QgkAozYyDPKA2OwSa3b5fMq8XLMIu9IqHoC1Ja/i6bF/h3jMdG4I2qc2fSgDxNkEskYgM2Nmyw7LPb3CKGqlIvzKlJ1On7OZOaZoMMO4BeglU3f3sVYKsYtLSU9GGxjD+IlZLM/8OLxlEwx+5ZAGZV/3QOA21e8QaRK9eyp60UYToioc2TyS0yRjNvEyDXoQeWot6ofUYVrb1vGropY0OsWJL1uqSXpkr7tFDl2Ms/Z551JFCTVvl7umd1RlzYsK8s5rU9/kR3b25iAhgqrtOJjiqBhKzvO4AV8GIoPP5UejMc+BvG+EEYeznmFFa7zefCHqnkGH/gql98+Oi1ST1qoFKXBfD5zxYtVIcTTPnnUk1hs8ZI0+iKIQA2REpSGz8891kVB69l9zJBMioi4wlFV+5yCxsfaWS5mBMj7JQRVMrbwIkRvveVwbhEcLakoPtGZ6SvNHgPrhkqW3jkvK/o4g== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2017 14:10:50.0146 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2952 Subject: Re: [dpdk-dev] [PATCH 3/7] eal: move virtual device probing into a bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 14:10:52 -0000 On Wednesday 15 February 2017 07:41 PM, Shreyansh Jain wrote: > On Wednesday 15 February 2017 03:32 PM, Jan Blunck wrote: >> This is a refactoring of the virtual device probing which moves into into >> a proper bus structure. >> >> Signed-off-by: Jan Blunck >> --- >> lib/librte_eal/common/eal_common_dev.c | 22 ----------------- >> lib/librte_eal/common/eal_common_vdev.c | 44 >> +++++++++++++++++++++++++++++++++ >> 2 files changed, 44 insertions(+), 22 deletions(-) >> > > [...] > >> >> diff --git a/lib/librte_eal/common/eal_common_vdev.c >> b/lib/librte_eal/common/eal_common_vdev.c >> index 7d6e54f..523a3d6 100644 >> --- a/lib/librte_eal/common/eal_common_vdev.c >> +++ b/lib/librte_eal/common/eal_common_vdev.c >> @@ -37,8 +37,10 @@ >> #include >> #include >> > [...] > >> + >> +static struct rte_bus rte_vdev_bus = { >> + .scan = vdev_scan, >> + .probe = vdev_probe, >> +}; >> + >> +RTE_REGISTER_BUS_LATE(virtual, rte_vdev_bus); >> > > Does it matter if VDEV buses are registered before or after other > buses? Either way, the callbacks would be called in the order specified > in EAL. > > Just ignore this comment - I am misunderstood something. But another question: Is there specific reason VDEV should be registered/scanned *after* other devices? Is there some specific problem if we do otherwise? (I think this is should be done, but I don't have a specific reason).