Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: demo of simple rte flow

[Thomas Monjalon <thomas@monjalon.net>]

Few comments below, Ori:

25/10/2017 19:58, Ori Kam:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -978,3 +978,7 @@ F: examples/tep_termination/
>  F: examples/vmdq/
>  F: examples/vmdq_dcb/
>  F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst
> +
> +M: Ori Kam <orika@mellanox.com>
> +F: examples/flow_filtering/
> +F: doc/guides/sample_app_ug/flow_filtering.rst

Please keep examples in alphabetical order.

> --- a/doc/guides/sample_app_ug/index.rst
> +++ b/doc/guides/sample_app_ug/index.rst
> @@ -77,6 +77,7 @@ Sample Applications User Guides
>      ptpclient
>      performance_thread
>      ipsec_secgw
> +    flow_filtering

I don't know whether there is an order in this index.

> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -100,5 +100,6 @@ endif
>  endif
>  
>  DIRS-y += eventdev_pipeline_sw_pmd
> +DIRS-y += flow_filtering

Most of apps are in alphabetical order in this Makefile.

> --- /dev/null
> +++ b/examples/flow_filtering/Makefile
> @@ -0,0 +1,17 @@

A license header is required.

> +ifeq ($(RTE_SDK),)
> +$(error "Please define RTE_SDK environment variable")
> +endif
> +
> +# Default target, can be overridden by command line or environment
> +RTE_TARGET ?= x86_64-native-linuxapp-gcc
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +APP = flow
> +
> +SRCS-y := main.c
> +
> +CFLAGS += -g3

-g3 ? Is it a mistake?

> --- /dev/null
> +++ b/examples/flow_filtering/main.c
> @@ -0,0 +1,244 @@
> +/*-
> + *   BSD LICENSE
> + *
> + *   Copyright 2017 Mellanox.
> + *
> + *   Redistribution and use in source and binary forms, with or without
> + *   modification, are permitted provided that the following conditions
> + *   are met:
> + *
> + *     * Redistributions of source code must retain the above copyright
> + *       notice, this list of conditions and the following disclaimer.
> + *     * Redistributions in binary form must reproduce the above copyright
> + *       notice, this list of conditions and the following disclaimer in
> + *       the documentation and/or other materials provided with the
> + *       distribution.
> + *     * Neither the name of 6WIND S.A. nor the names of its

Wrong copyright holder reference here.