From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D280642672; Fri, 29 Sep 2023 13:51:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61A25402AA; Fri, 29 Sep 2023 13:51:13 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 2E12D40287; Fri, 29 Sep 2023 13:51:12 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 810EB5C0100; Fri, 29 Sep 2023 07:51:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 29 Sep 2023 07:51:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1695988271; x=1696074671; bh=u/UqLvatuS7dE4oPld41vqS4ZNJyZrUG80g rZ7hjbQY=; b=lmgTmmPkHwRQvitam6BrvW/tG4gTGnNqNe79BqR6SKVxgPhBKeg Cf1sWCr3LrdlZpmv329Bavr6VwyU42YU0OFnSQ2LP3boGbG0rQuAM3RmyIZymTCj Hs3Zr39WYNrKtbt95fI1iGJucroM0y4u/W2PpsW2c1C57tn4RmTn+c4MDfpdKHe2 aHwxYHIYuCTXhacVvXw3zTBCqLNC2gZghEylxvTvSMcHFfw9Hfd6W/RoFtxK9CYj UF6XLynL7E2keJe3JIHYek18Dj293tCbtQPDu2vME+rO/zYoj2VjzWkXvokfA9UD 7Pc5kj4Ja5D217HEDtXmObkE0fAOzCDvyWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1695988271; x=1696074671; bh=u/UqLvatuS7dE4oPld41vqS4ZNJyZrUG80g rZ7hjbQY=; b=XRDknggpJ5yy+KIspZsl5TFy4XUx3lICJ62PRTnkhtV194u6kqq 38SDYZhQLD2/IdficU32zY5fxlYNgH+dc++b4Xg+NGvhWglQgcu+Yic31RqKV0/9 LnVlRReAjjXCGcwKY20OB11c1ePvEZ3EyOJw60Nk+ac5RLRoE64JwQaqVT9sExa8 mVA/2CSKiPCyHB1aJFLhiR8Im0So1FsrcU6QQJ+z+lsnyrQPy4g9K3yc2bzYleHL 5+7Hegeb4yjlakxrNQFwXUoyTL/dV8MXm6Jm2w/WbRH72j4a20n6bqelG6vATTu1 Joz+ZjpUDPTFLjG01NzOJ33G4M7t8KwOFFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrtddvgdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Sep 2023 07:51:08 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: Bruce Richardson , Morten =?ISO-8859-1?Q?Br=F8rup?= , Tyler Retzlaff , dev@dpdk.org, techboard@dpdk.org, Honnappa Nagarahalli , Ruifeng Wang , Jerin Jacob , Sunil Kumar Kori , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Joyce Kong , David Christensen , Konstantin Ananyev , David Hunt Subject: Re: [PATCH v6 1/6] eal: provide rte stdatomics optional atomics API Date: Fri, 29 Sep 2023 13:51:07 +0200 Message-ID: <4865825.4XsnlVU6TS@thomas> In-Reply-To: References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com> <10054797.lvqk35OSZv@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 29/09/2023 13:38, David Marchand: > On Fri, Sep 29, 2023 at 12:26=E2=80=AFPM Thomas Monjalon wrote: > > > > 29/09/2023 11:34, David Marchand: > > > On Fri, Sep 29, 2023 at 11:26=E2=80=AFAM Bruce Richardson > > > wrote: > > > > > > > > On Fri, Sep 29, 2023 at 11:02:38AM +0200, David Marchand wrote: > > > > > On Fri, Sep 29, 2023 at 10:54=E2=80=AFAM Morten Br=C3=B8rup wrote: > > > > > > In my opinion, our move to C11 thus makes RTE_BUILD_BUG_ON obso= lete. > > > > > > > > > > That's my thought too. > > > > > > > > > > > > > > > > > We should mark RTE_BUILD_BUG_ON as deprecated, and disallow RTE= _BUILD_BUG_ON in new code. Perhaps checkpatches could catch this? > > > > > > > > > > For a clear deprecation of a part of DPDK API, I don't see a need= to > > > > > add something in checkpatch. > > > > > Putting a RTE_DEPRECATED in RTE_BUILD_BUG_ON directly triggers a = build > > > > > warning (caught by CI since we run with Werror). > > > > > > > > > > > > > Would it not be sufficient to just make it an alias for the C11 sta= tic > > > > assertions? It's not like its a lot of code to maintain, and if app= users > > > > have it in their code I'm not sure we get massive benefit from forc= ing them > > > > to edit their code. I'd rather see it kept as a one-line macro pure= ly from > > > > a backward compatibility viewpoint. We can replace internal usages,= though > > > > - which can be checked by checkpatch. > > > > > > No, there is no massive benefit, just trying to reduce our ever > > > growing API surface. > > > > > > Note, this macro should have been kept internal but it was introduced > > > at a time such matter was not considered... > > > > I agree with all. > > Now taking techboard hat, we agreed to avoid breaking API if possible. > > So we should keep RTE_BUILD_BUG_ON forever even if not used. > > Internally we can replace its usages. >=20 > So back to the original topic, I get that static_assert is ok for this pa= tch. Yes we can use static_assert.