From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 84B327EB4
 for <dev@dpdk.org>; Wed, 26 Apr 2017 21:01:12 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga104.jf.intel.com with ESMTP; 26 Apr 2017 12:01:11 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,255,1488873600"; d="scan'208";a="850136360"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.58.98])
 ([10.254.58.98])
 by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2017 12:01:09 -0700
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org
References: <20170425215315.6167-1-ajit.khaparde@broadcom.com>
 <ea173cf3-9ef3-6b73-b56d-86ccf1c31b96@intel.com>
 <CACZ4nhvncuQ4DyRArO2zr0-iTEKWSu3vwZvrEZ_eVXWczFD0+g@mail.gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <486fdaf2-89b8-ecfb-b94d-960eb2c93620@intel.com>
Date: Wed, 26 Apr 2017 20:01:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.0.1
MIME-Version: 1.0
In-Reply-To: <CACZ4nhvncuQ4DyRArO2zr0-iTEKWSu3vwZvrEZ_eVXWczFD0+g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] bnxt: Add new device ids
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Apr 2017 19:01:14 -0000

On 4/26/2017 7:41 PM, Ajit Khaparde wrote:
> 
> On Wed, Apr 26, 2017 at 3:52 AM, Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     On 4/25/2017 10:53 PM, Ajit Khaparde wrote:
>     > Add support for new device ids.
> 
>     Hi Ajit,
> 
>     Is NIC documentation (doc/guides/nics/bnxt.rst) needs to get updated for
>     these new devices?
> 
> ​Yes. It will need a small change. Do you want me to ​resend this patch
> along with that?
> Otherwise I will just send the update to bnxt.rst

Please resend this patch to have document update.

Is a separate web patch also required?

> 
> Thanks
> 
> 
>     Also if http://dpdk.org/doc/nics needs update please send another
>     web patch.
> 
>     Thanks,
>     ferruh
> 
>     >
>     > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com
>     <mailto:ajit.khaparde@broadcom.com>>
>     > ---
>     >  drivers/net/bnxt/bnxt_ethdev.c | 4 ++++
>     >  1 file changed, 4 insertions(+)
>     >
>     > diff --git a/drivers/net/bnxt/bnxt_ethdev.c
>     b/drivers/net/bnxt/bnxt_ethdev.c
>     > index 5dc3ff0..7805221 100644
>     > --- a/drivers/net/bnxt/bnxt_ethdev.c
>     > +++ b/drivers/net/bnxt/bnxt_ethdev.c
>     > @@ -60,6 +60,8 @@ static const char bnxt_version[] =
>     >
>     >  #define PCI_VENDOR_ID_BROADCOM 0x14E4
>     >
>     > +#define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
>     > +#define BROADCOM_DEV_ID_57414_VF 0x16c1
>     >  #define BROADCOM_DEV_ID_57301 0x16c8
>     >  #define BROADCOM_DEV_ID_57302 0x16c9
>     >  #define BROADCOM_DEV_ID_57304_PF 0x16ca
>     > @@ -94,6 +96,8 @@ static const char bnxt_version[] =
>     >  #define BROADCOM_DEV_ID_57416_MF 0x16ee
>     >
>     >  static const struct rte_pci_id bnxt_pci_id_map[] = {
>     > +     { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_STRATUS_NIC) },
>     > +     { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_57414_VF) },
>     >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_57301) },
>     >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_57302) },
>     >       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
>     BROADCOM_DEV_ID_57304_PF) },
>     >
> 
>