From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id ED41E137D for ; Mon, 13 Jun 2016 12:08:06 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id k184so14501390wme.1 for ; Mon, 13 Jun 2016 03:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=XvITdS2IeOdEHAAzp/Wsch8vrpDCLo+UAfSQTY3qlVk=; b=CjV0qvPJNIyHnksJHJV3rWQDfsNfK2fncpxKWQCydza/G79Oz2hH1iAXgvLn0SNCJD L8RdFbj2tzV54QwOFffjPl6DwCaIkg5/6W8IhfwGjoStMXk8db+VASNW8eanvvoX4Ux7 AEXNNiAilBN7SWCJ+qq1+JWUiw6HiC1JP1QqmxNUOn7QINAoGpqGQoT7dWrDMManKWWi u6eBYBZnALav6OW9e/PdshyoTFQQB0NMQGsiwDpA6WWEWtxRvfLvUmy4p+UJaCzRj7rJ sSQQCRXVvkoVwXpBpjJ5kzpjjPbZ5WHKnKNlpzsh3m49Qt5wFeveVNd9dP/S3o1a3DWa YUnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=XvITdS2IeOdEHAAzp/Wsch8vrpDCLo+UAfSQTY3qlVk=; b=er8YFGF0A846RH91vlP6X9nC6padVA2zxxWVPGPQbZ5nt52WXpZFiWqcsXp7jitzh0 Lrl4EkfvmcrG1VncXSobc/BgGkxPktYPMXm2CRzbBZx49gqup/TSAVQOslYudl5lC5O+ tLtzINT1Ha/agmCVtzmkq4sdKk1P8ynxEvbb/RoW/A4kdJaY/LMYmQHOC/7vlXHpe/vB SOQOyycaQJ8P8vl/9GS+4NwX9EDagaWwfatsB9dfIz6MwPqZtdn00xUrtvvRx1MhNBd9 UGcIhQRQgVZrvTi8gyMHSbOiCAFXFXJg6YdvHS5auxrx10unpljkQEAWth3Zi7g2LRxP LpfQ== X-Gm-Message-State: ALyK8tKxzJm4QDfgMw7w8F+7Er/JcV0ysu1TnpkQAlfKhbR7EbiWxYxdISpIeJHpWir/p5r7 X-Received: by 10.194.203.226 with SMTP id kt2mr254789wjc.75.1465812486688; Mon, 13 Jun 2016 03:08:06 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id h8sm26728662wjg.9.2016.06.13.03.08.05 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 13 Jun 2016 03:08:05 -0700 (PDT) From: Thomas Monjalon To: Christian Ehrhardt Cc: ferruh.yigit@intel.com, dev@dpdk.org Date: Mon, 13 Jun 2016 12:08:04 +0200 Message-ID: <4880734.Dg9G2McolW@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1465811334-22395-1-git-send-email-christian.ehrhardt@canonical.com> References: <1465811334-22395-1-git-send-email-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: fix missing DEPDIRS to avoid libarary underlinking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2016 10:08:07 -0000 2016-06-13 11:48, Christian Ehrhardt: > --- a/drivers/net/af_packet/Makefile > +++ b/drivers/net/af_packet/Makefile > @@ -54,5 +54,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += rte_eth_af_packet.c > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_mbuf > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_ether > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_kvargs > +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_eal It looks more logical to have eal as first DEPDIR in these lists. > --- a/drivers/net/vhost/Makefile > +++ b/drivers/net/vhost/Makefile > @@ -36,6 +36,8 @@ include $(RTE_SDK)/mk/rte.vars.mk > # > LIB = librte_pmd_vhost.a > > +LDLIBS += -lpthread > + It is not a DEPDIR but an external dependency. It deserves a separate patch. Do we need it in rte.app.mk? It is an EAL dependency as well.