From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7BDDB1B1EB for ; Wed, 11 Oct 2017 12:42:41 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 11 Oct 2017 03:42:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,361,1503385200"; d="scan'208";a="161831084" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.67.64.69]) ([10.67.64.69]) by fmsmga006.fm.intel.com with ESMTP; 11 Oct 2017 03:42:38 -0700 To: Shreyansh Jain References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1507548444-33959-1-git-send-email-jianfeng.tan@intel.com> <1507548444-33959-4-git-send-email-jianfeng.tan@intel.com> <7732f195-64fd-308c-8faf-c1b0e37d3453@nxp.com> Cc: dev@dpdk.org, jblunck@infradead.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com From: "Tan, Jianfeng" Message-ID: <4883d822-9aa0-4b88-048c-35d7e9da9c1c@intel.com> Date: Wed, 11 Oct 2017 18:42:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <7732f195-64fd-308c-8faf-c1b0e37d3453@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 3/5] bus: introduce new log type for bus drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 10:42:41 -0000 On 10/11/2017 2:54 PM, Shreyansh Jain wrote: > Hello Jianfeng, > > On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote: >> [...] >> -#define PMD_DRV_LOG(level, fmt, args...) \ >> - PMD_DRV_LOG_RAW(level, fmt "\n", ## args) >> +#define FSLMC_VFIO_LOG(level, fmt, args...) \ >> + RTE_LOG(level, EAL, "%s(): " fmt "\n", __func__, ##args) > > This change breaks the FSLMC bus driver. There are macros like > PMD_DRV_LOG which are still in use in the code. > Before removing the above, those would have to be restructured. Just try to change all PMD_DRV_LOG in fslmc to FSLMC_VFIO_LOG. As you are working on that, I will drop it. > > I am already working on converting this logging into dynamic logging. > Can you skip this work until then? Does it block your work? Do you mean you are working on introducing a new log type for bus drivers? Thanks, Jianfeng