From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ariel Rodriguez <arodriguez@callistech.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Issue on rte_sched.c
Date: Sun, 01 May 2016 21:58:06 +0200 [thread overview]
Message-ID: <4885249.p6c3dYjJKD@xps13> (raw)
In-Reply-To: <CADoa0bZQw565CdMwhnfBF4=vhkO0AgaUe4+d+QCBZBe0QUSJmg@mail.gmail.com>
2016-04-30 05:50, Ariel Rodriguez:
> Yes i am refereing on that commit.
>
> About RTE_MACHINE_CPUFLAG_* , i agreed.
>
> I never prepare a patch ... maybe is time to put my hands on that.
Yes it is a good way to make your first patch.
See http://dpdk.org/dev#send
Thanks
> 2016-04-13 20:35, Ariel Rodriguez:
> > Hello, viewing the new code of librte_sched/ i found this line strange ...
> >
> > #if defined(__SSE4__)
>
> Are you refering to http://dpdk.org/commit/90f455f ?
>
> > if instead i use :
> >
> > #if defined(__SSE4_2__) || defined(__SSE4_1__)
> >
> > works like a charm ...
> >
> > i never see in any directive like __SSE4__
>
> Indeed, it is strange.
> By the way, it is recommended to use RTE_MACHINE_CPUFLAG_*.
prev parent reply other threads:[~2016-05-01 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 23:35 Ariel Rodriguez
2016-04-14 7:19 ` Thomas Monjalon
2016-04-30 8:50 ` Ariel Rodriguez
2016-05-01 19:58 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4885249.p6c3dYjJKD@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=arodriguez@callistech.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).