* [dpdk-dev] Issue on rte_sched.c
@ 2016-04-13 23:35 Ariel Rodriguez
2016-04-14 7:19 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ariel Rodriguez @ 2016-04-13 23:35 UTC (permalink / raw)
To: dev
Hello, viewing the new code of librte_sched/ i found this line strange ...
#if defined(__SSE4__)
if instead i use :
#if defined(__SSE4_2__) || defined(__SSE4_1__)
works like a charm ...
i never see in any directive like __SSE4__
Regards
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] Issue on rte_sched.c
2016-04-13 23:35 [dpdk-dev] Issue on rte_sched.c Ariel Rodriguez
@ 2016-04-14 7:19 ` Thomas Monjalon
2016-04-30 8:50 ` Ariel Rodriguez
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2016-04-14 7:19 UTC (permalink / raw)
To: Ariel Rodriguez; +Cc: dev
2016-04-13 20:35, Ariel Rodriguez:
> Hello, viewing the new code of librte_sched/ i found this line strange ...
>
> #if defined(__SSE4__)
Are you refering to http://dpdk.org/commit/90f455f ?
> if instead i use :
>
> #if defined(__SSE4_2__) || defined(__SSE4_1__)
>
> works like a charm ...
>
> i never see in any directive like __SSE4__
Indeed, it is strange.
By the way, it is recommended to use RTE_MACHINE_CPUFLAG_*.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] Issue on rte_sched.c
2016-04-14 7:19 ` Thomas Monjalon
@ 2016-04-30 8:50 ` Ariel Rodriguez
2016-05-01 19:58 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ariel Rodriguez @ 2016-04-30 8:50 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
Yes i am refereing on that commit.
About RTE_MACHINE_CPUFLAG_* , i agreed.
I never prepare a patch ... maybe is time to put my hands on that.
2016-04-13 20:35, Ariel Rodriguez:
> Hello, viewing the new code of librte_sched/ i found this line strange ...
>
> #if defined(__SSE4__)
Are you refering to http://dpdk.org/commit/90f455f ?
> if instead i use :
>
> #if defined(__SSE4_2__) || defined(__SSE4_1__)
>
> works like a charm ...
>
> i never see in any directive like __SSE4__
Indeed, it is strange.
By the way, it is recommended to use RTE_MACHINE_CPUFLAG_*.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] Issue on rte_sched.c
2016-04-30 8:50 ` Ariel Rodriguez
@ 2016-05-01 19:58 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-05-01 19:58 UTC (permalink / raw)
To: Ariel Rodriguez; +Cc: dev
2016-04-30 05:50, Ariel Rodriguez:
> Yes i am refereing on that commit.
>
> About RTE_MACHINE_CPUFLAG_* , i agreed.
>
> I never prepare a patch ... maybe is time to put my hands on that.
Yes it is a good way to make your first patch.
See http://dpdk.org/dev#send
Thanks
> 2016-04-13 20:35, Ariel Rodriguez:
> > Hello, viewing the new code of librte_sched/ i found this line strange ...
> >
> > #if defined(__SSE4__)
>
> Are you refering to http://dpdk.org/commit/90f455f ?
>
> > if instead i use :
> >
> > #if defined(__SSE4_2__) || defined(__SSE4_1__)
> >
> > works like a charm ...
> >
> > i never see in any directive like __SSE4__
>
> Indeed, it is strange.
> By the way, it is recommended to use RTE_MACHINE_CPUFLAG_*.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-01 19:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-13 23:35 [dpdk-dev] Issue on rte_sched.c Ariel Rodriguez
2016-04-14 7:19 ` Thomas Monjalon
2016-04-30 8:50 ` Ariel Rodriguez
2016-05-01 19:58 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).