From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id A9E162BA8
 for <dev@dpdk.org>; Sun,  1 May 2016 21:58:08 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id g17so19162511wme.0
 for <dev@dpdk.org>; Sun, 01 May 2016 12:58:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=ByV9pO/sSc9S4IDIw9pBjtEaLkT6m99JCa6xR5FpGn4=;
 b=O/EZzURpmZ42rszO51x/cwqux4ixNKUY5V7+K+y69+xq4DO1J93BjjxXzYrPumnkwm
 w3RJTRlJFjMUHJUCa+Y1ndFt36IhwicPeJqF66GOkGeIRMYdXSnupKYmTtE92qO8s5eO
 OmJBD3e6T0JxAO72dudED2hV4XOarNlECKQpgyFxtlCSOj8M2uFuPSaJJE8s9ypweX6m
 MwGUMFfk6GvGIE09j3QMgidhqTmsU5elRoKH0CuIHtbJSPbS+7BdliLIubdJLun6DlJ2
 tzmvtn70gY7XX/j6Hln1H/MYLGA/wRPUItbsEQ6Pbfbu/vFF/Em9f6WGUkA0Zt5YsYLp
 ojPw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=ByV9pO/sSc9S4IDIw9pBjtEaLkT6m99JCa6xR5FpGn4=;
 b=V/XO3x67XY6eYDuMUAVGB6ny0lgbAGRjCJ81hZ8jveLAWAXQOgR4b7lZGTvTC6EzwK
 3EOicNaFVxF85j+Lf1fYsRGKIPqDG7HrQDdX9HB/sK/3iQwuCUbRbTHujTaxJp67l9u2
 xCXYZPWlzJdeBpZKn3tseG8W3yJNlVxGPfUYkQRDLunoQUtJXjaM8EHCfqZzMEqUE4tN
 XNP49bGH6004ZsjGVRCzjYHgmbSbKjo/Lb7xR26Yz6nCjZTLHwBu4FPFqA8GId9CTGeq
 OMcQR3iR+VQFbFooMKWkaQ0u8XY5lWaUPdTKBh6YhgBKYOkFtd5+PXzxAxZWMmtzNI91
 fyUA==
X-Gm-Message-State: AOPr4FWt9rOpzxBeFZk92F9EBkP9IBsZJquvStiQYOmKrBYZRwHuAa5FYDy2t8DTLAY0T8b9
X-Received: by 10.194.42.69 with SMTP id m5mr8196207wjl.89.1462132688531;
 Sun, 01 May 2016 12:58:08 -0700 (PDT)
Received: from xps13.localnet (207.111.75.86.rev.sfr.net. [86.75.111.207])
 by smtp.gmail.com with ESMTPSA id b22sm14898520wmb.9.2016.05.01.12.58.07
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sun, 01 May 2016 12:58:07 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ariel Rodriguez <arodriguez@callistech.com>
Cc: dev@dpdk.org
Date: Sun, 01 May 2016 21:58:06 +0200
Message-ID: <4885249.p6c3dYjJKD@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <CADoa0bZQw565CdMwhnfBF4=vhkO0AgaUe4+d+QCBZBe0QUSJmg@mail.gmail.com>
References: <CADoa0bbHpkyzJ7-VJAxHPXgOj7uJiLbo_V3iSKgJzNEy4G83aw@mail.gmail.com>
 <132784424.Pjq79LXnpm@xps13>
 <CADoa0bZQw565CdMwhnfBF4=vhkO0AgaUe4+d+QCBZBe0QUSJmg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] Issue on rte_sched.c
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 01 May 2016 19:58:08 -0000

2016-04-30 05:50, Ariel Rodriguez:
> Yes i am refereing on that commit.
> 
> About RTE_MACHINE_CPUFLAG_* , i agreed.
> 
> I never prepare a patch ... maybe is time to put my hands on that.

Yes it is a good way to make your first patch.
See http://dpdk.org/dev#send
Thanks

> 2016-04-13 20:35, Ariel Rodriguez:
> > Hello, viewing the new code of librte_sched/ i found this line strange ...
> >
> > #if defined(__SSE4__)
> 
> Are you refering to http://dpdk.org/commit/90f455f ?
> 
> > if instead i use :
> >
> > #if defined(__SSE4_2__) || defined(__SSE4_1__)
> >
> > works like a charm ...
> >
> > i never see in any directive like __SSE4__
> 
> Indeed, it is strange.
> By the way, it is recommended to use RTE_MACHINE_CPUFLAG_*.