From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 2CE9D1B47B for ; Fri, 15 Feb 2019 09:58:01 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BCC50221D6; Fri, 15 Feb 2019 03:58:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 15 Feb 2019 03:58:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ySYkRqnmWl/PCDXUFlrttv6hM94GjLuLL7W58ctFWj8=; b=WAlY3xPC3RGz VuxfjA+5EjsdeXpTOLnd4nqGUwWTGtOTxQaLCMbixOqWDP8aRYIoBLhH98O3y7nA 2Qjie2lvYmITGc/FIG5B+roQU3jMQu+S00I61O7NyjomNPdAYZnp1BSU1bZZa5eA xzz/xk5PzXKU/9uRCqouIOJE6sBvJXA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ySYkRqnmWl/PCDXUFlrttv6hM94GjLuLL7W58ctFW j8=; b=Tbx6qlNJH0gVYBBfb60nf0wgr+Zg1nYg1Z3oZjNnQjqCE1gmCZNjIucXH 4QuH2qmipgcm9Hv/ScW8RJZKzHYaL4hExqa2ywy/5qKLpYjfplyozofhjBuRU47p aaIDg6Gk+ineRI3xBpIvQuWNL/nvhPXY50b8Lo8tOUNXV/3CQxdzYYJxNIqpnAeX NdOvDCJI4ApHA6wyJklEIGbFc9e0QHnq1Tn0G7yj9qJzz/JXU2xgGF1x3ijgMcG1 vV2fggSC48yebkOoeU4RJ94+2FGTD2Td2fTj5rZA2GiG+t2uIz7fy7U4N9aHJuRH C1FIB9ruVIWdV/3JyHO2oUxrRW+Aw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtiedguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkf gjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhn uceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvd dtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3B5D7E44A1; Fri, 15 Feb 2019 03:57:59 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Bruce Richardson , Wenzhuo Lu , Jingjing Wu , bernard.iremonger@intel.com, Maxime Coquelin , ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Fri, 15 Feb 2019 09:57:58 +0100 Message-ID: <4891070.GnHtSQePbW@xps> In-Reply-To: References: <1550158972-21895-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 08:58:01 -0000 14/02/2019 19:51, David Marchand: > What is the purpose of oerrors ? > > Since the drivers (via rte_eth_tx_burst return value) report the numbers of > packets successfully transmitted, the application can try to retransmit the > packets that did not make it and counts this. > If the driver counts such "missed" packets, then it does the job the > application will do anyway (wasting some cycles). > But what is more a problem is that the application does not know if the > packets in oerrors are its own retries or problems that the driver can not > detect (hw problems) but the hw can. > > So the best option is that oerrors does not report the packets the driver > refuses (and I can see some drivers that do not comply to this) but only > "external" errors from the driver pov. I can see the benefit of having driver errors in the stats, so it is generically stored for later analysis or print. It could be managed at ethdev level instead of the application doing the computation. What about splitting the Tx errors in 2 fields? oerrors / ofull ? Who said it's awful? sorry Bruce for anticipating ;)