From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC59C41D40; Wed, 22 Feb 2023 17:51:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C129E43021; Wed, 22 Feb 2023 17:51:00 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 0232B410DF for ; Wed, 22 Feb 2023 17:50:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4E63B32000F9; Wed, 22 Feb 2023 11:50:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 22 Feb 2023 11:50:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1677084656; x= 1677171056; bh=T6CoJ221kv3I3bTrXcWmkEuKLlHcyprEjjf1o2j9sfQ=; b=S TpV4kcCq+uwvRQcXe3cc9hp+ZppVz9baKJ9bViN15lU0EaLrflRZtOa1U8KP2oUa S2Eli0lzqRG15UJRJ5p0lhYd+yF2YzOBbO+4UHAMzbx+31Kp3s2CNim2GlGBuxG/ b8CQBYFbNV9Zv+DCCVhgZ8FImu95zsS8vYwUk8oU3SXk4BJeazQPPMvxUF2kV8pX tQu2oJR7RhPmsqJQWQLgMOPLVlMrYNaTqbCZ7hy4SzZhT4SmfJpKZyqAz+8Ak8uF SSWFFTDmTGLzvboVSSC1WhoPvR2xxHayLHl+hn7/aaVjYti5+6eBw3TjfcHKTfzp fDg1MfupUtV67/8syBH5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677084656; x= 1677171056; bh=T6CoJ221kv3I3bTrXcWmkEuKLlHcyprEjjf1o2j9sfQ=; b=D TL/BOCRvPmjcvb+eW0UnC/zdtBCRj3Z58TIFjv2FH9IeBYqQYYvem8BXYWcHyb5e dgt26Wd9OYGP8RLchFlGzNBjpBGfG0IYCwWJ7/r0j7dTkEUNO0nLC9EqTjKyOXNo l9lTlojCYsu7hl75Uk0ZLNB2UnC2XQWA2nuD/C/twYG5XcmYOEHP4ZKulFpJxx8a 4Cm+uAR47cIjHOBZCpezWwYyqWb2VE1836PdN5jILaRa8+9rvmnJHN5Pxj1kCAOC eKapxImmzOHdcxmvAriAdKKyg23biOldQV69oO3z7k0uOxvPle66mC10opALWHpP Z3XkLQDS9aK6JsGdl8+Kg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejledgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Feb 2023 11:50:55 -0500 (EST) From: Thomas Monjalon To: Eli Britstein Cc: dev@dpdk.org, asafp@nvidia.com, Ori Kam , Aman Singh , Yuying Zhang Subject: Re: [PATCH 2/2] app/testpmd: user assigned flow ID to flows Date: Wed, 22 Feb 2023 17:50:53 +0100 Message-ID: <4891383.oAaWjsssbx@thomas> In-Reply-To: <20230222141139.3233715-2-elibr@nvidia.com> References: <20230222141139.3233715-1-elibr@nvidia.com> <20230222141139.3233715-2-elibr@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/02/2023 15:11, Eli Britstein: > Currently, testpmd assigns its own IDs, as indices, to created flows. > Later, the flow index is used as the ID for flow operations (query, > destroy, dump). > > Allow the user to assign a user-id, to be later used as an alternative > to the flow index testpmd assigns. > > Example: > > testpmd> flow create 0 ingress user_id 0x1234 pattern eth / end actions > count / drop / end > Flow rule #0 created, user-id 0x1234 > > testpmd> flow query 0 0x1234 count user_id > > testpmd> flow dump 0 user_id rule 0x1234 > > testpmd> flow destroy 0 rule 0x1234 user_id > Flow rule user_id 0x1234 destroyed > > testpmd> flow destroy 0 rule 0x1234 user_id > Flow rule #0 destroyed, user-id 0x1234 > > Signed-off-by: Eli Britstein Please Eli, we need explain why adding this feature. Could you add the justification done in the RFC? Thank you.