From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2228E322C for ; Mon, 22 Jan 2018 23:09:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 919262102E; Mon, 22 Jan 2018 17:09:50 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 22 Jan 2018 17:09:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=MCwizCyZ5kNxR1ekZaXdmvPLG/ 10+safhcNbHNJXhbE=; b=qPcbBit14i0RpT/39GQ2jO4sRWVcUvyjQe3G0/4/Dr TDgn47mHoCEbAUScDL64OQGryj+Qm2CBXJPUUrCrta+g1zz20sBqIEZQ6y5VaxS/ iMH6RJ7mA6k2/BNjAOYly9FtCq7PpvJ6wd6tHBEVsX/b7pCj5mOdp6H0lpxS/dEz Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=MCwizC yZ5kNxR1ekZaXdmvPLG/10+safhcNbHNJXhbE=; b=mzO4/rpZ46F+PqhMRgbK27 oAbCor6X/MNU3FPaAcEKm0NfWmzE5J7wx7SrZzmg30YfdWPhS/m15UbNyLCH8wKG LGKKvjCQSzWgzYGORkRHvrTUwaEw5FB5WnWPSslDrsqhdM1X4+00vK+Huz9RdIYJ ZRryQSmTipm8UZFUlzZrClrynHMRfjntelUut1LFXKdbeGWdwwi0XTIBCc5Rfjl7 4OXe8aimvUibwFZsNhtFyljJy4aHteXVpnf3vjveBcd5Gwl9cgGlELT1u71Bm94F UogKwivFrrSceRMpnj8s+YnzP570NQXxW1TZGjswV0tltLEjf0Ote6TZCIsc3Zlg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30AD87E1BE; Mon, 22 Jan 2018 17:09:50 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: Ferruh Yigit , chaozhu@linux.vnet.ibm.com, dev@dpdk.org, Bruce Richardson , Konstantin Ananyev , Jonas Pfefferle Date: Mon, 22 Jan 2018 23:09:11 +0100 Message-ID: <4894428.B7fjvfO1a3@xps> In-Reply-To: <20180122134853.0cf85c70@xeon-e3> References: <20180116183755.24542-1-stephen@networkplumber.org> <4302048.2hzkQNGxWI@xps> <20180122134853.0cf85c70@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 01/14] eal: introduce atomic exchange operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 22:09:51 -0000 22/01/2018 22:48, Stephen Hemminger: > On Mon, 22 Jan 2018 22:03:02 +0100 > Thomas Monjalon wrote: > > > 22/01/2018 17:56, Stephen Hemminger: > > > On Mon, 22 Jan 2018 00:50:55 +0100 > > > Thomas Monjalon wrote: > > > > > > > 21/01/2018 20:25, Ferruh Yigit: > > > > > On 1/21/2018 6:59 PM, Ferruh Yigit wrote: > > > > > > From: Stephen Hemminger > > > > > > > > > > > > To handle atomic update of link status (64 bit), every driver > > > > > > was doing its own version using cmpset. > > > > > > Atomic exchange is a useful primitive in its own right; > > > > > > therefore make it a EAL routine. > > > > > > > > > > > > Signed-off-by: Stephen Hemminger > > > > > > Reviewed-by: Ferruh Yigit > > > > > Series applied to dpdk-next-net/master, thanks. > > > > > > > > I need to drop this series when pulling in master, > > > > because PPC is not supported. > > > > > > > > Chao, please could you help on this feature? > > > > Thanks > > > > > > The generic code should work for PPC. > > > > No, the generic code is inside #ifdef RTE_FORCE_INTRINSICS. > > PPC does not define RTE_FORCE_INTRINSICS, > > and ARM could disable it I guess. > > I will add a non intrinsic generic version using cmpset. OK thanks