* [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option
@ 2021-01-11 13:55 Bruce Richardson
2021-01-11 16:19 ` Andrew Boyer
2021-01-11 17:40 ` [dpdk-dev] " Honnappa Nagarahalli
0 siblings, 2 replies; 5+ messages in thread
From: Bruce Richardson @ 2021-01-11 13:55 UTC (permalink / raw)
To: dev; +Cc: thomas, aboyer, Honnappa.Nagarahalli, Bruce Richardson, stable
Rather than having the DPDK configuration error out when linking apps
and examples when "both" is select for "default_library" option, we can
detect that setting earlier in the build config and provide a suitable
error message to the user.
CC: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
config/meson.build | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/config/meson.build b/config/meson.build
index 3ddcc3539..05e9cede5 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -308,3 +308,12 @@ if get_option('b_lto')
add_project_link_arguments('-Wno-lto-type-mismatch', language: 'c')
endif
endif
+
+if get_option('default_library') == 'both'
+ error( '''
+ Unsupported value "both" for "default_library" option.
+
+ NOTE: DPDK always builds both shared and static libraries. Please set
+ "default_library" to either "static" or "shared" to select default linkage
+ for apps and any examples''')
+endif
--
2.27.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option
2021-01-11 13:55 [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option Bruce Richardson
@ 2021-01-11 16:19 ` Andrew Boyer
2021-01-11 16:57 ` Bruce Richardson
2021-01-20 0:49 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-01-11 17:40 ` [dpdk-dev] " Honnappa Nagarahalli
1 sibling, 2 replies; 5+ messages in thread
From: Andrew Boyer @ 2021-01-11 16:19 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, thomas, Honnappa.Nagarahalli, stable
> On Jan 11, 2021, at 8:55 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> Rather than having the DPDK configuration error out when linking apps
> and examples when "both" is select for "default_library" option, we can
> detect that setting earlier in the build config and provide a suitable
> error message to the user.
>
> CC: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> config/meson.build | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/config/meson.build b/config/meson.build
> index 3ddcc3539..05e9cede5 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -308,3 +308,12 @@ if get_option('b_lto')
> add_project_link_arguments('-Wno-lto-type-mismatch', language: 'c')
> endif
> endif
> +
> +if get_option('default_library') == 'both'
> + error( '''
> + Unsupported value "both" for "default_library" option.
> +
> + NOTE: DPDK always builds both shared and static libraries. Please set
> + "default_library" to either "static" or "shared" to select default linkage
> + for apps and any examples''')
Should there be a period after ‘examples’?
> +endif
> --
> 2.27.0
>
Reviewed-by: Andrew Boyer <aboyer@pensando.io>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option
2021-01-11 16:19 ` Andrew Boyer
@ 2021-01-11 16:57 ` Bruce Richardson
2021-01-20 0:49 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
1 sibling, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2021-01-11 16:57 UTC (permalink / raw)
To: Andrew Boyer; +Cc: dev, thomas, Honnappa.Nagarahalli, stable
On Mon, Jan 11, 2021 at 11:19:26AM -0500, Andrew Boyer wrote:
>
>
> > On Jan 11, 2021, at 8:55 AM, Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> >
> > Rather than having the DPDK configuration error out when linking apps
> > and examples when "both" is select for "default_library" option, we can
> > detect that setting earlier in the build config and provide a suitable
> > error message to the user.
> >
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> ---
> > config/meson.build | 9 +++++++++ 1 file changed, 9 insertions(+)
> >
> > diff --git a/config/meson.build b/config/meson.build index
> > 3ddcc3539..05e9cede5 100644 --- a/config/meson.build +++
> > b/config/meson.build @@ -308,3 +308,12 @@ if get_option('b_lto')
> > add_project_link_arguments('-Wno-lto-type-mismatch', language: 'c')
> > endif endif + +if get_option('default_library') == 'both' + error( '''
> > + Unsupported value "both" for "default_library" option. + +
> > NOTE: DPDK always builds both shared and static libraries. Please set
> > + "default_library" to either "static" or "shared" to select default
> > linkage + for apps and any examples''')
>
> Should there be a period after ‘examples’?
>
Yes, to have it a valid English sentence. If there are no other comments to
fix I'll not do a v2 for it alone, though - committers, feel free to add
one on apply.
/Bruce
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option
2021-01-11 13:55 [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option Bruce Richardson
2021-01-11 16:19 ` Andrew Boyer
@ 2021-01-11 17:40 ` Honnappa Nagarahalli
1 sibling, 0 replies; 5+ messages in thread
From: Honnappa Nagarahalli @ 2021-01-11 17:40 UTC (permalink / raw)
To: Bruce Richardson, dev
Cc: thomas, aboyer, stable, Honnappa Nagarahalli, nd, nd
<snip>
>
> Rather than having the DPDK configuration error out when linking apps and
> examples when "both" is select for "default_library" option, we can detect
> that setting earlier in the build config and provide a suitable error message to
> the user.
>
> CC: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Looks good, thanks Bruce
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> config/meson.build | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/config/meson.build b/config/meson.build index
> 3ddcc3539..05e9cede5 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -308,3 +308,12 @@ if get_option('b_lto')
> add_project_link_arguments('-Wno-lto-type-mismatch',
> language: 'c')
> endif
> endif
> +
> +if get_option('default_library') == 'both'
> + error( '''
> + Unsupported value "both" for "default_library" option.
> +
> + NOTE: DPDK always builds both shared and static libraries. Please set
> + "default_library" to either "static" or "shared" to select default linkage
> + for apps and any examples''')
> +endif
> --
> 2.27.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] build: provide suitable error for "both" libraries option
2021-01-11 16:19 ` Andrew Boyer
2021-01-11 16:57 ` Bruce Richardson
@ 2021-01-20 0:49 ` Thomas Monjalon
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-01-20 0:49 UTC (permalink / raw)
To: Bruce Richardson; +Cc: stable, dev, Honnappa.Nagarahalli, Andrew Boyer
11/01/2021 17:19, Andrew Boyer:
> > On Jan 11, 2021, at 8:55 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:
> >
> > Rather than having the DPDK configuration error out when linking apps
> > and examples when "both" is select for "default_library" option, we can
> > detect that setting earlier in the build config and provide a suitable
> > error message to the user.
> >
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > +if get_option('default_library') == 'both'
> > + error( '''
> > + Unsupported value "both" for "default_library" option.
> > +
> > + NOTE: DPDK always builds both shared and static libraries. Please set
> > + "default_library" to either "static" or "shared" to select default linkage
> > + for apps and any examples''')
>
> Should there be a period after ‘examples’?
>
> Reviewed-by: Andrew Boyer <aboyer@pensando.io>
Applied with above fixup, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-20 0:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 13:55 [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option Bruce Richardson
2021-01-11 16:19 ` Andrew Boyer
2021-01-11 16:57 ` Bruce Richardson
2021-01-20 0:49 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-01-11 17:40 ` [dpdk-dev] " Honnappa Nagarahalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).