From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Zoltan Kiss <zoltan.kiss@schaman.hu>
Cc: dev@dpdk.org, Nicolas Pernas Maradei <nicolas.pernas.maradei@emutex.com>
Subject: Re: [dpdk-dev] net/pcap: set rte_errno on TX error
Date: Mon, 25 Jul 2016 15:43:45 +0200 [thread overview]
Message-ID: <48982545.S9g3uDomrp@xps13> (raw)
In-Reply-To: <5796153A.1070007@intel.com>
2016-07-25 14:33, Ferruh Yigit:
> On 7/25/2016 2:10 PM, Zoltan Kiss wrote:
> > This returns the error code provided by pcap_sendpacket()
>
> Although this is good idea, this adds undocumented side effect to
> rte_eth_tx_burst().
>
> I am not able to find any information in rte_eth_tx_burst() that it can
> alter rte_errno.
>
> Since rte_errno is shared resource, it shouldn't be updated without
> documented.
That's something I was looking into.
Maybe we should generalize the use of rte_errno in 16.11?
prev parent reply other threads:[~2016-07-25 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 13:10 Zoltan Kiss
2016-07-25 13:33 ` Ferruh Yigit
2016-07-25 13:43 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48982545.S9g3uDomrp@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nicolas.pernas.maradei@emutex.com \
--cc=zoltan.kiss@schaman.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).